From patchwork Fri Feb  6 00:19:26 2009
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Anton Blanchard <anton@samba.org>
X-Patchwork-Id: 23007
Return-Path: <yaboot-devel-bounces+incoming=patchwork.ozlabs.org@ozlabs.org>
X-Original-To: incoming@patchwork.ozlabs.org
Delivered-To: patchwork-incoming@ozlabs.org
Received: from ozlabs.org (localhost [127.0.0.1])
	by ozlabs.org (Postfix) with ESMTP id 151FBDDE0E
	for <incoming@patchwork.ozlabs.org>;
	Thu, 12 Feb 2009 19:44:36 +1100 (EST)
X-Original-To: yaboot-devel@ozlabs.org
Delivered-To: yaboot-devel@ozlabs.org
Received: by ozlabs.org (Postfix, from userid 1010)
	id 97F94DDE9E; Fri,  6 Feb 2009 11:21:30 +1100 (EST)
Date: Fri, 6 Feb 2009 11:19:26 +1100
From: Anton Blanchard <anton@samba.org>
To: yaboot-devel@ozlabs.org
Subject: ybin succeeds but returns error code
Message-ID: <20090206001926.GA23273@kryten>
MIME-Version: 1.0
Content-Disposition: inline
User-Agent: Mutt/1.5.18 (2008-05-17)
X-Mailman-Approved-At: Thu, 12 Feb 2009 19:44:32 +1100
X-BeenThere: yaboot-devel@ozlabs.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: Technical and development discussion regarding yaboot
	<yaboot-devel.ozlabs.org>
List-Unsubscribe: <https://ozlabs.org/mailman/options/yaboot-devel>,
	<mailto:yaboot-devel-request@ozlabs.org?subject=unsubscribe>
List-Archive: <http://ozlabs.org/pipermail/yaboot-devel>
List-Post: <mailto:yaboot-devel@ozlabs.org>
List-Help: <mailto:yaboot-devel-request@ozlabs.org?subject=help>
List-Subscribe: <https://ozlabs.org/mailman/listinfo/yaboot-devel>,
	<mailto:yaboot-devel-request@ozlabs.org?subject=subscribe>
Sender: yaboot-devel-bounces+incoming=patchwork.ozlabs.org@ozlabs.org
Errors-To: yaboot-devel-bounces+incoming=patchwork.ozlabs.org@ozlabs.org

Hi,

On a System p box, ybin returns an error even though it succeeds:

# ybin 
# echo $?
1

The patch below fixes it:

# ybin 
# echo $?
0

Signed-off-by: Anton Blanchard <anton@samba.org>

diff --git a/ybin/ybin b/ybin/ybin
index 379b94b..cf58db9 100755
--- a/ybin/ybin
+++ b/ybin/ybin
@@ -1152,6 +1152,7 @@ raw_install()
     fi
     sync ; sync
     [ "$VERBOSE" = 1 ] && echo "$PRG: Installation successful"
+    return 0
 }
 
 ## make sure the first stage ofboot generator is compatible.