Patchwork [1/5] vl: add runstate_set tracepoint

login
register
mail settings
Submitter Kazuya Saito
Date March 22, 2013, 8:26 a.m.
Message ID <514C15D3.1020003@jp.fujitsu.com>
Download mbox | patch
Permalink /patch/229906/
State New
Headers show

Comments

Kazuya Saito - March 22, 2013, 8:26 a.m.
This patch enables us to know RunState transition. It will be userful
for investigation when the trouble occured in special event such like
live migration, shutdown, suspend, and so on.

Signed-off-by: Kazuya Saito <saito.kazuya@jp.fujitsu.com>
---
 trace-events |    1 +
 vl.c         |    2 +-
 2 files changed, 2 insertions(+), 1 deletions(-)
Paolo Bonzini - March 22, 2013, 11:13 a.m.
Il 22/03/2013 09:26, Kazuya Saito ha scritto:
> This patch enables us to know RunState transition. It will be userful
> for investigation when the trouble occured in special event such like
> live migration, shutdown, suspend, and so on.
> 
> Signed-off-by: Kazuya Saito <saito.kazuya@jp.fujitsu.com>
> ---
>  trace-events |    1 +
>  vl.c         |    2 +-
>  2 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/trace-events b/trace-events
> index d6a847d..1e352a7 100644
> --- a/trace-events
> +++ b/trace-events
> @@ -474,6 +474,7 @@ scsi_request_sense(int target, int lun, int tag) "target %d lun %d tag %d"
>  # vl.c
>  vm_state_notify(int running, int reason) "running %d reason %d"
>  load_file(const char *name, const char *path) "name %s location %s"
> +runstate_set(int new_state) "new state %d"
> 
>  # block/qcow2.c
>  qcow2_writev_start_req(void *co, int64_t sector, int nb_sectors) "co %p sector %" PRIx64 " nb_sectors %d"
> diff --git a/vl.c b/vl.c
> index a621aec..4bd3671 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -638,7 +638,7 @@ void runstate_set(RunState new_state)
>                  RunState_lookup[new_state]);
>          abort();
>      }
> -
> +    trace_runstate_set(new_state);
>      current_run_state = new_state;
>  }
> 

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Stefan Hajnoczi - March 28, 2013, 1:21 p.m.
On Fri, Mar 22, 2013 at 05:26:59PM +0900, Kazuya Saito wrote:
> This patch enables us to know RunState transition. It will be userful
> for investigation when the trouble occured in special event such like
> live migration, shutdown, suspend, and so on.
> 
> Signed-off-by: Kazuya Saito <saito.kazuya@jp.fujitsu.com>
> ---
>  trace-events |    1 +
>  vl.c         |    2 +-
>  2 files changed, 2 insertions(+), 1 deletions(-)

Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing

Stefan

Patch

diff --git a/trace-events b/trace-events
index d6a847d..1e352a7 100644
--- a/trace-events
+++ b/trace-events
@@ -474,6 +474,7 @@  scsi_request_sense(int target, int lun, int tag) "target %d lun %d tag %d"
 # vl.c
 vm_state_notify(int running, int reason) "running %d reason %d"
 load_file(const char *name, const char *path) "name %s location %s"
+runstate_set(int new_state) "new state %d"

 # block/qcow2.c
 qcow2_writev_start_req(void *co, int64_t sector, int nb_sectors) "co %p sector %" PRIx64 " nb_sectors %d"
diff --git a/vl.c b/vl.c
index a621aec..4bd3671 100644
--- a/vl.c
+++ b/vl.c
@@ -638,7 +638,7 @@  void runstate_set(RunState new_state)
                 RunState_lookup[new_state]);
         abort();
     }
-
+    trace_runstate_set(new_state);
     current_run_state = new_state;
 }