Patchwork net: Fix p3_gelic_net sparse warnings

login
register
mail settings
Submitter Geoff Levand
Date March 21, 2013, 8:35 p.m.
Message ID <1363898133.1075.43.camel@smoke>
Download mbox | patch
Permalink /patch/229835/
State Changes Requested
Delegated to: David Miller
Headers show

Comments

Geoff Levand - March 21, 2013, 8:35 p.m.
Fix these sparse warnings:

  ps3_gelic_net.c: error: marked inline, but without a definition

Signed-off-by: Geoff Levand <geoff@infradead.org>
---

Hi Dave,

Please queue for 3.10.  Thanks.

-Geoff

 drivers/net/ethernet/toshiba/ps3_gelic_net.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
David Miller - March 21, 2013, 9:17 p.m.
From: Geoff Levand <geoff@infradead.org>
Date: Thu, 21 Mar 2013 13:35:33 -0700

> Fix these sparse warnings:
> 
>   ps3_gelic_net.c: error: marked inline, but without a definition
> 
> Signed-off-by: Geoff Levand <geoff@infradead.org>
> ---
> 
> Hi Dave,
> 
> Please queue for 3.10.  Thanks.

I'd rather you removed all of the inline tags from this foo.c
file, they are pointless with modern compilers.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_net.c b/drivers/net/ethernet/toshiba/ps3_gelic_net.c
index 445c059..8d03fcb 100644
--- a/drivers/net/ethernet/toshiba/ps3_gelic_net.c
+++ b/drivers/net/ethernet/toshiba/ps3_gelic_net.c
@@ -294,7 +294,7 @@  iommu_error:
  * Reset the status of dma descriptors to ready state
  * and re-initialize the hardware chain for later use
  */
-static void gelic_card_reset_chain(struct gelic_card *card,
+static inline void gelic_card_reset_chain(struct gelic_card *card,
 				   struct gelic_descr_chain *chain,
 				   struct gelic_descr *start_descr)
 {