From patchwork Thu Mar 21 16:05:39 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Orit Wasserman X-Patchwork-Id: 229753 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 5F9C72C00C0 for ; Fri, 22 Mar 2013 03:09:53 +1100 (EST) Received: from localhost ([::1]:43441 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIi3r-0007QZ-Hs for incoming@patchwork.ozlabs.org; Thu, 21 Mar 2013 12:09:51 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41625) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIhzd-00022U-51 for qemu-devel@nongnu.org; Thu, 21 Mar 2013 12:05:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UIhzO-0005tS-Jd for qemu-devel@nongnu.org; Thu, 21 Mar 2013 12:05:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4487) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIhzO-0005sy-BB for qemu-devel@nongnu.org; Thu, 21 Mar 2013 12:05:14 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2LG5C7w031222 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 21 Mar 2013 12:05:12 -0400 Received: from dhcp-1-120.tlv.redhat.com (vpn-200-38.tlv.redhat.com [10.35.200.38]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r2LG4SsY000931; Thu, 21 Mar 2013 12:05:08 -0400 From: Orit Wasserman To: qemu-devel@nongnu.org Date: Thu, 21 Mar 2013 18:05:39 +0200 Message-Id: <1363881940-27505-9-git-send-email-owasserm@redhat.com> In-Reply-To: <1363881940-27505-1-git-send-email-owasserm@redhat.com> References: <1363881940-27505-1-git-send-email-owasserm@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: Orit Wasserman , pbonzini@redhat.com, mst@redhat.com, chegu_vinod@hp.com, quintela@redhat.com Subject: [Qemu-devel] [PATCH v3 8/9] Use qemu_put_buffer_no_copy for guest memory pages X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This will remove an unneeded copy of guest memory pages. For the page header and device state we still copy the data to the static buffer the other option is to allocate the memory on demand which is more expensive. Signed-off-by: Orit Wasserman --- arch_init.c | 2 +- savevm.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch_init.c b/arch_init.c index 98e2bc6..27b53eb 100644 --- a/arch_init.c +++ b/arch_init.c @@ -481,7 +481,7 @@ static int ram_save_block(QEMUFile *f, bool last_stage) /* XBZRLE overflow or normal page */ if (bytes_sent == -1) { bytes_sent = save_block_hdr(f, block, offset, cont, RAM_SAVE_FLAG_PAGE); - qemu_put_buffer(f, p, TARGET_PAGE_SIZE); + qemu_put_buffer_no_copy(f, p, TARGET_PAGE_SIZE); bytes_sent += TARGET_PAGE_SIZE; acct_info.norm_pages++; } diff --git a/savevm.c b/savevm.c index fbfb9e3..50e8fb2 100644 --- a/savevm.c +++ b/savevm.c @@ -634,7 +634,7 @@ void qemu_put_buffer_no_copy(QEMUFile *f, const uint8_t *buf, int size) abort(); } - f->iov[f->iovcnt].iov_base = f->buf + f->buf_index; + f->iov[f->iovcnt].iov_base = (uint8_t *)buf; f->iov[f->iovcnt++].iov_len = size; f->is_write = 1;