Patchwork [U-Boot] musb: am335x: disable bulk split-combine feature

login
register
mail settings
Submitter Bin Liu
Date March 21, 2013, 3:27 p.m.
Message ID <1363879669-30747-1-git-send-email-b-liu@ti.com>
Download mbox | patch
Permalink /patch/229733/
State Accepted
Delegated to: Tom Rini
Headers show

Comments

Bin Liu - March 21, 2013, 3:27 p.m.
On TI AM335x devices, MUSB has bulk split/combine feature enabled
in the ConfigData register, but the current MUSB driver does not
support it yet. Therefore, disable the feature for now, until the
driver adds the support.

One usecase which is broken because of this feature is that Ether
gadget stops working in Fullspeed mode (by un-defining
CONFIG_USB_GADGET_DUALSPEED)

After desabled this feature, MUSB driver send packets in proper size
(no more than 64 bytes) in Fullspeed mode.

This has been validated with Ether gadget in Fullspeed mode on AM335x
EVM.

Signed-off-by: Bin Liu <b-liu@ti.com>
---
 drivers/usb/musb-new/musb_core.c |    5 +++++
 include/configs/am335x_evm.h     |    1 +
 2 files changed, 6 insertions(+)
Tom Rini - April 8, 2013, 4:56 p.m.
On Thu, Mar 21, 2013 at 05:27:48AM -0000, Bin Liu wrote:

> On TI AM335x devices, MUSB has bulk split/combine feature enabled
> in the ConfigData register, but the current MUSB driver does not
> support it yet. Therefore, disable the feature for now, until the
> driver adds the support.
> 
> One usecase which is broken because of this feature is that Ether
> gadget stops working in Fullspeed mode (by un-defining
> CONFIG_USB_GADGET_DUALSPEED)
> 
> After desabled this feature, MUSB driver send packets in proper size
> (no more than 64 bytes) in Fullspeed mode.
> 
> This has been validated with Ether gadget in Fullspeed mode on AM335x
> EVM.
> 
> Signed-off-by: Bin Liu <b-liu@ti.com>

Applied to u-boot-ti/master, thanks!

Patch

diff --git a/drivers/usb/musb-new/musb_core.c b/drivers/usb/musb-new/musb_core.c
index 040a5c0..aa647e6 100644
--- a/drivers/usb/musb-new/musb_core.c
+++ b/drivers/usb/musb-new/musb_core.c
@@ -1421,6 +1421,7 @@  static int __devinit musb_core_init(u16 musb_type, struct musb *musb)
 		strcat(aInfo, ", dyn FIFOs");
 		musb->dyn_fifo = true;
 	}
+#ifndef CONFIG_MUSB_DISABLE_BULK_COMBINE_SPLIT
 	if (reg & MUSB_CONFIGDATA_MPRXE) {
 		strcat(aInfo, ", bulk combine");
 		musb->bulk_combine = true;
@@ -1429,6 +1430,10 @@  static int __devinit musb_core_init(u16 musb_type, struct musb *musb)
 		strcat(aInfo, ", bulk split");
 		musb->bulk_split = true;
 	}
+#else
+	musb->bulk_combine = false;
+	musb->bulk_split = false;
+#endif
 	if (reg & MUSB_CONFIGDATA_HBRXE) {
 		strcat(aInfo, ", HB-ISO Rx");
 		musb->hb_iso_rx = true;
diff --git a/include/configs/am335x_evm.h b/include/configs/am335x_evm.h
index 74a70ee..faf9581 100644
--- a/include/configs/am335x_evm.h
+++ b/include/configs/am335x_evm.h
@@ -450,6 +450,7 @@ 
 #define CONFIG_ARCH_MISC_INIT
 #define CONFIG_MUSB_GADGET
 #define CONFIG_MUSB_PIO_ONLY
+#define CONFIG_MUSB_DISABLE_BULK_COMBINE_SPLIT
 #define CONFIG_USB_GADGET_DUALSPEED
 #define CONFIG_USB_GADGET_VBUS_DRAW	2
 #define CONFIG_MUSB_HOST