Patchwork [U-Boot,4/8] patman: Fix the comment in CheckTags to mention multiple tags

login
register
mail settings
Submitter Simon Glass
Date March 21, 2013, 2:42 a.m.
Message ID <1363833781-14557-5-git-send-email-sjg@chromium.org>
Download mbox | patch
Permalink /patch/229538/
State Superseded, archived
Delegated to: Simon Glass
Headers show

Comments

Simon Glass - March 21, 2013, 2:42 a.m.
This comment is less than helpful. Since multiple tags are supported, add
an example of how multiple tags work.

Signed-off-by: Simon Glass <sjg@chromium.org>
---
 tools/patman/commit.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Doug Anderson - March 21, 2013, 4:53 p.m.
Simon,

On Wed, Mar 20, 2013 at 7:42 PM, Simon Glass <sjg@chromium.org> wrote:
> This comment is less than helpful. Since multiple tags are supported, add
> an example of how multiple tags work.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>  tools/patman/commit.py | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Reviewed-by: Doug Anderson <dianders@chromium.org>

Patch

diff --git a/tools/patman/commit.py b/tools/patman/commit.py
index 64baf52..eb3c023 100644
--- a/tools/patman/commit.py
+++ b/tools/patman/commit.py
@@ -61,9 +61,10 @@  class Commit:
 
         Subject tags look like this:
 
-            propounder: Change the widget to propound correctly
+            propounder: fort: Change the widget to propound correctly
 
-        Multiple tags are supported. The list is updated in self.tag
+        Here the tags are propounder and fort. Multiple tags are supported.
+        The list is updated in self.tag.
 
         Returns:
             None if ok, else the name of a tag with no email alias