Patchwork [2/2] Documentation/connector/cn_test.c: don't use gfp_any()

login
register
mail settings
Submitter Andrew Morton
Date Feb. 11, 2009, 9:27 p.m.
Message ID <200902112127.n1BLRKcv031578@imap1.linux-foundation.org>
Download mbox | patch
Permalink /patch/22952/
State Accepted
Delegated to: David Miller
Headers show

Comments

Andrew Morton - Feb. 11, 2009, 9:27 p.m.
From: Andrew Morton <akpm@linux-foundation.org>

cn_test_timer_func() is a timer handler and can never use GFP_KERNEL -
there's no point in using gfp_any() here.

Also, use setup_timer().

Cc: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Andi Kleen <andi@firstfloor.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 Documentation/connector/cn_test.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
Evgeniy Polyakov - Feb. 11, 2009, 10:10 p.m.
On Wed, Feb 11, 2009 at 01:27:19PM -0800, akpm@linux-foundation.org (akpm@linux-foundation.org) wrote:
> From: Andrew Morton <akpm@linux-foundation.org>
> 
> cn_test_timer_func() is a timer handler and can never use GFP_KERNEL -
> there's no point in using gfp_any() here.
> 
> Also, use setup_timer().
> 
> Cc: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Andi Kleen <andi@firstfloor.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

Looks good for the documentation update :)
Thank you.
David Miller - Feb. 13, 2009, 12:47 a.m.
From: akpm@linux-foundation.org
Date: Wed, 11 Feb 2009 13:27:19 -0800

> cn_test_timer_func() is a timer handler and can never use GFP_KERNEL -
> there's no point in using gfp_any() here.
> 
> Also, use setup_timer().
> 
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff -puN Documentation/connector/cn_test.c~documentation-connector-cn_testc-dont-use-gfp_any Documentation/connector/cn_test.c
--- a/Documentation/connector/cn_test.c~documentation-connector-cn_testc-dont-use-gfp_any
+++ a/Documentation/connector/cn_test.c
@@ -137,7 +137,7 @@  static void cn_test_timer_func(unsigned 
 
 		memcpy(m + 1, data, m->len);
 
-		cn_netlink_send(m, 0, gfp_any());
+		cn_netlink_send(m, 0, GFP_ATOMIC);
 		kfree(m);
 	}
 
@@ -160,10 +160,8 @@  static int cn_test_init(void)
 		goto err_out;
 	}
 
-	init_timer(&cn_test_timer);
-	cn_test_timer.function = cn_test_timer_func;
+	setup_timer(&cn_test_timer, cn_test_timer_func, 0);
 	cn_test_timer.expires = jiffies + HZ;
-	cn_test_timer.data = 0;
 	add_timer(&cn_test_timer);
 
 	return 0;