Patchwork net: fec: make local function fec_poll_controller() static

login
register
mail settings
Submitter Wei Yongjun
Date March 20, 2013, 3:06 p.m.
Message ID <CAPgLHd-ZLKjHdqc_Bm44co+9eTF48TOg9zY8c1jbqeG+jnn3GQ@mail.gmail.com>
Download mbox | patch
Permalink /patch/229412/
State Accepted
Delegated to: David Miller
Headers show

Comments

Wei Yongjun - March 20, 2013, 3:06 p.m.
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

fec_poll_controller() was not declared. It should be static.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
 drivers/net/ethernet/freescale/fec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Li Frank-B20596 - March 20, 2013, 3:11 p.m.
Acked.

> -----Original Message-----
> From: Wei Yongjun [mailto:weiyj.lk@gmail.com]
> Sent: Wednesday, March 20, 2013 11:06 PM
> To: grant.likely@secretlab.ca; rob.herring@calxeda.com; davem@davemloft.net;
> Li Frank-B20596; shawn.guo@linaro.org; Estevam Fabio-R49496;
> s.hauer@pengutronix.de
> Cc: yongjun_wei@trendmicro.com.cn; netdev@vger.kernel.org; devicetree-
> discuss@lists.ozlabs.org
> Subject: [PATCH] net: fec: make local function fec_poll_controller() static
> 
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> 
> fec_poll_controller() was not declared. It should be static.
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
>  drivers/net/ethernet/freescale/fec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/freescale/fec.c
> b/drivers/net/ethernet/freescale/fec.c
> index e3f3937..1ece68b 100644
> --- a/drivers/net/ethernet/freescale/fec.c
> +++ b/drivers/net/ethernet/freescale/fec.c
> @@ -1559,7 +1559,7 @@ fec_set_mac_address(struct net_device *ndev, void *p)
>   * Polled functionality used by netconsole and others in non interrupt mode
>   *
>   */
> -void fec_poll_controller(struct net_device *dev)
> +static void fec_poll_controller(struct net_device *dev)
>  {
>  	int i;
>  	struct fec_enet_private *fep = netdev_priv(dev);
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - March 20, 2013, 5:26 p.m.
From: Wei Yongjun <weiyj.lk@gmail.com>
Date: Wed, 20 Mar 2013 23:06:11 +0800

> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> 
> fec_poll_controller() was not declared. It should be static.
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/ethernet/freescale/fec.c b/drivers/net/ethernet/freescale/fec.c
index e3f3937..1ece68b 100644
--- a/drivers/net/ethernet/freescale/fec.c
+++ b/drivers/net/ethernet/freescale/fec.c
@@ -1559,7 +1559,7 @@  fec_set_mac_address(struct net_device *ndev, void *p)
  * Polled functionality used by netconsole and others in non interrupt mode
  *
  */
-void fec_poll_controller(struct net_device *dev)
+static void fec_poll_controller(struct net_device *dev)
 {
 	int i;
 	struct fec_enet_private *fep = netdev_priv(dev);