From patchwork Wed Mar 20 14:21:38 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rini X-Patchwork-Id: 229402 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 80B662C00A4 for ; Thu, 21 Mar 2013 01:22:10 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id D54CB4A02D; Wed, 20 Mar 2013 15:22:04 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VYrGnYUPUySZ; Wed, 20 Mar 2013 15:22:04 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 20E8F4A02F; Wed, 20 Mar 2013 15:22:02 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id A685A4A02F for ; Wed, 20 Mar 2013 15:21:59 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1fvzujkwIJiL for ; Wed, 20 Mar 2013 15:21:47 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-qe0-f41.google.com (mail-qe0-f41.google.com [209.85.128.41]) by theia.denx.de (Postfix) with ESMTPS id 5B8F34A02D for ; Wed, 20 Mar 2013 15:21:45 +0100 (CET) Received: by mail-qe0-f41.google.com with SMTP id 7so1100393qeb.14 for ; Wed, 20 Mar 2013 07:21:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:from:to:subject:date:message-id:x-mailer; bh=PaaOYT/4U51OMa96xyaLpza+idimOs1BVI93QrhQw/Y=; b=A38zPGgVLuZHdP0Fs7jugOS8KGHdkYFTR9RLLoKfsVJre6xfPY0yfLy7u7pZPfh/sd vl57k30PrqwskvI1BIK5SjT6shmraTThw3gHK8rmUT56E697C+UCB57rdddeax8kmgyC cR/ZYkECR9NEOpH8gwcT8RzwKY+U2kL7JvZeBTImPHUWvYIRatQVloxAyxFQ4+2ejzdR KQpFxPOALurmLb5PHouKKPyRuKljjawEMBFH7cTfADdALNV07EHvKVP1h+riu04zlw+v jsj3WoYEcQfYJCbtsDg0vrXCiOzXY1PVYFZaayLHW6MawkUgI8DnomyXS4058jgiGpcc uWpA== X-Received: by 10.224.31.73 with SMTP id x9mr6432170qac.11.1363789302283; Wed, 20 Mar 2013 07:21:42 -0700 (PDT) Received: from localhost.localdomain (cpe-065-184-250-089.ec.res.rr.com. [65.184.250.89]) by mx.google.com with ESMTPS id q6sm46515231qeu.1.2013.03.20.07.21.39 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 20 Mar 2013 07:21:40 -0700 (PDT) From: Tom Rini To: u-boot@lists.denx.de Date: Wed, 20 Mar 2013 10:21:38 -0400 Message-Id: <1363789298-23791-1-git-send-email-trini@ti.com> X-Mailer: git-send-email 1.7.9.5 Subject: [U-Boot] [PATCH] cmd_ext4: BREAK and correct ext4write parameter order X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de The ext4write command was taking the in-memory address and filename path in reverse order from the rest of the filesystem read and write commands. This corrects the order to be the same as fatload, etc. Signed-off-by: Tom Rini --- common/cmd_ext4.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/common/cmd_ext4.c b/common/cmd_ext4.c index dcf76a5..706fd54 100644 --- a/common/cmd_ext4.c +++ b/common/cmd_ext4.c @@ -88,10 +88,10 @@ int do_ext4_write(cmd_tbl_t *cmdtp, int flag, int argc, dev = dev_desc->dev; /* get the filename */ - filename = argv[3]; + filename = argv[4]; /* get the address in hexadecimal format (string to int) */ - ram_address = simple_strtoul(argv[4], NULL, 16); + ram_address = simple_strtoul(argv[3], NULL, 16); /* get the filesize in base 10 format */ file_size = simple_strtoul(argv[5], NULL, 10); @@ -122,7 +122,7 @@ fail: U_BOOT_CMD(ext4write, 6, 1, do_ext4_write, "create a file in the root directory", - " [Absolute filename path] [Address] [sizebytes]\n" + " [sizebytes]\n" " - create a file in / directory"); #endif