Patchwork [U-Boot] cmd_ext4: BREAK and correct ext4write parameter order

login
register
mail settings
Submitter Tom Rini
Date March 20, 2013, 2:21 p.m.
Message ID <1363789298-23791-1-git-send-email-trini@ti.com>
Download mbox | patch
Permalink /patch/229402/
State Accepted
Delegated to: Tom Rini
Headers show

Comments

Tom Rini - March 20, 2013, 2:21 p.m.
The ext4write command was taking the in-memory address and filename path
in reverse order from the rest of the filesystem read and write
commands.  This corrects the order to be the same as fatload, etc.

Signed-off-by: Tom Rini <trini@ti.com>
---
 common/cmd_ext4.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Tom Rini - March 27, 2013, 6:48 p.m.
On Wed, Mar 20, 2013 at 04:21:38AM -0000, Tom Rini wrote:

> The ext4write command was taking the in-memory address and filename path
> in reverse order from the rest of the filesystem read and write
> commands.  This corrects the order to be the same as fatload, etc.
> 
> Signed-off-by: Tom Rini <trini@ti.com>

Applied to u-boot/master, thanks!

Patch

diff --git a/common/cmd_ext4.c b/common/cmd_ext4.c
index dcf76a5..706fd54 100644
--- a/common/cmd_ext4.c
+++ b/common/cmd_ext4.c
@@ -88,10 +88,10 @@  int do_ext4_write(cmd_tbl_t *cmdtp, int flag, int argc,
 	dev = dev_desc->dev;
 
 	/* get the filename */
-	filename = argv[3];
+	filename = argv[4];
 
 	/* get the address in hexadecimal format (string to int) */
-	ram_address = simple_strtoul(argv[4], NULL, 16);
+	ram_address = simple_strtoul(argv[3], NULL, 16);
 
 	/* get the filesize in base 10 format */
 	file_size = simple_strtoul(argv[5], NULL, 10);
@@ -122,7 +122,7 @@  fail:
 
 U_BOOT_CMD(ext4write, 6, 1, do_ext4_write,
 	"create a file in the root directory",
-	"<interface> <dev[:part]> [Absolute filename path] [Address] [sizebytes]\n"
+	"<interface> <dev[:part]> <addr> <absolute filename path> [sizebytes]\n"
 	"    - create a file in / directory");
 
 #endif