From patchwork Wed Mar 20 12:14:53 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 229369 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id B84082C008D for ; Wed, 20 Mar 2013 23:15:02 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758004Ab3CTMO5 (ORCPT ); Wed, 20 Mar 2013 08:14:57 -0400 Received: from mail-bk0-f51.google.com ([209.85.214.51]:52746 "EHLO mail-bk0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756226Ab3CTMOz (ORCPT ); Wed, 20 Mar 2013 08:14:55 -0400 Received: by mail-bk0-f51.google.com with SMTP id ik5so806887bkc.38 for ; Wed, 20 Mar 2013 05:14:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:date:message-id:subject:from:to:cc :content-type; bh=JIb4b0r7gl9GyxmxB+fgyKAT3ERyG2bIOE+67prxWHY=; b=WNL6rEhNqMaKdDm2qd/8dG7+RgsmJ2TXLhv3Xyi7FXAqkmXsBnETXW1KMwJPAixeWW 0zKuHy8+lJSKIHRSGnZ5038Cvjj6cLOnpWwDesPwYXkVTBEfC2rJgjMt7HMaGWMJVG13 +FRj9kn8enR0L/j5JyQds47n6eeeDlPabHEFUxm5fbgQZxXNwDLPtyal/4XD5ypzaqqk IibxTOZYmn5v84nPud/jxFccv3lEiXc1QGYoa4nbF/9OoYLhYEivIhdqU4tlXLW8U5Vb Rgs4jWgDm54LjTMuUwUyAHLPemFoEEQOz/5BAdvALBOf1TPHDMZVR864sq4w+EWCkvTu 7g7w== MIME-Version: 1.0 X-Received: by 10.205.33.3 with SMTP id sm3mr10759471bkb.64.1363781693872; Wed, 20 Mar 2013 05:14:53 -0700 (PDT) Received: by 10.204.30.210 with HTTP; Wed, 20 Mar 2013 05:14:53 -0700 (PDT) Date: Wed, 20 Mar 2013 20:14:53 +0800 Message-ID: Subject: [PATCH -next] openvswitch: fix error return code in ovs_vport_cmd_set() From: Wei Yongjun To: jesse@nicira.com, davem@davemloft.net Cc: yongjun_wei@trendmicro.com.cn, dev@openvswitch.org, netdev@vger.kernel.org Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Wei Yongjun Fix to return a negative error code from the error handling case instead of 0, as returned elsewhere in this function. Signed-off-by: Wei Yongjun --- net/openvswitch/datapath.c | 1 + 1 file changed, 1 insertion(+) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c index d61cd99..1ee11c3 100644 --- a/net/openvswitch/datapath.c +++ b/net/openvswitch/datapath.c @@ -1736,6 +1736,7 @@ static int ovs_vport_cmd_set(struct sk_buff *skb, struct genl_info *info) reply = ovs_vport_cmd_build_info(vport, info->snd_portid, info->snd_seq, OVS_VPORT_CMD_NEW); + err = PTR_ERR(reply); if (IS_ERR(reply)) { netlink_set_err(sock_net(skb->sk)->genl_sock, 0, ovs_dp_vport_multicast_group.id, PTR_ERR(reply));