Patchwork [v2] mfd: remove twelve unused Kconfig symbols

login
register
mail settings
Submitter Paul Bolle
Date March 20, 2013, 9:09 a.m.
Message ID <1363770579.1390.82.camel@x61.thuisdomein>
Download mbox | patch
Permalink /patch/229275/
State New
Headers show

Comments

Paul Bolle - March 20, 2013, 9:09 a.m.
Twelve Kconfig symbols, all related to WM8350, WM8351, and WM8352, are
unused. Commit 19d57ed5a308472a02e773f33c03ad4cb2ec6a9 ("mfd: Remove
custom wm8350 cache implementation") removed all their (actual) users.
Remove these symbols too.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
0) This version adds Mark's ACK. It is now also sent to the ARM
maintainers, as Mark suggested.

1) Still only eyeball tested.

 arch/arm/mach-imx/Kconfig     |  2 --
 arch/arm/mach-s3c64xx/Kconfig |  3 ---
 drivers/mfd/Kconfig           | 48 -------------------------------------------
 3 files changed, 53 deletions(-)
Kukjin Kim - March 25, 2013, 1:08 a.m.
Paul Bolle wrote:
> 
> Twelve Kconfig symbols, all related to WM8350, WM8351, and WM8352, are
> unused. Commit 19d57ed5a308472a02e773f33c03ad4cb2ec6a9 ("mfd: Remove
> custom wm8350 cache implementation") removed all their (actual) users.
> Remove these symbols too.
> 
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

Acked-by: Kukjin Kim <kgene.kim@samsung.com>

Thanks.

- Kukjin

> ---
> 0) This version adds Mark's ACK. It is now also sent to the ARM
> maintainers, as Mark suggested.
> 
> 1) Still only eyeball tested.
> 
>  arch/arm/mach-imx/Kconfig     |  2 --
>  arch/arm/mach-s3c64xx/Kconfig |  3 ---
>  drivers/mfd/Kconfig           | 48 -----------------------------------------
> --
>  3 files changed, 53 deletions(-)
> 
> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> index 4c9c6f9..6d9ae09 100644
> --- a/arch/arm/mach-imx/Kconfig
> +++ b/arch/arm/mach-imx/Kconfig
> @@ -481,8 +481,6 @@ config MACH_MX31ADS_WM1133_EV1
>  	depends on MACH_MX31ADS
>  	depends on MFD_WM8350_I2C
>  	depends on REGULATOR_WM8350 = y
> -	select MFD_WM8350_CONFIG_MODE_0
> -	select MFD_WM8352_CONFIG_MODE_0
>  	help
>  	  Include support for the Wolfson Microelectronics 1133-EV1 PMU
>  	  and audio module for the MX31ADS platform.
> diff --git a/arch/arm/mach-s3c64xx/Kconfig b/arch/arm/mach-s3c64xx/Kconfig
> index 131c862..041da51 100644
> --- a/arch/arm/mach-s3c64xx/Kconfig
> +++ b/arch/arm/mach-s3c64xx/Kconfig
> @@ -198,10 +198,7 @@ endchoice
>  config SMDK6410_WM1190_EV1
>  	bool "Support Wolfson Microelectronics 1190-EV1 PMIC card"
>  	depends on MACH_SMDK6410
> -	select MFD_WM8350_CONFIG_MODE_0
> -	select MFD_WM8350_CONFIG_MODE_3
>  	select MFD_WM8350_I2C
> -	select MFD_WM8352_CONFIG_MODE_0
>  	select REGULATOR
>  	select REGULATOR_WM8350
>  	select SAMSUNG_GPIO_EXTRA64
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index c346941..ebb1bed 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -687,54 +687,6 @@ config MFD_WM8350
>  	bool
>  	depends on GENERIC_HARDIRQS
> 
> -config MFD_WM8350_CONFIG_MODE_0
> -	bool
> -	depends on MFD_WM8350
> -
> -config MFD_WM8350_CONFIG_MODE_1
> -	bool
> -	depends on MFD_WM8350
> -
> -config MFD_WM8350_CONFIG_MODE_2
> -	bool
> -	depends on MFD_WM8350
> -
> -config MFD_WM8350_CONFIG_MODE_3
> -	bool
> -	depends on MFD_WM8350
> -
> -config MFD_WM8351_CONFIG_MODE_0
> -	bool
> -	depends on MFD_WM8350
> -
> -config MFD_WM8351_CONFIG_MODE_1
> -	bool
> -	depends on MFD_WM8350
> -
> -config MFD_WM8351_CONFIG_MODE_2
> -	bool
> -	depends on MFD_WM8350
> -
> -config MFD_WM8351_CONFIG_MODE_3
> -	bool
> -	depends on MFD_WM8350
> -
> -config MFD_WM8352_CONFIG_MODE_0
> -	bool
> -	depends on MFD_WM8350
> -
> -config MFD_WM8352_CONFIG_MODE_1
> -	bool
> -	depends on MFD_WM8350
> -
> -config MFD_WM8352_CONFIG_MODE_2
> -	bool
> -	depends on MFD_WM8350
> -
> -config MFD_WM8352_CONFIG_MODE_3
> -	bool
> -	depends on MFD_WM8350
> -
>  config MFD_WM8350_I2C
>  	bool "Support Wolfson Microelectronics WM8350 with I2C"
>  	select MFD_WM8350
> --
> 1.7.11.7
Samuel Ortiz - April 9, 2013, 8:14 a.m.
Hi Paul,

On Wed, Mar 20, 2013 at 10:09:39AM +0100, Paul Bolle wrote:
> Twelve Kconfig symbols, all related to WM8350, WM8351, and WM8352, are
> unused. Commit 19d57ed5a308472a02e773f33c03ad4cb2ec6a9 ("mfd: Remove
> custom wm8350 cache implementation") removed all their (actual) users.
> Remove these symbols too.
> 
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> 0) This version adds Mark's ACK. It is now also sent to the ARM
> maintainers, as Mark suggested.
> 
> 1) Still only eyeball tested.
> 
>  arch/arm/mach-imx/Kconfig     |  2 --
>  arch/arm/mach-s3c64xx/Kconfig |  3 ---
>  drivers/mfd/Kconfig           | 48 -------------------------------------------
>  3 files changed, 53 deletions(-)
Applied to my mfd-next tree, thanks.

Cheers,
Samuel.

Patch

diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
index 4c9c6f9..6d9ae09 100644
--- a/arch/arm/mach-imx/Kconfig
+++ b/arch/arm/mach-imx/Kconfig
@@ -481,8 +481,6 @@  config MACH_MX31ADS_WM1133_EV1
 	depends on MACH_MX31ADS
 	depends on MFD_WM8350_I2C
 	depends on REGULATOR_WM8350 = y
-	select MFD_WM8350_CONFIG_MODE_0
-	select MFD_WM8352_CONFIG_MODE_0
 	help
 	  Include support for the Wolfson Microelectronics 1133-EV1 PMU
 	  and audio module for the MX31ADS platform.
diff --git a/arch/arm/mach-s3c64xx/Kconfig b/arch/arm/mach-s3c64xx/Kconfig
index 131c862..041da51 100644
--- a/arch/arm/mach-s3c64xx/Kconfig
+++ b/arch/arm/mach-s3c64xx/Kconfig
@@ -198,10 +198,7 @@  endchoice
 config SMDK6410_WM1190_EV1
 	bool "Support Wolfson Microelectronics 1190-EV1 PMIC card"
 	depends on MACH_SMDK6410
-	select MFD_WM8350_CONFIG_MODE_0
-	select MFD_WM8350_CONFIG_MODE_3
 	select MFD_WM8350_I2C
-	select MFD_WM8352_CONFIG_MODE_0
 	select REGULATOR
 	select REGULATOR_WM8350
 	select SAMSUNG_GPIO_EXTRA64
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index c346941..ebb1bed 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -687,54 +687,6 @@  config MFD_WM8350
 	bool
 	depends on GENERIC_HARDIRQS
 
-config MFD_WM8350_CONFIG_MODE_0
-	bool
-	depends on MFD_WM8350
-
-config MFD_WM8350_CONFIG_MODE_1
-	bool
-	depends on MFD_WM8350
-
-config MFD_WM8350_CONFIG_MODE_2
-	bool
-	depends on MFD_WM8350
-
-config MFD_WM8350_CONFIG_MODE_3
-	bool
-	depends on MFD_WM8350
-
-config MFD_WM8351_CONFIG_MODE_0
-	bool
-	depends on MFD_WM8350
-
-config MFD_WM8351_CONFIG_MODE_1
-	bool
-	depends on MFD_WM8350
-
-config MFD_WM8351_CONFIG_MODE_2
-	bool
-	depends on MFD_WM8350
-
-config MFD_WM8351_CONFIG_MODE_3
-	bool
-	depends on MFD_WM8350
-
-config MFD_WM8352_CONFIG_MODE_0
-	bool
-	depends on MFD_WM8350
-
-config MFD_WM8352_CONFIG_MODE_1
-	bool
-	depends on MFD_WM8350
-
-config MFD_WM8352_CONFIG_MODE_2
-	bool
-	depends on MFD_WM8350
-
-config MFD_WM8352_CONFIG_MODE_3
-	bool
-	depends on MFD_WM8350
-
 config MFD_WM8350_I2C
 	bool "Support Wolfson Microelectronics WM8350 with I2C"
 	select MFD_WM8350