| Submitter | Chen Gang |
|---|---|
| Date | March 20, 2013, 6:30 a.m. |
| Message ID | <51495774.9080809@asianux.com> |
| Download | mbox | patch |
| Permalink | /patch/229254/ |
| State | New |
| Headers | show |
Comments
Hello Maintainers: could you help check this patch whether is ok ? thanks. On 2013年03月20日 14:30, Chen Gang wrote: > > the smp_release_cpus is a normal funciton and called in normal environments, > but it calls the __initdata spinning_secondaries. > need modify spinning_secondaries to match smp_release_cpus. > > the related warning: > (the linker report boot_paca.33377, but it should be spinning_secondaries) > > ----------------------------------------------------------------------------- > > WARNING: arch/powerpc/kernel/built-in.o(.text+0x23176): Section mismatch in reference from the function .smp_release_cpus() to the variable .init.data:boot_paca.33377 > The function .smp_release_cpus() references > the variable __initdata boot_paca.33377. > This is often because .smp_release_cpus lacks a __initdata > annotation or the annotation of boot_paca.33377 is wrong. > > WARNING: arch/powerpc/kernel/built-in.o(.text+0x231fe): Section mismatch in reference from the function .smp_release_cpus() to the variable .init.data:boot_paca.33377 > The function .smp_release_cpus() references > the variable __initdata boot_paca.33377. > This is often because .smp_release_cpus lacks a __initdata > annotation or the annotation of boot_paca.33377 is wrong. > > ----------------------------------------------------------------------------- > > > > Signed-off-by: Chen Gang <gang.chen@asianux.com> > --- > arch/powerpc/kernel/setup_64.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c > index 75fbaceb..e8a2f2e 100644 > --- a/arch/powerpc/kernel/setup_64.c > +++ b/arch/powerpc/kernel/setup_64.c > @@ -76,7 +76,7 @@ > #endif > > int boot_cpuid = 0; > -int __initdata spinning_secondaries; > +int spinning_secondaries; > u64 ppc64_pft_size; > > /* Pick defaults since we might want to patch instructions >
Patch
diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c index 75fbaceb..e8a2f2e 100644 --- a/arch/powerpc/kernel/setup_64.c +++ b/arch/powerpc/kernel/setup_64.c @@ -76,7 +76,7 @@ #endif int boot_cpuid = 0; -int __initdata spinning_secondaries; +int spinning_secondaries; u64 ppc64_pft_size; /* Pick defaults since we might want to patch instructions
the smp_release_cpus is a normal funciton and called in normal environments, but it calls the __initdata spinning_secondaries. need modify spinning_secondaries to match smp_release_cpus. the related warning: (the linker report boot_paca.33377, but it should be spinning_secondaries) ----------------------------------------------------------------------------- WARNING: arch/powerpc/kernel/built-in.o(.text+0x23176): Section mismatch in reference from the function .smp_release_cpus() to the variable .init.data:boot_paca.33377 The function .smp_release_cpus() references the variable __initdata boot_paca.33377. This is often because .smp_release_cpus lacks a __initdata annotation or the annotation of boot_paca.33377 is wrong. WARNING: arch/powerpc/kernel/built-in.o(.text+0x231fe): Section mismatch in reference from the function .smp_release_cpus() to the variable .init.data:boot_paca.33377 The function .smp_release_cpus() references the variable __initdata boot_paca.33377. This is often because .smp_release_cpus lacks a __initdata annotation or the annotation of boot_paca.33377 is wrong. ----------------------------------------------------------------------------- Signed-off-by: Chen Gang <gang.chen@asianux.com> --- arch/powerpc/kernel/setup_64.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)