| Message ID | 1363753355-27054-1-git-send-email-gilles.talis@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
On 03/20/2013 01:22 AM, Gilles Talis wrote: > quota configuration explicitly selects util-linux mount package, > but mount requires libmount to build. > > Explicitly select libmount to fix this. But it's not the proper fix realy, see line 92 of util-linux.mk - it won't build ANY util-linux binary unless BR2_PACKAGE_UTIL_LINUX_BINARIES is set, hence it may pass in the autobuilders but you'll never get util-linux mount (and quota will cry when used). The proper fix is the one i've sent before. Regards.
Hi Gustavo, 2013/3/20 Gustavo Zacarias <gustavo@zacarias.com.ar>: > On 03/20/2013 01:22 AM, Gilles Talis wrote: > >> quota configuration explicitly selects util-linux mount package, >> but mount requires libmount to build. >> >> Explicitly select libmount to fix this. > > But it's not the proper fix realy, see line 92 of util-linux.mk - it > won't build ANY util-linux binary unless BR2_PACKAGE_UTIL_LINUX_BINARIES > is set, hence it may pass in the autobuilders but you'll never get > util-linux mount (and quota will cry when used). > The proper fix is the one i've sent before. I simply just missed the patch you have sent earlier on this issue. All apologies. Thanks for pointing out. regards Gilles.
diff --git a/package/quota/Config.in b/package/quota/Config.in index f6341d3..25614f8 100644 --- a/package/quota/Config.in +++ b/package/quota/Config.in @@ -3,8 +3,11 @@ config BR2_PACKAGE_QUOTA depends on BR2_LARGEFILE depends on BR2_USE_WCHAR depends on BR2_USE_MMU # fork() + # libc lacks UTIME_NOW & UTIME_COMMIT for libmount + depends on !(BR2_microblazeel || BR2_microblazebe) select BR2_PACKAGE_UTIL_LINUX select BR2_PACKAGE_UTIL_LINUX_MOUNT + select BR2_PACKAGE_UTIL_LINUX_LIBMOUNT select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE select BR2_PACKAGE_LIBTIRPC if !BR2_TOOLCHAIN_HAS_NATIVE_RPC help
quota configuration explicitly selects util-linux mount package, but mount requires libmount to build. Explicitly select libmount to fix this. Fixes autobuild errors like: http://autobuild.buildroot.org/results/2d2f37c292178f746a9a397146719e94f18c022b Signed-off-by: Gilles Talis <gilles.talis@gmail.com> --- package/quota/Config.in | 3 +++ 1 file changed, 3 insertions(+)