| Message ID | 1363693648-10015-3-git-send-email-yamato@redhat.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Masatake YAMATO <yamato@redhat.com> Date: Tue, 19 Mar 2013 20:47:28 +0900 > The original name is too long. > > Signed-off-by: Masatake YAMATO <yamato@redhat.com> This change needs to go in via the Thermal driver maintainers. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> From: Masatake YAMATO <yamato@redhat.com> > Date: Tue, 19 Mar 2013 20:47:28 +0900 > >> The original name is too long. >> >> Signed-off-by: Masatake YAMATO <yamato@redhat.com> > > This change needs to go in via the Thermal driver maintainers. Thanks. I've submitted the patch to linux-acpi ML. Masatake YAMATO -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 03/19/13 at 08:47pm, Masatake YAMATO wrote: > The original name is too long. > > Signed-off-by: Masatake YAMATO <yamato@redhat.com> > --- > include/linux/thermal.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/thermal.h b/include/linux/thermal.h > index f0bd7f9..e3c0ae9 100644 > --- a/include/linux/thermal.h > +++ b/include/linux/thermal.h > @@ -44,7 +44,7 @@ > /* Adding event notification support elements */ > #define THERMAL_GENL_FAMILY_NAME "thermal_event" > #define THERMAL_GENL_VERSION 0x01 > -#define THERMAL_GENL_MCAST_GROUP_NAME "thermal_mc_group" > +#define THERMAL_GENL_MCAST_GROUP_NAME "thermal_mc_grp" Just saying that this would not be OK in general as this would break any application looking up the multicast group id by name via genetlink but since it's broken anyway right now it's OK I guess. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Masatake YAMATO <yamato@redhat.com> Date: Thu, 21 Mar 2013 16:46:23 +0900 (JST) >> From: Masatake YAMATO <yamato@redhat.com> >> Date: Tue, 19 Mar 2013 20:47:28 +0900 >> >>> The original name is too long. >>> >>> Signed-off-by: Masatake YAMATO <yamato@redhat.com> >> >> This change needs to go in via the Thermal driver maintainers. > > Thanks. I've submitted the patch to linux-acpi ML. I already applied the patch to my tree, didn't you read the rest of this thread? And in the future, order your patches such that you fix the bug before adding the assertion. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Sorry for cross posting to netdev and linux-acpi. I submitted almost same patch about thermal subsystem both netdev list and then linux-acpi list. http://marc.info/?l=linux-netdev&m=136371412725264&w=2 http://marc.info/?l=linux-acpi&m=136386050309109&w=2 After submitting to linux-acpi list, I noticed the patch is merged to a tree davem maintained. What I should do? The submitted pathes are bit different. In netdev, I proposed changing "thermal_mc_group" to "thermal_mc_grp". In linux-acpi I proposed changing "thermal_mc_group" to "thermal_mc_grou". "thermal_mc_grp" is easier to read. However, when thinking about compatibility, "thermal_mc_grou" is better. I've already submitted another patch for genl command which truncates the C string returned from kernel. http://marc.info/?l=linux-netdev&m=136371412625262&w=2 Consider a situation(A); using old kernel(without my patch submitted for linux-acpi) and new genl command (with my patch for genl). You will get thermal_mc_grou as output. Consider anther situation(B); using new kernel(with my patch submitted for linux-acpi) and old genl command (without my patch for genl). You will get thermal_mc_grou as output. In both situations(A and B) users can get the same output. If you choose "thermal_mc_grp", users may see "thermal_mc_grp" or "thermal_mc_grou". >>> From: Masatake YAMATO <yamato@redhat.com> >>> Date: Tue, 19 Mar 2013 20:47:28 +0900 >>> >>>> The original name is too long. >>>> >>>> Signed-off-by: Masatake YAMATO <yamato@redhat.com> >>> >>> This change needs to go in via the Thermal driver maintainers. >> >> Thanks. I've submitted the patch to linux-acpi ML. > > I already applied the patch to my tree, didn't you read > the rest of this thread? I read but I didn't understand the meaning of applying because I cannot find my 2nd patch for thermal in net-next tree when I pulled. What I should do? Should I withdraw the patch submitted to linux-acpi? However, I slight modified the patch when I submitted it to linux-acpi. > And in the future, order your patches such that you fix the bug before > adding the assertion. Sorry. I'll do so next time. Masatake YAMATO -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Masatake YAMATO <yamato@redhat.com> Date: Fri, 22 Mar 2013 12:43:06 +0900 (JST) > I read but I didn't understand the meaning of applying because > I cannot find my 2nd patch for thermal in net-next tree when I > pulled. These are bug fixes, so they appear in the 'net' tree not 'net-next'. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/linux/thermal.h b/include/linux/thermal.h index f0bd7f9..e3c0ae9 100644 --- a/include/linux/thermal.h +++ b/include/linux/thermal.h @@ -44,7 +44,7 @@ /* Adding event notification support elements */ #define THERMAL_GENL_FAMILY_NAME "thermal_event" #define THERMAL_GENL_VERSION 0x01 -#define THERMAL_GENL_MCAST_GROUP_NAME "thermal_mc_group" +#define THERMAL_GENL_MCAST_GROUP_NAME "thermal_mc_grp" /* Default Thermal Governor */ #if defined(CONFIG_THERMAL_DEFAULT_GOV_STEP_WISE)
The original name is too long. Signed-off-by: Masatake YAMATO <yamato@redhat.com> --- include/linux/thermal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)