From patchwork Wed Feb 11 12:18:52 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Risto Suominen X-Patchwork-Id: 22913 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 13783DDDAA for ; Wed, 11 Feb 2009 23:19:01 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755087AbZBKMSz (ORCPT ); Wed, 11 Feb 2009 07:18:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751555AbZBKMSz (ORCPT ); Wed, 11 Feb 2009 07:18:55 -0500 Received: from mail-fx0-f20.google.com ([209.85.220.20]:43593 "EHLO mail-fx0-f20.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751873AbZBKMSy (ORCPT ); Wed, 11 Feb 2009 07:18:54 -0500 Received: by fxm13 with SMTP id 13so421377fxm.13 for ; Wed, 11 Feb 2009 04:18:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=qPl36UEg+hUsJbidYcihGGo2uYNKaLVM2URczQndrtM=; b=q3Al1YRLSv/YgVk6e3ogctJgQVH8rsjdiQdLHBEo64CZV9CQNl50/I8sEF8asitwNq bcWbz4SOieg8/ybnjN7i6e28saOapJ3UzXB77zuhD7aa782aLNK2s1clIdzYyzBLWmSG pLMBfb/NFb4Jo6fC3rM41NpRTEKvdiK5l1uwE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=oXJAYU+lC+TcIyAV+vDnyjySjUbSUIK+e7KhALcuizLH5IqRi0oQX/lxMOwOu0Rmkt nxoIwDzjpgol/UdDv0QhjCgZvRnChKWWwSjGquc0ADM34gwLzKXY5qNrMshHBvarkMv2 HOjtff4b02QCDjkCgOigtbc3vRkgc0SW0O6rM= MIME-Version: 1.0 Received: by 10.180.250.7 with SMTP id x7mr312221bkh.175.1234354732100; Wed, 11 Feb 2009 04:18:52 -0800 (PST) In-Reply-To: <20090210.152143.176850113.davem@davemloft.net> References: <46e1c7760902090022g1d903ca0nf314f0c1cc6b07c8@mail.gmail.com> <46e1c7760902091122m6ec7fbb5nefd9cc9789880c0f@mail.gmail.com> <20090210.152143.176850113.davem@davemloft.net> Date: Wed, 11 Feb 2009 14:18:52 +0200 Message-ID: <46e1c7760902110418n276de9b2xa2169839b9e25dc0@mail.gmail.com> Subject: Re: [PATCH 002/002] de2104x: support for systems lacking cache coherence From: Risto Suominen To: David Miller Cc: khc@pm.waw.pl, netdev@vger.kernel.org Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org 2009/2/11 David Miller : > > I think the pci_alloc_consistent() implementation for your particular > platform should be fixed instead :-) > Looks like it works as expected with 2.6.24. This patch is all that is needed. Still I think that my first solution was beautiful in its simplicity :) (and usable with older kernels) Risto Allow setting NOT_COHERENT_CACHE explicitly. Signed-off-by: Risto Suominen --- The testing is done on kernel version 2.6.24. --- a/arch/powerpc/platforms/powermac/Kconfig.org 2008-01-25 00:58:37.000000000 +0200 +++ b/arch/powerpc/platforms/powermac/Kconfig 2009-02-10 17:44:24.000000000 +0200 @@ -18,4 +18,10 @@ config PPC_PMAC64 select PPC_970_NAP default y - +config NOT_COHERENT_CACHE + bool "Incoherent cache" + default n + help + Setting this option may be necessary for avoiding cache-related + problems with some network cards on some platforms. An example is + 2104x and PowerMac 5500. Allow setting NOT_COHERENT_CACHE explicitly. Signed-off-by: Risto Suominen --- The testing is done on kernel version 2.6.24. --- a/arch/powerpc/platforms/powermac/Kconfig.org 2008-01-25 00:58:37.000000000 +0200 +++ b/arch/powerpc/platforms/powermac/Kconfig 2009-02-10 17:44:24.000000000 +0200 @@ -18,4 +18,10 @@ config PPC_PMAC64 select PPC_970_NAP default y - +config NOT_COHERENT_CACHE + bool "Incoherent cache" + default n + help + Setting this option may be necessary for avoiding cache-related + problems with some network cards on some platforms. An example is + 2104x and PowerMac 5500.