From patchwork Wed Feb 11 10:49:30 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: roel kluin X-Patchwork-Id: 22912 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 17ABDDDDAE for ; Wed, 11 Feb 2009 21:50:00 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755077AbZBKKta (ORCPT ); Wed, 11 Feb 2009 05:49:30 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754959AbZBKKt3 (ORCPT ); Wed, 11 Feb 2009 05:49:29 -0500 Received: from fk-out-0910.google.com ([209.85.128.191]:11118 "EHLO fk-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754943AbZBKKt2 (ORCPT ); Wed, 11 Feb 2009 05:49:28 -0500 Received: by fk-out-0910.google.com with SMTP id f33so52958fkf.5 for ; Wed, 11 Feb 2009 02:49:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:cc:subject:content-type :content-transfer-encoding; bh=Cm1xq8QqhugFr32tZkbKPvXtKkq0WM9Pt2Pz2v6fpJ0=; b=o5NLODiF6FbZHJNDlg9etU9CenzL+QyR9mlNljg3CBH2SrqFsjdNsMTLFvbbxsFSrZ LIBWLMRcgLyBU9EIx0vmpJfYZDZUAgKsRKWgspY6Hh0P5GA3QZ9/xSSZsHu1mD0wXR2X P7yYrQzWQfPSjY5IYWRL/EFCzukiMNqD6LgeQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :content-type:content-transfer-encoding; b=vXblk2SILnQLvTsuJmA5YxtEtsvIDenobZcH7AfNutBOhcpoYLklBjRIark7X566qi +GNrT5IYTsTkf17oc1pTUZACBRZXUAz8fXvIC1w4vbBQvSjnNRKlGwarbXEBDkHhbq7U KmxGWgopcB1GpFsjGiDmX6mHoKbEOep/+KGIk= Received: by 10.223.112.201 with SMTP id x9mr1290566fap.69.1234349366739; Wed, 11 Feb 2009 02:49:26 -0800 (PST) Received: from ?192.168.1.115? (d133062.upc-d.chello.nl [213.46.133.62]) by mx.google.com with ESMTPS id i4sm964761nfh.59.2009.02.11.02.49.26 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 11 Feb 2009 02:49:26 -0800 (PST) Message-ID: <4992AD3A.7000301@gmail.com> Date: Wed, 11 Feb 2009 11:49:30 +0100 From: Roel Kluin User-Agent: Thunderbird 2.0.0.18 (X11/20081105) MIME-Version: 1.0 To: mchan@broadcom.com CC: netdev@vger.kernel.org, Andrew Morton Subject: [PATCH] TG3: limit reaches -1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org With while (limit--) { ... } limit reaches -1, so 0 means success. Signed-off-by: Roel Kluin Acked-by: Michael Chan --- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 8b3f846..4595962 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c @@ -852,7 +852,7 @@ static int tg3_bmcr_reset(struct tg3 *tp) } udelay(10); } - if (limit <= 0) + if (limit < 0) return -EBUSY; return 0; @@ -1603,7 +1603,7 @@ static int tg3_wait_macro_done(struct tg3 *tp) break; } } - if (limit <= 0) + if (limit < 0) return -EBUSY; return 0;