Patchwork sparc: remove unused "config BITS"

login
register
mail settings
Submitter Paul Bolle
Date March 19, 2013, 3:58 p.m.
Message ID <1363708727.1390.16.camel@x61.thuisdomein>
Download mbox | patch
Permalink /patch/229100/
State Accepted
Delegated to: David Miller
Headers show

Comments

Paul Bolle - March 19, 2013, 3:58 p.m.
sparc's asm/module.h got removed in commit
786d35d45cc40b2a51a18f73e14e135d47fdced7 ("Make most arch asm/module.h
files use asm-generic/module.h"). That removed the only two uses of this
Kconfig symbol. So we can remove its entry too.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
Eyeball tested.

 arch/sparc/Kconfig | 6 ------
 1 file changed, 6 deletions(-)
David Miller - March 19, 2013, 4:33 p.m.
From: Paul Bolle <pebolle@tiscali.nl>
Date: Tue, 19 Mar 2013 16:58:47 +0100

> sparc's asm/module.h got removed in commit
> 786d35d45cc40b2a51a18f73e14e135d47fdced7 ("Make most arch asm/module.h
> files use asm-generic/module.h"). That removed the only two uses of this
> Kconfig symbol. So we can remove its entry too.
> 
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> Eyeball tested.

We use this in the Makefile fragments, you cannot remove it.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Paul Bolle - March 19, 2013, 5:06 p.m.
On Tue, 2013-03-19 at 12:33 -0400, David Miller wrote:
> We use this in the Makefile fragments, you cannot remove it.

From arch/sparc/Makefile:
    ifeq ($(CONFIG_SPARC32),y)
    [...]

    [...]
    export BITS    := 32
    [...]

    else
    [...]

    [...]
    export BITS   := 64
    [...]

So $(BITS) is set depending on whether CONFIG_SPARC32 is set or not.
Using $(BITS) in sparc's Makefiles is not using CONFIG_BITS. That
doesn't count as usage of "config BITS". 


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sam Ravnborg - March 19, 2013, 8:14 p.m.
On Tue, Mar 19, 2013 at 06:06:47PM +0100, Paul Bolle wrote:
> On Tue, 2013-03-19 at 12:33 -0400, David Miller wrote:
> > We use this in the Makefile fragments, you cannot remove it.
> 
> >From arch/sparc/Makefile:
>     ifeq ($(CONFIG_SPARC32),y)
>     [...]
> 
>     [...]
>     export BITS    := 32
>     [...]
> 
>     else
>     [...]
> 
>     [...]
>     export BITS   := 64
>     [...]
> 
> So $(BITS) is set depending on whether CONFIG_SPARC32 is set or not.
> Using $(BITS) in sparc's Makefiles is not using CONFIG_BITS. That
> doesn't count as usage of "config BITS". 
Just double checked - you are right.
Maybe send a v2 with this info in changelog and add my:

Acked-by: Sam Ravnborg <sam@ravnborg.org>

	Sam
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - March 19, 2013, 8:21 p.m.
From: Paul Bolle <pebolle@tiscali.nl>
Date: Tue, 19 Mar 2013 18:06:47 +0100

> On Tue, 2013-03-19 at 12:33 -0400, David Miller wrote:
>> We use this in the Makefile fragments, you cannot remove it.
> 
> From arch/sparc/Makefile:
>     ifeq ($(CONFIG_SPARC32),y)
>     [...]
> 
>     [...]
>     export BITS    := 32
>     [...]
> 
>     else
>     [...]
> 
>     [...]
>     export BITS   := 64
>     [...]
> 
> So $(BITS) is set depending on whether CONFIG_SPARC32 is set or not.
> Using $(BITS) in sparc's Makefiles is not using CONFIG_BITS. That
> doesn't count as usage of "config BITS". 

Ok, I'm convinced now :-)  Applied, thanks!
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - March 19, 2013, 8:23 p.m.
From: Sam Ravnborg <sam@ravnborg.org>
Date: Tue, 19 Mar 2013 21:14:54 +0100

> On Tue, Mar 19, 2013 at 06:06:47PM +0100, Paul Bolle wrote:
>> On Tue, 2013-03-19 at 12:33 -0400, David Miller wrote:
>> > We use this in the Makefile fragments, you cannot remove it.
>> 
>> >From arch/sparc/Makefile:
>>     ifeq ($(CONFIG_SPARC32),y)
>>     [...]
>> 
>>     [...]
>>     export BITS    := 32
>>     [...]
>> 
>>     else
>>     [...]
>> 
>>     [...]
>>     export BITS   := 64
>>     [...]
>> 
>> So $(BITS) is set depending on whether CONFIG_SPARC32 is set or not.
>> Using $(BITS) in sparc's Makefiles is not using CONFIG_BITS. That
>> doesn't count as usage of "config BITS". 
> Just double checked - you are right.
> Maybe send a v2 with this info in changelog and add my:
> 
> Acked-by: Sam Ravnborg <sam@ravnborg.org>

No need, I'll fix up the commit message.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Paul Bolle - March 19, 2013, 8:26 p.m.
On Tue, 2013-03-19 at 21:14 +0100, Sam Ravnborg wrote:
> On Tue, Mar 19, 2013 at 06:06:47PM +0100, Paul Bolle wrote:
> > So $(BITS) is set depending on whether CONFIG_SPARC32 is set or not.
> > Using $(BITS) in sparc's Makefiles is not using CONFIG_BITS. That
> > doesn't count as usage of "config BITS". 
> Just double checked - you are right.

Thanks.

> Maybe send a v2 with this info in changelog and add my:
> 
> Acked-by: Sam Ravnborg <sam@ravnborg.org>

David: should I send a second version with a line or two on the
(non-related) use of BITS in the Makefiles and Sam's ACK?


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - March 19, 2013, 8:30 p.m.
From: Paul Bolle <pebolle@tiscali.nl>
Date: Tue, 19 Mar 2013 21:26:08 +0100

> On Tue, 2013-03-19 at 21:14 +0100, Sam Ravnborg wrote:
>> On Tue, Mar 19, 2013 at 06:06:47PM +0100, Paul Bolle wrote:
>> > So $(BITS) is set depending on whether CONFIG_SPARC32 is set or not.
>> > Using $(BITS) in sparc's Makefiles is not using CONFIG_BITS. That
>> > doesn't count as usage of "config BITS". 
>> Just double checked - you are right.
> 
> Thanks.
> 
>> Maybe send a v2 with this info in changelog and add my:
>> 
>> Acked-by: Sam Ravnborg <sam@ravnborg.org>
> 
> David: should I send a second version with a line or two on the
> (non-related) use of BITS in the Makefiles and Sam's ACK?

Like I replied to Sam, no need, I took care of this.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/arch/sparc/Kconfig b/arch/sparc/Kconfig
index 289127d..991abb2 100644
--- a/arch/sparc/Kconfig
+++ b/arch/sparc/Kconfig
@@ -84,12 +84,6 @@  config ARCH_DEFCONFIG
 	default "arch/sparc/configs/sparc32_defconfig" if SPARC32
 	default "arch/sparc/configs/sparc64_defconfig" if SPARC64
 
-# CONFIG_BITS can be used at source level to get 32/64 bits
-config BITS
-	int
-	default 32 if SPARC32
-	default 64 if SPARC64
-
 config IOMMU_HELPER
 	bool
 	default y if SPARC64