From patchwork Tue Feb 10 22:43:00 2009
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: max_retries reaches -1, not 0
X-Patchwork-Submitter: roel kluin <roel.kluin@gmail.com>
X-Patchwork-Id: 22894
Message-Id: <499202F4.3020408@gmail.com>
To: s.hauer@pengutronix.de, David.Woodhouse@intel.com
Cc: linux-mtd@lists.infradead.org
Date: Tue, 10 Feb 2009 23:43:00 +0100
From: Roel Kluin <roel.kluin@gmail.com>
List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>

With while (max_retries-- > 0) { ... } max_retries reaches -1, not 0,
so we shouldn't DEBUG() on a max_retries of 0.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>

diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c
index 21fd4f1..5c34148 100644
--- a/drivers/mtd/nand/mxc_nand.c
+++ b/drivers/mtd/nand/mxc_nand.c
@@ -192,7 +192,7 @@ static void wait_op_done(struct mxc_nand_host *host, int max_retries,
 			}
 			udelay(1);
 		}
-		if (max_retries <= 0)
+		if (max_retries < 0)
 			DEBUG(MTD_DEBUG_LEVEL0, "%s(%d): INT not set\n",
 			      __func__, param);
 	}