Patchwork [U-Boot,PULL] u-boot-usb/master

login
register
mail settings
Submitter Marek Vasut
Date March 18, 2013, 6:01 p.m.
Message ID <201303181901.16762.marex@denx.de>
Download mbox
Permalink /patch/228764/
State Accepted
Delegated to: Tom Rini
Headers show

Pull-request

git://git.denx.de/u-boot-usb.git master

Comments

Marek Vasut - March 18, 2013, 6:01 p.m.
Hi Tom,

fixed, see new PR below please. Sorry about that, it's quite a load of stuff on 
me recently.

The following changes since commit b5bec88434adb52413f1bc33fa63d7642cb8fd35:

  Use 'unsigned int' for global_data's baudrate (2013-03-15 16:14:02 -0400)

are available in the git repository at:

  git://git.denx.de/u-boot-usb.git master

for you to fetch changes up to ae003d057077d792c1f2131753a7596c94e0bba4:

  usb: Add multiple controllers support for EHCI PCI (2013-03-18 18:58:55 +0100)

----------------------------------------------------------------
Lukasz Majewski (4):
      usb:composite:fix Provide function data when addressing device with only 
one interface
      usb:composite: USB Mass Storage - storage_common.c from Linux kernel
      usb:gadget: USB Mass Storage Gadget support
      arm:trats: Use new ums command

Michael Spang (1):
      usb: usbeth: smsc95xx: remove EEPROM loaded check

Pantelis Antoniou (5):
      dfu: Only perform DFU board_usb_init() for TRATS
      dfu: Fix crash when wrong number of arguments given
      dfu: Properly zero out timeout value
      dfu: Add a partition type target
      usb: Fix bug when both DFU & ETHER are defined

Patrick Georgi (1):
      usb: ehci: Support interrupt transfers via periodic list

Piotr Wilczek (1):
      usb:composite: USB Mass Storage - f_mass_storage.c from Linux kernel

Shiraz Hashim (1):
      usbtty: adapt buffers for large packet support

Simon Glass (1):
      x86: Enable USB features for coreboot

Vincent Palatin (4):
      usb: ehci: generic PCI support
      usb: ehci: Add 64-bit controller support
      usb: ehci: Fix aliasing issue in EHCI interrupt code
      usb: Add multiple controllers support for EHCI PCI

Vipin Kumar (1):
      usb/host/ehci: Add support for EHCI on spear

Vivek Gautam (2):
      usb: ehci: exynos: Fix multiple FDT decode
      usb: ehci: exynos: Enable non-dt path

 board/samsung/trats/trats.c         |   63 ++
 common/Makefile                     |    1 +
 common/cmd_dfu.c                    |    5 +-
 common/cmd_usb_mass_storage.c       |   86 +++
 drivers/dfu/dfu_mmc.c               |   31 +
 drivers/serial/usbtty.c             |    2 +-
 drivers/usb/eth/smsc95xx.c          |    4 -
 drivers/usb/gadget/Makefile         |   10 +-
 drivers/usb/gadget/composite.c      |   19 +
 drivers/usb/gadget/f_dfu.c          |    3 +
 drivers/usb/gadget/f_mass_storage.c | 2793 
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 drivers/usb/gadget/g_dnl.c          |    6 +
 drivers/usb/gadget/storage_common.c |  653 ++++++++++++++++++++
 drivers/usb/host/Makefile           |    1 +
 drivers/usb/host/ehci-exynos.c      |   51 +-
 drivers/usb/host/ehci-hcd.c         |  318 +++++++++-
 drivers/usb/host/ehci-pci.c         |   60 +-
 drivers/usb/host/ehci-spear.c       |   59 ++
 drivers/usb/host/ehci.h             |    6 +-
 include/configs/coreboot.h          |   17 +
 include/configs/trats.h             |    5 +
 include/usb_mass_storage.h          |   55 ++
 include/usbdevice.h                 |    4 +-
 23 files changed, 4203 insertions(+), 49 deletions(-)
 create mode 100644 common/cmd_usb_mass_storage.c
 create mode 100644 drivers/usb/gadget/f_mass_storage.c
 create mode 100644 drivers/usb/gadget/storage_common.c
 create mode 100644 drivers/usb/host/ehci-spear.c
 create mode 100644 include/usb_mass_storage.h
Tom Rini - March 19, 2013, 2:20 p.m.
On Mon, Mar 18, 2013 at 07:01:16PM +0100, Marek Vasut wrote:

> Hi Tom,
> 
> fixed, see new PR below please. Sorry about that, it's quite a load of stuff on 
> me recently.
> 
> The following changes since commit b5bec88434adb52413f1bc33fa63d7642cb8fd35:
> 
>   Use 'unsigned int' for global_data's baudrate (2013-03-15 16:14:02 -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-usb.git master
> 
> for you to fetch changes up to ae003d057077d792c1f2131753a7596c94e0bba4:
> 
>   usb: Add multiple controllers support for EHCI PCI (2013-03-18 18:58:55 +0100)
> 
> ----------------------------------------------------------------
> Lukasz Majewski (4):
>       usb:composite:fix Provide function data when addressing device with only 
> one interface
>       usb:composite: USB Mass Storage - storage_common.c from Linux kernel
>       usb:gadget: USB Mass Storage Gadget support
>       arm:trats: Use new ums command
> 
> Michael Spang (1):
>       usb: usbeth: smsc95xx: remove EEPROM loaded check
> 
> Pantelis Antoniou (5):
>       dfu: Only perform DFU board_usb_init() for TRATS
>       dfu: Fix crash when wrong number of arguments given
>       dfu: Properly zero out timeout value
>       dfu: Add a partition type target
>       usb: Fix bug when both DFU & ETHER are defined
> 
> Patrick Georgi (1):
>       usb: ehci: Support interrupt transfers via periodic list
> 
> Piotr Wilczek (1):
>       usb:composite: USB Mass Storage - f_mass_storage.c from Linux kernel
> 
> Shiraz Hashim (1):
>       usbtty: adapt buffers for large packet support
> 
> Simon Glass (1):
>       x86: Enable USB features for coreboot
> 
> Vincent Palatin (4):
>       usb: ehci: generic PCI support
>       usb: ehci: Add 64-bit controller support
>       usb: ehci: Fix aliasing issue in EHCI interrupt code
>       usb: Add multiple controllers support for EHCI PCI
> 
> Vipin Kumar (1):
>       usb/host/ehci: Add support for EHCI on spear
> 
> Vivek Gautam (2):
>       usb: ehci: exynos: Fix multiple FDT decode
>       usb: ehci: exynos: Enable non-dt path
> 
>  board/samsung/trats/trats.c         |   63 ++
>  common/Makefile                     |    1 +
>  common/cmd_dfu.c                    |    5 +-
>  common/cmd_usb_mass_storage.c       |   86 +++
>  drivers/dfu/dfu_mmc.c               |   31 +
>  drivers/serial/usbtty.c             |    2 +-
>  drivers/usb/eth/smsc95xx.c          |    4 -
>  drivers/usb/gadget/Makefile         |   10 +-
>  drivers/usb/gadget/composite.c      |   19 +
>  drivers/usb/gadget/f_dfu.c          |    3 +
>  drivers/usb/gadget/f_mass_storage.c | 2793 
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  drivers/usb/gadget/g_dnl.c          |    6 +
>  drivers/usb/gadget/storage_common.c |  653 ++++++++++++++++++++
>  drivers/usb/host/Makefile           |    1 +
>  drivers/usb/host/ehci-exynos.c      |   51 +-
>  drivers/usb/host/ehci-hcd.c         |  318 +++++++++-
>  drivers/usb/host/ehci-pci.c         |   60 +-
>  drivers/usb/host/ehci-spear.c       |   59 ++
>  drivers/usb/host/ehci.h             |    6 +-
>  include/configs/coreboot.h          |   17 +
>  include/configs/trats.h             |    5 +
>  include/usb_mass_storage.h          |   55 ++
>  include/usbdevice.h                 |    4 +-
>  23 files changed, 4203 insertions(+), 49 deletions(-)
>  create mode 100644 common/cmd_usb_mass_storage.c
>  create mode 100644 drivers/usb/gadget/f_mass_storage.c
>  create mode 100644 drivers/usb/gadget/storage_common.c
>  create mode 100644 drivers/usb/host/ehci-spear.c
>  create mode 100644 include/usb_mass_storage.h

Applied to u-boot/master, thanks!  Now that I believe the rest of the
DFU stuff is sorted (Lukasz, are you good or do you want to
re-review/test again?  I think it's only comment changes/checkpatch
stuff since the last time you tested/acked) do you want to pick that up?
Thanks.
Ɓukasz Majewski - March 19, 2013, 5:59 p.m.
Hi Tom,

> On Mon, Mar 18, 2013 at 07:01:16PM +0100, Marek Vasut wrote:
> 
> > Hi Tom,
> > 
> > fixed, see new PR below please. Sorry about that, it's quite a load
> > of stuff on me recently.
> > 
> > The following changes since commit
> > b5bec88434adb52413f1bc33fa63d7642cb8fd35:
> > 
> >   Use 'unsigned int' for global_data's baudrate (2013-03-15
> > 16:14:02 -0400)
> > 
> > are available in the git repository at:
> > 
> >   git://git.denx.de/u-boot-usb.git master
> > 
> > for you to fetch changes up to
> > ae003d057077d792c1f2131753a7596c94e0bba4:
> > 
> >   usb: Add multiple controllers support for EHCI PCI (2013-03-18
> > 18:58:55 +0100)
> > 
> > ----------------------------------------------------------------
> > Lukasz Majewski (4):
> >       usb:composite:fix Provide function data when addressing
> > device with only one interface
> >       usb:composite: USB Mass Storage - storage_common.c from Linux
> > kernel usb:gadget: USB Mass Storage Gadget support
> >       arm:trats: Use new ums command
> > 
> > Michael Spang (1):
> >       usb: usbeth: smsc95xx: remove EEPROM loaded check
> > 
> > Pantelis Antoniou (5):
> >       dfu: Only perform DFU board_usb_init() for TRATS
> >       dfu: Fix crash when wrong number of arguments given
> >       dfu: Properly zero out timeout value
> >       dfu: Add a partition type target
> >       usb: Fix bug when both DFU & ETHER are defined
> > 
> > Patrick Georgi (1):
> >       usb: ehci: Support interrupt transfers via periodic list
> > 
> > Piotr Wilczek (1):
> >       usb:composite: USB Mass Storage - f_mass_storage.c from Linux
> > kernel
> > 
> > Shiraz Hashim (1):
> >       usbtty: adapt buffers for large packet support
> > 
> > Simon Glass (1):
> >       x86: Enable USB features for coreboot
> > 
> > Vincent Palatin (4):
> >       usb: ehci: generic PCI support
> >       usb: ehci: Add 64-bit controller support
> >       usb: ehci: Fix aliasing issue in EHCI interrupt code
> >       usb: Add multiple controllers support for EHCI PCI
> > 
> > Vipin Kumar (1):
> >       usb/host/ehci: Add support for EHCI on spear
> > 
> > Vivek Gautam (2):
> >       usb: ehci: exynos: Fix multiple FDT decode
> >       usb: ehci: exynos: Enable non-dt path
> > 
> >  board/samsung/trats/trats.c         |   63 ++
> >  common/Makefile                     |    1 +
> >  common/cmd_dfu.c                    |    5 +-
> >  common/cmd_usb_mass_storage.c       |   86 +++
> >  drivers/dfu/dfu_mmc.c               |   31 +
> >  drivers/serial/usbtty.c             |    2 +-
> >  drivers/usb/eth/smsc95xx.c          |    4 -
> >  drivers/usb/gadget/Makefile         |   10 +-
> >  drivers/usb/gadget/composite.c      |   19 +
> >  drivers/usb/gadget/f_dfu.c          |    3 +
> >  drivers/usb/gadget/f_mass_storage.c | 2793 
> > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  drivers/usb/gadget/g_dnl.c          |    6 +
> >  drivers/usb/gadget/storage_common.c |  653 ++++++++++++++++++++
> >  drivers/usb/host/Makefile           |    1 +
> >  drivers/usb/host/ehci-exynos.c      |   51 +-
> >  drivers/usb/host/ehci-hcd.c         |  318 +++++++++-
> >  drivers/usb/host/ehci-pci.c         |   60 +-
> >  drivers/usb/host/ehci-spear.c       |   59 ++
> >  drivers/usb/host/ehci.h             |    6 +-
> >  include/configs/coreboot.h          |   17 +
> >  include/configs/trats.h             |    5 +
> >  include/usb_mass_storage.h          |   55 ++
> >  include/usbdevice.h                 |    4 +-
> >  23 files changed, 4203 insertions(+), 49 deletions(-)
> >  create mode 100644 common/cmd_usb_mass_storage.c
> >  create mode 100644 drivers/usb/gadget/f_mass_storage.c
> >  create mode 100644 drivers/usb/gadget/storage_common.c
> >  create mode 100644 drivers/usb/host/ehci-spear.c
> >  create mode 100644 include/usb_mass_storage.h
> 
> Applied to u-boot/master, thanks!  Now that I believe the rest of the
> DFU stuff is sorted (Lukasz, are you good or do you want to
> re-review/test again?  I think it's only comment changes/checkpatch
> stuff since the last time you tested/acked) do you want to pick that
> up? Thanks.
> 

I've tested it on trats board. 

For me it looks OK, so

Acked-by: "Lukasz Majewski <l.majewski@samsung.com>"
Test-HW: Trats
Tested-by: "Lukasz Majewski <l.majewski@samsung.com>"
Marek Vasut - March 19, 2013, 8:25 p.m.
Dear Tom Rini,

> On Mon, Mar 18, 2013 at 07:01:16PM +0100, Marek Vasut wrote:
> > Hi Tom,
> > 
> > fixed, see new PR below please. Sorry about that, it's quite a load of
> > stuff on me recently.
> > 
> > The following changes since commit b5bec88434adb52413f1bc33fa63d7642cb8fd35:
> >   Use 'unsigned int' for global_data's baudrate (2013-03-15 16:14:02
> >   -0400)
> > 
> > are available in the git repository at:
> >   git://git.denx.de/u-boot-usb.git master
> > 
> > for you to fetch changes up to ae003d057077d792c1f2131753a7596c94e0bba4:
> >   usb: Add multiple controllers support for EHCI PCI (2013-03-18 18:58:55
> >   +0100)
> > 
> > ----------------------------------------------------------------
> > 
> > Lukasz Majewski (4):
> >       usb:composite:fix Provide function data when addressing device with
> >       only
> > 
> > one interface
> > 
> >       usb:composite: USB Mass Storage - storage_common.c from Linux
> >       kernel usb:gadget: USB Mass Storage Gadget support
> >       arm:trats: Use new ums command
> > 
> > Michael Spang (1):
> >       usb: usbeth: smsc95xx: remove EEPROM loaded check
> > 
> > Pantelis Antoniou (5):
> >       dfu: Only perform DFU board_usb_init() for TRATS
> >       dfu: Fix crash when wrong number of arguments given
> >       dfu: Properly zero out timeout value
> >       dfu: Add a partition type target
> >       usb: Fix bug when both DFU & ETHER are defined
> > 
> > Patrick Georgi (1):
> >       usb: ehci: Support interrupt transfers via periodic list
> > 
> > Piotr Wilczek (1):
> >       usb:composite: USB Mass Storage - f_mass_storage.c from Linux
> >       kernel
> > 
> > Shiraz Hashim (1):
> >       usbtty: adapt buffers for large packet support
> > 
> > Simon Glass (1):
> >       x86: Enable USB features for coreboot
> > 
> > Vincent Palatin (4):
> >       usb: ehci: generic PCI support
> >       usb: ehci: Add 64-bit controller support
> >       usb: ehci: Fix aliasing issue in EHCI interrupt code
> >       usb: Add multiple controllers support for EHCI PCI
> > 
> > Vipin Kumar (1):
> >       usb/host/ehci: Add support for EHCI on spear
> > 
> > Vivek Gautam (2):
> >       usb: ehci: exynos: Fix multiple FDT decode
> >       usb: ehci: exynos: Enable non-dt path
> >  
> >  board/samsung/trats/trats.c         |   63 ++
> >  common/Makefile                     |    1 +
> >  common/cmd_dfu.c                    |    5 +-
> >  common/cmd_usb_mass_storage.c       |   86 +++
> >  drivers/dfu/dfu_mmc.c               |   31 +
> >  drivers/serial/usbtty.c             |    2 +-
> >  drivers/usb/eth/smsc95xx.c          |    4 -
> >  drivers/usb/gadget/Makefile         |   10 +-
> >  drivers/usb/gadget/composite.c      |   19 +
> >  drivers/usb/gadget/f_dfu.c          |    3 +
> >  drivers/usb/gadget/f_mass_storage.c | 2793
> > 
> > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > +++++++++++
> > 
> >  drivers/usb/gadget/g_dnl.c          |    6 +
> >  drivers/usb/gadget/storage_common.c |  653 ++++++++++++++++++++
> >  drivers/usb/host/Makefile           |    1 +
> >  drivers/usb/host/ehci-exynos.c      |   51 +-
> >  drivers/usb/host/ehci-hcd.c         |  318 +++++++++-
> >  drivers/usb/host/ehci-pci.c         |   60 +-
> >  drivers/usb/host/ehci-spear.c       |   59 ++
> >  drivers/usb/host/ehci.h             |    6 +-
> >  include/configs/coreboot.h          |   17 +
> >  include/configs/trats.h             |    5 +
> >  include/usb_mass_storage.h          |   55 ++
> >  include/usbdevice.h                 |    4 +-
> >  23 files changed, 4203 insertions(+), 49 deletions(-)
> >  create mode 100644 common/cmd_usb_mass_storage.c
> >  create mode 100644 drivers/usb/gadget/f_mass_storage.c
> >  create mode 100644 drivers/usb/gadget/storage_common.c
> >  create mode 100644 drivers/usb/host/ehci-spear.c
> >  create mode 100644 include/usb_mass_storage.h
> 
> Applied to u-boot/master, thanks!  Now that I believe the rest of the
> DFU stuff is sorted (Lukasz, are you good or do you want to
> re-review/test again?  I think it's only comment changes/checkpatch
> stuff since the last time you tested/acked) do you want to pick that up?
> Thanks.

Yes, I can pick that if you point me to it properly

Best regards,
Marek Vasut
Tom Rini - March 19, 2013, 9:35 p.m.
On Tue, Mar 19, 2013 at 09:25:45PM +0100, Marek Vasut wrote:
> Dear Tom Rini,
> 
> > On Mon, Mar 18, 2013 at 07:01:16PM +0100, Marek Vasut wrote:
> > > Hi Tom,
> > > 
> > > fixed, see new PR below please. Sorry about that, it's quite a load of
> > > stuff on me recently.
> > > 
> > > The following changes since commit b5bec88434adb52413f1bc33fa63d7642cb8fd35:
> > >   Use 'unsigned int' for global_data's baudrate (2013-03-15 16:14:02
> > >   -0400)
> > > 
> > > are available in the git repository at:
> > >   git://git.denx.de/u-boot-usb.git master
> > > 
> > > for you to fetch changes up to ae003d057077d792c1f2131753a7596c94e0bba4:
> > >   usb: Add multiple controllers support for EHCI PCI (2013-03-18 18:58:55
> > >   +0100)
> > > 
> > > ----------------------------------------------------------------
> > > 
> > > Lukasz Majewski (4):
> > >       usb:composite:fix Provide function data when addressing device with
> > >       only
> > > 
> > > one interface
> > > 
> > >       usb:composite: USB Mass Storage - storage_common.c from Linux
> > >       kernel usb:gadget: USB Mass Storage Gadget support
> > >       arm:trats: Use new ums command
> > > 
> > > Michael Spang (1):
> > >       usb: usbeth: smsc95xx: remove EEPROM loaded check
> > > 
> > > Pantelis Antoniou (5):
> > >       dfu: Only perform DFU board_usb_init() for TRATS
> > >       dfu: Fix crash when wrong number of arguments given
> > >       dfu: Properly zero out timeout value
> > >       dfu: Add a partition type target
> > >       usb: Fix bug when both DFU & ETHER are defined
> > > 
> > > Patrick Georgi (1):
> > >       usb: ehci: Support interrupt transfers via periodic list
> > > 
> > > Piotr Wilczek (1):
> > >       usb:composite: USB Mass Storage - f_mass_storage.c from Linux
> > >       kernel
> > > 
> > > Shiraz Hashim (1):
> > >       usbtty: adapt buffers for large packet support
> > > 
> > > Simon Glass (1):
> > >       x86: Enable USB features for coreboot
> > > 
> > > Vincent Palatin (4):
> > >       usb: ehci: generic PCI support
> > >       usb: ehci: Add 64-bit controller support
> > >       usb: ehci: Fix aliasing issue in EHCI interrupt code
> > >       usb: Add multiple controllers support for EHCI PCI
> > > 
> > > Vipin Kumar (1):
> > >       usb/host/ehci: Add support for EHCI on spear
> > > 
> > > Vivek Gautam (2):
> > >       usb: ehci: exynos: Fix multiple FDT decode
> > >       usb: ehci: exynos: Enable non-dt path
> > >  
> > >  board/samsung/trats/trats.c         |   63 ++
> > >  common/Makefile                     |    1 +
> > >  common/cmd_dfu.c                    |    5 +-
> > >  common/cmd_usb_mass_storage.c       |   86 +++
> > >  drivers/dfu/dfu_mmc.c               |   31 +
> > >  drivers/serial/usbtty.c             |    2 +-
> > >  drivers/usb/eth/smsc95xx.c          |    4 -
> > >  drivers/usb/gadget/Makefile         |   10 +-
> > >  drivers/usb/gadget/composite.c      |   19 +
> > >  drivers/usb/gadget/f_dfu.c          |    3 +
> > >  drivers/usb/gadget/f_mass_storage.c | 2793
> > > 
> > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > > +++++++++++
> > > 
> > >  drivers/usb/gadget/g_dnl.c          |    6 +
> > >  drivers/usb/gadget/storage_common.c |  653 ++++++++++++++++++++
> > >  drivers/usb/host/Makefile           |    1 +
> > >  drivers/usb/host/ehci-exynos.c      |   51 +-
> > >  drivers/usb/host/ehci-hcd.c         |  318 +++++++++-
> > >  drivers/usb/host/ehci-pci.c         |   60 +-
> > >  drivers/usb/host/ehci-spear.c       |   59 ++
> > >  drivers/usb/host/ehci.h             |    6 +-
> > >  include/configs/coreboot.h          |   17 +
> > >  include/configs/trats.h             |    5 +
> > >  include/usb_mass_storage.h          |   55 ++
> > >  include/usbdevice.h                 |    4 +-
> > >  23 files changed, 4203 insertions(+), 49 deletions(-)
> > >  create mode 100644 common/cmd_usb_mass_storage.c
> > >  create mode 100644 drivers/usb/gadget/f_mass_storage.c
> > >  create mode 100644 drivers/usb/gadget/storage_common.c
> > >  create mode 100644 drivers/usb/host/ehci-spear.c
> > >  create mode 100644 include/usb_mass_storage.h
> > 
> > Applied to u-boot/master, thanks!  Now that I believe the rest of the
> > DFU stuff is sorted (Lukasz, are you good or do you want to
> > re-review/test again?  I think it's only comment changes/checkpatch
> > stuff since the last time you tested/acked) do you want to pick that up?
> > Thanks.
> 
> Yes, I can pick that if you point me to it properly

The 9 part v6 in
http://patchwork.ozlabs.org/project/uboot/list/?delegate=1699 and please
update the other patches which I believe I just pulled in.  Thanks!