Patchwork [net] Phonet: fix double free in GPRS outbound packet error path

login
register
mail settings
Submitter Rémi Denis-Courmont
Date Feb. 10, 2009, 2:23 p.m.
Message ID <1234275835-14402-1-git-send-email-remi.denis-courmont@nokia.com>
Download mbox | patch
Permalink /patch/22875/
State Accepted
Delegated to: David Miller
Headers show

Comments

Rémi Denis-Courmont - Feb. 10, 2009, 2:23 p.m.
From: "Remi Denis-Courmont" <remi.denis-courmont@nokia.com>

Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
---
 net/phonet/pep-gprs.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
David Miller - Feb. 11, 2009, 1:14 a.m.
From: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
Date: Tue, 10 Feb 2009 16:23:54 +0200

> Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/net/phonet/pep-gprs.c b/net/phonet/pep-gprs.c
index 6a91a32..4aa8885 100644
--- a/net/phonet/pep-gprs.c
+++ b/net/phonet/pep-gprs.c
@@ -207,7 +207,6 @@  static int gprs_xmit(struct sk_buff *skb, struct net_device *dev)
 				dev->name, err);
 		dev->stats.tx_aborted_errors++;
 		dev->stats.tx_errors++;
-		dev_kfree_skb(skb);
 	} else {
 		dev->stats.tx_packets++;
 		dev->stats.tx_bytes += len;