From patchwork Mon Mar 18 12:29:38 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Venu Byravarasu X-Patchwork-Id: 228485 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 1C0FE2C00C7 for ; Mon, 18 Mar 2013 23:34:55 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752628Ab3CRMej (ORCPT ); Mon, 18 Mar 2013 08:34:39 -0400 Received: from hqemgate04.nvidia.com ([216.228.121.35]:19906 "EHLO hqemgate04.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751878Ab3CRMdo (ORCPT ); Mon, 18 Mar 2013 08:33:44 -0400 Received: from hqnvupgp08.nvidia.com (Not Verified[216.228.121.13]) by hqemgate04.nvidia.com id ; Mon, 18 Mar 2013 05:33:34 -0700 Received: from hqemhub02.nvidia.com ([172.17.108.22]) by hqnvupgp08.nvidia.com (PGP Universal service); Mon, 18 Mar 2013 05:26:33 -0700 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Mon, 18 Mar 2013 05:26:33 -0700 Received: from localhost.localdomain (172.20.144.16) by hqemhub02.nvidia.com (172.20.150.31) with Microsoft SMTP Server (TLS) id 8.3.298.1; Mon, 18 Mar 2013 05:33:35 -0700 From: Venu Byravarasu To: , , CC: , , , , , Venu Byravarasu Subject: [PATCH 4/7] usb: phy: tegra: Return correct error value provided by clk_get_sys Date: Mon, 18 Mar 2013 17:59:38 +0530 Message-ID: <1363609781-4045-5-git-send-email-vbyravarasu@nvidia.com> X-Mailer: git-send-email 1.7.0.4 In-Reply-To: <1363609781-4045-1-git-send-email-vbyravarasu@nvidia.com> References: <1363609781-4045-1-git-send-email-vbyravarasu@nvidia.com> X-NVConfidentiality: public MIME-Version: 1.0 Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org In case if clk_get_sys fails, return correct error value provided by the API. Signed-off-by: Venu Byravarasu --- drivers/usb/phy/tegra_usb_phy.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/usb/phy/tegra_usb_phy.c b/drivers/usb/phy/tegra_usb_phy.c index 93abd68..b5b2037 100644 --- a/drivers/usb/phy/tegra_usb_phy.c +++ b/drivers/usb/phy/tegra_usb_phy.c @@ -620,8 +620,7 @@ static int tegra_phy_init(struct usb_phy *x) phy->clk = clk_get_sys(NULL, ulpi_config->clk); if (IS_ERR(phy->clk)) { pr_err("%s: can't get ulpi clock\n", __func__); - err = -ENXIO; - goto err1; + return PTR_ERR(phy->clk); } if (!gpio_is_valid(ulpi_config->reset_gpio)) ulpi_config->reset_gpio =