Patchwork [08/11] mtd: add a new field for ecc info in the nand_flash_dev{}

login
register
mail settings
Submitter Huang Shijie
Date March 18, 2013, 11:18 a.m.
Message ID <1363605534-24776-9-git-send-email-b32955@freescale.com>
Download mbox | patch
Permalink /patch/228478/
State New
Headers show

Comments

Huang Shijie - March 18, 2013, 11:18 a.m.
Add the @ecc_info in the nand_flash_dev{}.
The lower 16 bits are used to store the ECC bits, while the upper 16 bits
are used to store the ECC data chunk size.

Signed-off-by: Huang Shijie <b32955@freescale.com>
---
 include/linux/mtd/nand.h |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)
Artem Bityutskiy - April 16, 2013, 2:56 p.m.
On Mon, 2013-03-18 at 19:18 +0800, Huang Shijie wrote:
> +#define ECC_INFO(strength, size)	(((strength) << 16) | (size))
> +#define ECC_STRENGTH(x)			(((x) >> 16) & 0xffff)
> +#define ECC_SIZE(x)			((x) & 0xffff)
> +	uint32_t ecc_info;
>  };

Could you please avoid putting macro definition in the middle of the
structure. Put it before the structure.

Also, probably prefixing with NAND_ would make sense?
Huang Shijie - April 17, 2013, 2:11 a.m.
于 2013年04月16日 22:56, Artem Bityutskiy 写道:
> On Mon, 2013-03-18 at 19:18 +0800, Huang Shijie wrote:
>> +#define ECC_INFO(strength, size)	(((strength)<<  16) | (size))
>> +#define ECC_STRENGTH(x)			(((x)>>  16)&  0xffff)
>> +#define ECC_SIZE(x)			((x)&  0xffff)
>> +	uint32_t ecc_info;
>>   };
> Could you please avoid putting macro definition in the middle of the
> structure. Put it before the structure.
>
> Also, probably prefixing with NAND_ would make sense?
got it.

thanks
Huang Shijie

Patch

diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h
index 2c5a2e0..2837bc6 100644
--- a/include/linux/mtd/nand.h
+++ b/include/linux/mtd/nand.h
@@ -633,6 +633,11 @@  struct nand_chip {
  * @options: stores various chip bit options
  * @id_len: The valid length of the @id.
  * @oobsize: OOB size
+ * @ecc_info: The ECC information.
+ *            lower 16 bits: store the ECC bits.
+ *            upper 16 bits: store the ECC data chunk size.
+ *            For example, the "4bit ECC for each 512Byte" can be set with
+ *            ECC_INFO(4, 512) macro.
  */
 struct nand_flash_dev {
 	char *name;
@@ -649,6 +654,11 @@  struct nand_flash_dev {
 	unsigned int options;
 	uint16_t id_len;
 	uint16_t oobsize;
+
+#define ECC_INFO(strength, size)	(((strength) << 16) | (size))
+#define ECC_STRENGTH(x)			(((x) >> 16) & 0xffff)
+#define ECC_SIZE(x)			((x) & 0xffff)
+	uint32_t ecc_info;
 };
 
 /**