mbox

[PULL] vhost: tcm_vhost fixes for 3.9

Message ID 20130318112003.GA7809@redhat.com
State Not Applicable, archived
Delegated to: David Miller
Headers show

Pull-request

git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost-net

Message

Michael S. Tsirkin March 18, 2013, 11:20 a.m. UTC
The following changes since commit 8c6216d7f118a128678270824b6a1286a63863ca:

  Revert "ip_gre: make ipgre_tunnel_xmit() not parse network header as IP unconditionally" (2013-03-16 23:00:41 -0400)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost-net

for you to fetch changes up to deb7cb067dabd3be625eaf5495da8bdc97377fc1:

  tcm_vhost: Flush vhost_work in vhost_scsi_flush() (2013-03-17 13:04:14 +0200)

----------------------------------------------------------------
Asias He (2):
      tcm_vhost: Add missed lock in vhost_scsi_clear_endpoint()
      tcm_vhost: Flush vhost_work in vhost_scsi_flush()

 drivers/vhost/tcm_vhost.c | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

David Miller March 18, 2013, 5:01 p.m. UTC | #1
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Mon, 18 Mar 2013 13:20:03 +0200

> The following changes since commit 8c6216d7f118a128678270824b6a1286a63863ca:
> 
>   Revert "ip_gre: make ipgre_tunnel_xmit() not parse network header as IP unconditionally" (2013-03-16 23:00:41 -0400)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost-net
> 
> for you to fetch changes up to deb7cb067dabd3be625eaf5495da8bdc97377fc1:
> 
>   tcm_vhost: Flush vhost_work in vhost_scsi_flush() (2013-03-17 13:04:14 +0200)

This is a scsi driver, I therefore don't think this pull request is for me.

Please avoid such confusion in the future, and don't use branch names
like "vhost-net" for SCSI driver fixes.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Michael S. Tsirkin March 18, 2013, 7:54 p.m. UTC | #2
On Mon, Mar 18, 2013 at 01:01:36PM -0400, David Miller wrote:
> From: "Michael S. Tsirkin" <mst@redhat.com>
> Date: Mon, 18 Mar 2013 13:20:03 +0200
> 
> > The following changes since commit 8c6216d7f118a128678270824b6a1286a63863ca:
> > 
> >   Revert "ip_gre: make ipgre_tunnel_xmit() not parse network header as IP unconditionally" (2013-03-16 23:00:41 -0400)
> > 
> > are available in the git repository at:
> > 
> >   git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost-net
> > 
> > for you to fetch changes up to deb7cb067dabd3be625eaf5495da8bdc97377fc1:
> > 
> >   tcm_vhost: Flush vhost_work in vhost_scsi_flush() (2013-03-17 13:04:14 +0200)
> 
> This is a scsi driver, I therefore don't think this pull request is for me.
> 
> Please avoid such confusion in the future, and don't use branch names
> like "vhost-net" for SCSI driver fixes.
> 
> Thanks.

We are sharing quite a bit of code, so it's a common tree.
There was a vhost-net patch there too but you picked it up
directly so I dropped that and what's left is vhost-scsi.
Typically vhost-net dominates so I'm just used to merging all vhost
things through you but if you think it's wrong I can send it directly to
Linus.
David Miller March 18, 2013, 8:05 p.m. UTC | #3
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Mon, 18 Mar 2013 21:54:43 +0200

> On Mon, Mar 18, 2013 at 01:01:36PM -0400, David Miller wrote:
>> From: "Michael S. Tsirkin" <mst@redhat.com>
>> Date: Mon, 18 Mar 2013 13:20:03 +0200
>> 
>> > The following changes since commit 8c6216d7f118a128678270824b6a1286a63863ca:
>> > 
>> >   Revert "ip_gre: make ipgre_tunnel_xmit() not parse network header as IP unconditionally" (2013-03-16 23:00:41 -0400)
>> > 
>> > are available in the git repository at:
>> > 
>> >   git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost-net
>> > 
>> > for you to fetch changes up to deb7cb067dabd3be625eaf5495da8bdc97377fc1:
>> > 
>> >   tcm_vhost: Flush vhost_work in vhost_scsi_flush() (2013-03-17 13:04:14 +0200)
>> 
>> This is a scsi driver, I therefore don't think this pull request is for me.
>> 
>> Please avoid such confusion in the future, and don't use branch names
>> like "vhost-net" for SCSI driver fixes.
>> 
>> Thanks.
> 
> We are sharing quite a bit of code, so it's a common tree.
> There was a vhost-net patch there too but you picked it up
> directly so I dropped that and what's left is vhost-scsi.
> Typically vhost-net dominates so I'm just used to merging all vhost
> things through you but if you think it's wrong I can send it directly to
> Linus.

Just like any other "bus" or "layer" for drivers, you should
really just send the networking bits my way.

Now, in situations where some generic vhost infrastructure is
necessary for a vhost-net specific change, that might be a
situation where we can merge the infrastructure change into
my tree so that the networking bits can go in too.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Nicholas A. Bellinger March 18, 2013, 9:10 p.m. UTC | #4
On Mon, 2013-03-18 at 21:54 +0200, Michael S. Tsirkin wrote:
> On Mon, Mar 18, 2013 at 01:01:36PM -0400, David Miller wrote:
> > From: "Michael S. Tsirkin" <mst@redhat.com>
> > Date: Mon, 18 Mar 2013 13:20:03 +0200
> > 
> > > The following changes since commit 8c6216d7f118a128678270824b6a1286a63863ca:
> > > 
> > >   Revert "ip_gre: make ipgre_tunnel_xmit() not parse network header as IP unconditionally" (2013-03-16 23:00:41 -0400)
> > > 
> > > are available in the git repository at:
> > > 
> > >   git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost-net
> > > 
> > > for you to fetch changes up to deb7cb067dabd3be625eaf5495da8bdc97377fc1:
> > > 
> > >   tcm_vhost: Flush vhost_work in vhost_scsi_flush() (2013-03-17 13:04:14 +0200)
> > 
> > This is a scsi driver, I therefore don't think this pull request is for me.
> > 
> > Please avoid such confusion in the future, and don't use branch names
> > like "vhost-net" for SCSI driver fixes.
> > 
> > Thanks.
> 
> We are sharing quite a bit of code, so it's a common tree.
> There was a vhost-net patch there too but you picked it up
> directly so I dropped that and what's left is vhost-scsi.
> Typically vhost-net dominates so I'm just used to merging all vhost
> things through you but if you think it's wrong I can send it directly to
> Linus.
> 

I'll be sending out a target-pending 3.9-rc-fixes pull request later in
the week, and am happy to include this series if you'd like.

--nab

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Michael S. Tsirkin March 18, 2013, 9:14 p.m. UTC | #5
On Mon, Mar 18, 2013 at 02:10:03PM -0700, Nicholas A. Bellinger wrote:
> On Mon, 2013-03-18 at 21:54 +0200, Michael S. Tsirkin wrote:
> > On Mon, Mar 18, 2013 at 01:01:36PM -0400, David Miller wrote:
> > > From: "Michael S. Tsirkin" <mst@redhat.com>
> > > Date: Mon, 18 Mar 2013 13:20:03 +0200
> > > 
> > > > The following changes since commit 8c6216d7f118a128678270824b6a1286a63863ca:
> > > > 
> > > >   Revert "ip_gre: make ipgre_tunnel_xmit() not parse network header as IP unconditionally" (2013-03-16 23:00:41 -0400)
> > > > 
> > > > are available in the git repository at:
> > > > 
> > > >   git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost-net
> > > > 
> > > > for you to fetch changes up to deb7cb067dabd3be625eaf5495da8bdc97377fc1:
> > > > 
> > > >   tcm_vhost: Flush vhost_work in vhost_scsi_flush() (2013-03-17 13:04:14 +0200)
> > > 
> > > This is a scsi driver, I therefore don't think this pull request is for me.
> > > 
> > > Please avoid such confusion in the future, and don't use branch names
> > > like "vhost-net" for SCSI driver fixes.
> > > 
> > > Thanks.
> > 
> > We are sharing quite a bit of code, so it's a common tree.
> > There was a vhost-net patch there too but you picked it up
> > directly so I dropped that and what's left is vhost-scsi.
> > Typically vhost-net dominates so I'm just used to merging all vhost
> > things through you but if you think it's wrong I can send it directly to
> > Linus.
> > 
> 
> I'll be sending out a target-pending 3.9-rc-fixes pull request later in
> the week, and am happy to include this series if you'd like.
> 
> --nab

Sure, go ahead. You can add
Acked-by: Michael S. Tsirkin <mst@redhat.com>
to the patches.
Nicholas A. Bellinger March 18, 2013, 9:36 p.m. UTC | #6
On Mon, 2013-03-18 at 23:14 +0200, Michael S. Tsirkin wrote:
> On Mon, Mar 18, 2013 at 02:10:03PM -0700, Nicholas A. Bellinger wrote:
> > On Mon, 2013-03-18 at 21:54 +0200, Michael S. Tsirkin wrote:
> > > On Mon, Mar 18, 2013 at 01:01:36PM -0400, David Miller wrote:
> > > > From: "Michael S. Tsirkin" <mst@redhat.com>
> > > > Date: Mon, 18 Mar 2013 13:20:03 +0200
> > > > 
> > > > > The following changes since commit 8c6216d7f118a128678270824b6a1286a63863ca:
> > > > > 
> > > > >   Revert "ip_gre: make ipgre_tunnel_xmit() not parse network header as IP unconditionally" (2013-03-16 23:00:41 -0400)
> > > > > 
> > > > > are available in the git repository at:
> > > > > 
> > > > >   git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost-net
> > > > > 
> > > > > for you to fetch changes up to deb7cb067dabd3be625eaf5495da8bdc97377fc1:
> > > > > 
> > > > >   tcm_vhost: Flush vhost_work in vhost_scsi_flush() (2013-03-17 13:04:14 +0200)
> > > > 
> > > > This is a scsi driver, I therefore don't think this pull request is for me.
> > > > 
> > > > Please avoid such confusion in the future, and don't use branch names
> > > > like "vhost-net" for SCSI driver fixes.
> > > > 
> > > > Thanks.
> > > 
> > > We are sharing quite a bit of code, so it's a common tree.
> > > There was a vhost-net patch there too but you picked it up
> > > directly so I dropped that and what's left is vhost-scsi.
> > > Typically vhost-net dominates so I'm just used to merging all vhost
> > > things through you but if you think it's wrong I can send it directly to
> > > Linus.
> > > 
> > 
> > I'll be sending out a target-pending 3.9-rc-fixes pull request later in
> > the week, and am happy to include this series if you'd like.
> > 
> > --nab
> 
> Sure, go ahead. You can add
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
> to the patches.
> 

Applied to target-pending/master.

Thanks MST & Asias!

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html