From patchwork Mon Mar 18 09:43:10 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Petazzoni X-Patchwork-Id: 228425 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from silver.osuosl.org (silver.osuosl.org [140.211.166.136]) by ozlabs.org (Postfix) with ESMTP id 851142C00C3 for ; Mon, 18 Mar 2013 20:43:26 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 20643272B9; Mon, 18 Mar 2013 09:43:25 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rcEAC9dvzimJ; Mon, 18 Mar 2013 09:43:24 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 05BBD30ED9; Mon, 18 Mar 2013 09:43:24 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id EA7588F74B for ; Mon, 18 Mar 2013 09:43:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 5FDFB8BDB7 for ; Mon, 18 Mar 2013 09:43:22 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BOYxarMGxpDv for ; Mon, 18 Mar 2013 09:43:21 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.free-electrons.com (mail.free-electrons.com [94.23.35.102]) by whitealder.osuosl.org (Postfix) with ESMTP id 246D885D75 for ; Mon, 18 Mar 2013 09:43:20 +0000 (UTC) Received: by mail.free-electrons.com (Postfix, from userid 106) id 33EF483E; Mon, 18 Mar 2013 10:43:21 +0100 (CET) Received: from skate (unknown [37.160.6.105]) by mail.free-electrons.com (Postfix) with ESMTPSA id F1DE67B7; Mon, 18 Mar 2013 10:43:19 +0100 (CET) Date: Mon, 18 Mar 2013 10:43:10 +0100 From: Thomas Petazzoni To: Peter Korsgaard Message-ID: <20130318104310.718e14d0@skate> In-Reply-To: <87vc8p3dfs.fsf@dell.be.48ers.dk> References: <359a800fb351cc1d10532e184d9dc7d30c5cd991.1363063832.git.s.martin49@gmail.com> <87vc8p3dfs.fsf@dell.be.48ers.dk> Organization: Free Electrons X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 Cc: buildroot@busybox.net, armadeus-forum@lists.sourceforge.net Subject: Re: [Buildroot] [PATCH 4/5] flite: new package X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net On Sun, 17 Mar 2013 22:48:39 +0100, Peter Korsgaard wrote: > Samuel> +FLITE_CONF_OPT = \ > Samuel> + $(if $(BR2_PREFER_STATIC_LIB),,--enable-shared) > > We're already pass --enable-shared in the autotools infrastructure, so > why is this needed? I've tested without this part, and the package builds fine, so I'm also not sure why it's needed. > Samuel> + > Samuel> +FLITE_INSTALL_STAGING_OPT = \ > Samuel> + INSTALLBINDIR=$(STAGING_DIR)/usr/bin \ > Samuel> + INSTALLLIBDIR=$(STAGING_DIR)/usr/lib \ > Samuel> + INSTALLINCDIR=$(STAGING_DIR)/usr/include/flite \ > Samuel> + install > Samuel> + > Samuel> +FLITE_INSTALL_TARGET_OPT = \ > Samuel> + INSTALLBINDIR=$(TARGET_DIR)/usr/bin \ > Samuel> + INSTALLLIBDIR=$(TARGET_DIR)/usr/lib \ > Samuel> + INSTALLINCDIR=$(TARGET_DIR)/usr/include/flite \ > Samuel> + install > > It could be good with a note about why this is needed (E.G. flite > used a handwritten a Makefile which doesn't handle DESTDIR even > though it uses autoconf). Another option is to add a patch like: That said, the project hasn't done any release since 2009, so the chances of getting this upstream are pretty small... Thomas Index: b/config/config.in =================================================================== --- a/config/config.in +++ b/config/config.in @@ -49,6 +49,6 @@ prefix = @prefix@ exec_prefix = @exec_prefix@ EXEEXT = @EXEEXT@ -INSTALLBINDIR = @bindir@ -INSTALLLIBDIR = @libdir@ -INSTALLINCDIR = @includedir@/flite +INSTALLBINDIR = $(DESTDIR)@bindir@ +INSTALLLIBDIR = $(DESTDIR)@libdir@ +INSTALLINCDIR = $(DESTDIR)@includedir@/flite