Patchwork [4/5] flite: new package

login
register
mail settings
Submitter Thomas Petazzoni
Date March 18, 2013, 9:43 a.m.
Message ID <20130318104310.718e14d0@skate>
Download mbox | patch
Permalink /patch/228425/
State Not Applicable
Headers show

Comments

Thomas Petazzoni - March 18, 2013, 9:43 a.m.
On Sun, 17 Mar 2013 22:48:39 +0100, Peter Korsgaard wrote:

>  Samuel> +FLITE_CONF_OPT = \
>  Samuel> +	$(if $(BR2_PREFER_STATIC_LIB),,--enable-shared)
> 
> We're already pass --enable-shared in the autotools infrastructure, so
> why is this needed?

I've tested without this part, and the package builds fine, so I'm
also not sure why it's needed.

>  Samuel> +
>  Samuel> +FLITE_INSTALL_STAGING_OPT = \
>  Samuel> +	INSTALLBINDIR=$(STAGING_DIR)/usr/bin \
>  Samuel> +	INSTALLLIBDIR=$(STAGING_DIR)/usr/lib \
>  Samuel> +	INSTALLINCDIR=$(STAGING_DIR)/usr/include/flite \
>  Samuel> +	install
>  Samuel> +
>  Samuel> +FLITE_INSTALL_TARGET_OPT = \
>  Samuel> +	INSTALLBINDIR=$(TARGET_DIR)/usr/bin \
>  Samuel> +	INSTALLLIBDIR=$(TARGET_DIR)/usr/lib \
>  Samuel> +	INSTALLINCDIR=$(TARGET_DIR)/usr/include/flite \
>  Samuel> +	install
> 
> It could be good with a note about why this is needed (E.G. flite
> used a handwritten a Makefile which doesn't handle DESTDIR even
> though it uses autoconf).

Another option is to add a patch like:


That said, the project hasn't done any release since 2009, so the
chances of getting this upstream are pretty small...

Thomas

Patch

Index: b/config/config.in
===================================================================
--- a/config/config.in
+++ b/config/config.in
@@ -49,6 +49,6 @@ 
 prefix        = @prefix@
 exec_prefix   = @exec_prefix@
 EXEEXT	      = @EXEEXT@
-INSTALLBINDIR = @bindir@
-INSTALLLIBDIR = @libdir@
-INSTALLINCDIR = @includedir@/flite
+INSTALLBINDIR = $(DESTDIR)@bindir@
+INSTALLLIBDIR = $(DESTDIR)@libdir@
+INSTALLINCDIR = $(DESTDIR)@includedir@/flite