Patchwork [1/2] Added package enscript

login
register
mail settings
Submitter Olivier Schonken
Date March 17, 2013, 3:59 p.m.
Message ID <1363535972-29959-1-git-send-email-olivier.schonken@gmail.com>
Download mbox | patch
Permalink /patch/228295/
State Superseded
Delegated to: Yann E. MORIN
Headers show

Comments

Olivier Schonken - March 17, 2013, 3:59 p.m.
GNU Enscript is a free replacement for Adobe's enscript program.
GNU Enscript converts ASCII files to PostScript, HTML, or RTF and
stores generated output to a file or sends it directly to the
printer. It includes features for `pretty-printing' (language-
sensitive code highlighting) in several programming languages.

Signed-off-by: Olivier Schonken <olivier.schonken@gmail.com>
---
 package/Config.in            |    1 +
 package/enscript/Config.in   |   13 +++++++++++++
 package/enscript/enscript.mk |   20 ++++++++++++++++++++
 3 files changed, 34 insertions(+)
 create mode 100644 package/enscript/Config.in
 create mode 100644 package/enscript/enscript.mk
Thomas Petazzoni - March 18, 2013, 4:34 p.m.
Dear Olivier Schonken,

On Sun, 17 Mar 2013 17:59:31 +0200, Olivier Schonken wrote:

>  menu "Interpreter languages and scripting"
>  source "package/erlang/Config.in"
> +source "package/enscript/Config.in"
>  source "package/haserl/Config.in"
>  source "package/jamvm/Config.in"
>  source "package/lua/Config.in"

Even though strictly speaking, enscript is an interpreter, I don't
think I would put it under the "Interpreter languages and scripting"
section.

> +config BR2_PACKAGE_ENSCRIPT
> +	bool "enscript"
> +	select BR2_PACKAGE_GETTEXT

Why? You don't even have gettext as a dependency in the .mk file.
Moreover, gettext handling is generally more complicated than just a
simple select, see
http://buildroot.org/downloads/manual/manual.html#_gettext_integration_and_interaction_with_packages.

> diff --git a/package/enscript/enscript.mk b/package/enscript/enscript.mk
> new file mode 100644
> index 0000000..29fd6d4
> --- /dev/null
> +++ b/package/enscript/enscript.mk
> @@ -0,0 +1,20 @@
> +#############################################################
> +#
> +# enscript
> +#
> +#############################################################
> +ENSCRIPT_VERSION = 1.6.6

Nitpick: one empty line between header and first variable.

> +ENSCRIPT_SITE = $(BR2_GNU_MIRROR)/enscript/
> +ENSCRIPT_SOURCE = enscript-$(ENSCRIPT_VERSION).tar.gz

Line not needed.

> +ENSCRIPT_DEPENDENCIES = 

Line not needed.

> +ENSCRIPT_LICENSE = GPLv3

The license is really not GPLv3+ ?

> +ENSCRIPT_LICENSE_FILES = COPYING
> +
> +#Enable pthread threads if toolchain supports threads
> +ifeq ($(BR2_TOOLCHAIN_HAS_THREADS), y)

No space before the "y".

> +	ENSCRIPT_CONF_OPT += --enable-threads=pth
> +else
> +	ENSCRIPT_CONF_OPT += --disable-threads
> +endif
> +
> +$(eval $(autotools-package))

Thomas

Patch

diff --git a/package/Config.in b/package/Config.in
index 4cf71d6..78bd745 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -292,6 +292,7 @@  endmenu
 
 menu "Interpreter languages and scripting"
 source "package/erlang/Config.in"
+source "package/enscript/Config.in"
 source "package/haserl/Config.in"
 source "package/jamvm/Config.in"
 source "package/lua/Config.in"
diff --git a/package/enscript/Config.in b/package/enscript/Config.in
new file mode 100644
index 0000000..5198da9
--- /dev/null
+++ b/package/enscript/Config.in
@@ -0,0 +1,13 @@ 
+config BR2_PACKAGE_ENSCRIPT
+	bool "enscript"
+	select BR2_PACKAGE_GETTEXT
+	help
+	   GNU Enscript is a free replacement for Adobe's enscript program.
+
+	   GNU Enscript converts ASCII files to PostScript, HTML, or RTF and 
+	   stores generated output to a file or sends it directly to the 
+	   printer. It includes features for `pretty-printing' (language-
+	   sensitive code highlighting) in several programming languages. 
+	  
+	   http://www.gnu.org/software/enscript
+
diff --git a/package/enscript/enscript.mk b/package/enscript/enscript.mk
new file mode 100644
index 0000000..29fd6d4
--- /dev/null
+++ b/package/enscript/enscript.mk
@@ -0,0 +1,20 @@ 
+#############################################################
+#
+# enscript
+#
+#############################################################
+ENSCRIPT_VERSION = 1.6.6
+ENSCRIPT_SITE = $(BR2_GNU_MIRROR)/enscript/
+ENSCRIPT_SOURCE = enscript-$(ENSCRIPT_VERSION).tar.gz
+ENSCRIPT_DEPENDENCIES = 
+ENSCRIPT_LICENSE = GPLv3
+ENSCRIPT_LICENSE_FILES = COPYING
+
+#Enable pthread threads if toolchain supports threads
+ifeq ($(BR2_TOOLCHAIN_HAS_THREADS), y)
+	ENSCRIPT_CONF_OPT += --enable-threads=pth
+else
+	ENSCRIPT_CONF_OPT += --disable-threads
+endif
+
+$(eval $(autotools-package))