| Message ID | 1363496294-31160-8-git-send-email-amartin@nvidia.com |
|---|---|
| State | Accepted |
| Delegated to: | Tom Warren |
| Headers | show |
Hi Allen, On Sun, Mar 17, 2013 at 10:28 AM, Allen Martin <amartin@nvidia.com> wrote: > Add support for Winbond W25Q32DW 32Mbit part > > Signed-off-by: Allen Martin <amartin@nvidia.com> > --- > drivers/mtd/spi/winbond.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/mtd/spi/winbond.c b/drivers/mtd/spi/winbond.c > index 4418302..3560fcb 100644 > --- a/drivers/mtd/spi/winbond.c > +++ b/drivers/mtd/spi/winbond.c > @@ -68,6 +68,11 @@ static const struct winbond_spi_flash_params winbond_spi_flash_table[] = { > .name = "W25Q80", > }, > { > + .id = 0x6016, > + .nr_blocks = 512, nr_blocks here should have 64 instead of 512. please let me know, I will add correction-patch for this. Thanks, Jagan. > + .name = "W25Q32DW", > + }, > + { > .id = 0x6017, > .nr_blocks = 128, > .name = "W25Q64DW", > -- > 1.7.10.4 > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot
Hi, Any update on this. Thanks, Jagan. On Thu, May 23, 2013 at 1:15 PM, Jagan Teki <jagannadh.teki@gmail.com> wrote: > Hi Allen, > > On Sun, Mar 17, 2013 at 10:28 AM, Allen Martin <amartin@nvidia.com> wrote: >> Add support for Winbond W25Q32DW 32Mbit part >> >> Signed-off-by: Allen Martin <amartin@nvidia.com> >> --- >> drivers/mtd/spi/winbond.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/drivers/mtd/spi/winbond.c b/drivers/mtd/spi/winbond.c >> index 4418302..3560fcb 100644 >> --- a/drivers/mtd/spi/winbond.c >> +++ b/drivers/mtd/spi/winbond.c >> @@ -68,6 +68,11 @@ static const struct winbond_spi_flash_params winbond_spi_flash_table[] = { >> .name = "W25Q80", >> }, >> { >> + .id = 0x6016, >> + .nr_blocks = 512, > > nr_blocks here should have 64 instead of 512. > please let me know, I will add correction-patch for this. > > Thanks, > Jagan. > >> + .name = "W25Q32DW", >> + }, >> + { >> .id = 0x6017, >> .nr_blocks = 128, >> .name = "W25Q64DW", >> -- >> 1.7.10.4 >> >> _______________________________________________ >> U-Boot mailing list >> U-Boot@lists.denx.de >> http://lists.denx.de/mailman/listinfo/u-boot
On Fri, May 24, 2013 at 01:39:51PM -0700, Jagan Teki wrote: > Hi, > > Any update on this. > > Thanks, > Jagan. > > On Thu, May 23, 2013 at 1:15 PM, Jagan Teki <jagannadh.teki@gmail.com> wrote: > > Hi Allen, > > > > On Sun, Mar 17, 2013 at 10:28 AM, Allen Martin <amartin@nvidia.com> wrote: > >> Add support for Winbond W25Q32DW 32Mbit part > >> > >> Signed-off-by: Allen Martin <amartin@nvidia.com> > >> --- > >> drivers/mtd/spi/winbond.c | 5 +++++ > >> 1 file changed, 5 insertions(+) > >> > >> diff --git a/drivers/mtd/spi/winbond.c b/drivers/mtd/spi/winbond.c > >> index 4418302..3560fcb 100644 > >> --- a/drivers/mtd/spi/winbond.c > >> +++ b/drivers/mtd/spi/winbond.c > >> @@ -68,6 +68,11 @@ static const struct winbond_spi_flash_params winbond_spi_flash_table[] = { > >> .name = "W25Q80", > >> }, > >> { > >> + .id = 0x6016, > >> + .nr_blocks = 512, > > > > nr_blocks here should have 64 instead of 512. > > please let me know, I will add correction-patch for this. You're right, it's a 32Mbit part, so nr_blocks should be 64, thanks for finding this. -Allen
On Wed, May 29, 2013 at 5:58 AM, Allen Martin <amartin@nvidia.com> wrote: > On Fri, May 24, 2013 at 01:39:51PM -0700, Jagan Teki wrote: >> Hi, >> >> Any update on this. >> >> Thanks, >> Jagan. >> >> On Thu, May 23, 2013 at 1:15 PM, Jagan Teki <jagannadh.teki@gmail.com> wrote: >> > Hi Allen, >> > >> > On Sun, Mar 17, 2013 at 10:28 AM, Allen Martin <amartin@nvidia.com> wrote: >> >> Add support for Winbond W25Q32DW 32Mbit part >> >> >> >> Signed-off-by: Allen Martin <amartin@nvidia.com> >> >> --- >> >> drivers/mtd/spi/winbond.c | 5 +++++ >> >> 1 file changed, 5 insertions(+) >> >> >> >> diff --git a/drivers/mtd/spi/winbond.c b/drivers/mtd/spi/winbond.c >> >> index 4418302..3560fcb 100644 >> >> --- a/drivers/mtd/spi/winbond.c >> >> +++ b/drivers/mtd/spi/winbond.c >> >> @@ -68,6 +68,11 @@ static const struct winbond_spi_flash_params winbond_spi_flash_table[] = { >> >> .name = "W25Q80", >> >> }, >> >> { >> >> + .id = 0x6016, >> >> + .nr_blocks = 512, >> > >> > nr_blocks here should have 64 instead of 512. >> > please let me know, I will add correction-patch for this. > > You're right, it's a 32Mbit part, so nr_blocks should be 64, thanks > for finding this. Thanks for your response. I just updated on the patch http://patchwork.ozlabs.org/patch/246654/ Please let me know for any issues. -- Thanks, Jagan.
diff --git a/drivers/mtd/spi/winbond.c b/drivers/mtd/spi/winbond.c index 4418302..3560fcb 100644 --- a/drivers/mtd/spi/winbond.c +++ b/drivers/mtd/spi/winbond.c @@ -68,6 +68,11 @@ static const struct winbond_spi_flash_params winbond_spi_flash_table[] = { .name = "W25Q80", }, { + .id = 0x6016, + .nr_blocks = 512, + .name = "W25Q32DW", + }, + { .id = 0x6017, .nr_blocks = 128, .name = "W25Q64DW",
Add support for Winbond W25Q32DW 32Mbit part Signed-off-by: Allen Martin <amartin@nvidia.com> --- drivers/mtd/spi/winbond.c | 5 +++++ 1 file changed, 5 insertions(+)