Patchwork C++ PATCH for DR 657 (abstract classes and sfinae)

login
register
mail settings
Submitter Jason Merrill
Date March 16, 2013, 7:35 p.m.
Message ID <5144C98F.7050704@redhat.com>
Download mbox | patch
Permalink /patch/228246/
State New
Headers show

Comments

Jason Merrill - March 16, 2013, 7:35 p.m.
Trying to use an abstract class as a return or parameter type causes a 
deduction failure.

Tested x86_64-pc-linux-gnu, applying to trunk.

Patch

commit 0e6294b17c0e992131701bdc0b71cf6903e09c64
Author: Jason Merrill <jason@redhat.com>
Date:   Wed Feb 27 10:54:55 2013 -0500

    	DR 657
    	* pt.c (tsubst_function_type): Call abstract_virtuals_error_sfinae.
    	(tsubst_arg_types): Likewise.

diff --git a/gcc/cp/pt.c b/gcc/cp/pt.c
index c07ed32..cad1c60 100644
--- a/gcc/cp/pt.c
+++ b/gcc/cp/pt.c
@@ -10850,6 +10850,9 @@  tsubst_arg_types (tree arg_types,
           }
         return error_mark_node;
     }
+    /* DR 657. */
+    if (abstract_virtuals_error_sfinae (NULL_TREE, type, complain))
+      return error_mark_node;
     
     /* Do array-to-pointer, function-to-pointer conversion, and ignore
        top-level qualifiers as required.  */
@@ -10912,10 +10915,8 @@  tsubst_function_type (tree t,
   return_type = tsubst (TREE_TYPE (t), args, complain, in_decl);
   if (return_type == error_mark_node)
     return error_mark_node;
-  /* The standard does not presently indicate that creation of a
-     function type with an invalid return type is a deduction failure.
-     However, that is clearly analogous to creating an array of "void"
-     or a reference to a reference.  This is core issue #486.  */
+  /* DR 486 clarifies that creation of a function type with an
+     invalid return type is a deduction failure.  */
   if (TREE_CODE (return_type) == ARRAY_TYPE
       || TREE_CODE (return_type) == FUNCTION_TYPE)
     {
@@ -10928,6 +10929,9 @@  tsubst_function_type (tree t,
 	}
       return error_mark_node;
     }
+  /* And DR 657. */
+  if (abstract_virtuals_error_sfinae (NULL_TREE, return_type, complain))
+    return error_mark_node;
 
   /* Substitute the argument types.  */
   arg_types = tsubst_arg_types (TYPE_ARG_TYPES (t), args, NULL_TREE,
diff --git a/gcc/testsuite/g++.dg/template/sfinae-dr657.C b/gcc/testsuite/g++.dg/template/sfinae-dr657.C
new file mode 100644
index 0000000..b78b5a9
--- /dev/null
+++ b/gcc/testsuite/g++.dg/template/sfinae-dr657.C
@@ -0,0 +1,22 @@ 
+// DR 657
+// Test that a return or parameter type with abstract class type causes a
+// deduction failure.
+
+struct A
+{
+  A();
+  A(int);
+  virtual void f() = 0;
+};
+
+template<class T> T declval();
+template<class T> int declval(...);
+
+template<class T> void arg(T);
+template<class T> int arg(...);
+
+int main()
+{
+  int i = declval<A>();
+  i = arg<A>(1);
+}