Patchwork sfc: make local functions static

login
register
mail settings
Submitter stephen hemminger
Date March 16, 2013, 4:57 p.m.
Message ID <20130316095751.33087a2b@nehalam.linuxnetplumber.net>
Download mbox | patch
Permalink /patch/228229/
State Accepted
Delegated to: David Miller
Headers show

Comments

stephen hemminger - March 16, 2013, 4:57 p.m.
Trivial sparse detected functions that should be static.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - March 17, 2013, 6:26 p.m.
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Sat, 16 Mar 2013 09:57:51 -0700

> Trivial sparse detected functions that should be static.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Applied, thanks Stephen.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Ben Hutchings - March 18, 2013, 3:33 p.m.
On Sun, 2013-03-17 at 14:26 -0400, David Miller wrote:
> From: Stephen Hemminger <stephen@networkplumber.org>
> Date: Sat, 16 Mar 2013 09:57:51 -0700
> 
> > Trivial sparse detected functions that should be static.
> > 
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> 
> Applied, thanks Stephen.

Thanks.

Ben.

Patch

--- a/drivers/net/ethernet/sfc/efx.c	2013-03-14 14:22:58.139958231 -0700
+++ b/drivers/net/ethernet/sfc/efx.c	2013-03-16 09:47:09.417612586 -0700
@@ -2950,8 +2950,8 @@  static const struct dev_pm_ops efx_pm_op
  * At this point MMIO and DMA may be disabled.
  * Stop the software path and request a slot reset.
  */
-pci_ers_result_t efx_io_error_detected(struct pci_dev *pdev,
-				       enum pci_channel_state state)
+static pci_ers_result_t efx_io_error_detected(struct pci_dev *pdev,
+					      enum pci_channel_state state)
 {
 	pci_ers_result_t status = PCI_ERS_RESULT_RECOVERED;
 	struct efx_nic *efx = pci_get_drvdata(pdev);
@@ -2986,7 +2986,7 @@  pci_ers_result_t efx_io_error_detected(s
 }
 
 /* Fake a successfull reset, which will be performed later in efx_io_resume. */
-pci_ers_result_t efx_io_slot_reset(struct pci_dev *pdev)
+static pci_ers_result_t efx_io_slot_reset(struct pci_dev *pdev)
 {
 	struct efx_nic *efx = pci_get_drvdata(pdev);
 	pci_ers_result_t status = PCI_ERS_RESULT_RECOVERED;
--- a/drivers/net/ethernet/sfc/rx.c	2013-03-14 14:22:58.143958179 -0700
+++ b/drivers/net/ethernet/sfc/rx.c	2013-03-16 09:47:24.645415645 -0700
@@ -666,8 +666,8 @@  int efx_probe_rx_queue(struct efx_rx_que
 	return rc;
 }
 
-void efx_init_rx_recycle_ring(struct efx_nic *efx,
-			      struct efx_rx_queue *rx_queue)
+static void efx_init_rx_recycle_ring(struct efx_nic *efx,
+				     struct efx_rx_queue *rx_queue)
 {
 	unsigned int bufs_in_recycle_ring, page_ring_size;