From patchwork Fri Mar 15 23:24:05 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 228196 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 39B4A2C00A1 for ; Sat, 16 Mar 2013 10:53:36 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 2D8EB4A156; Sat, 16 Mar 2013 00:53:33 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AnktZjm1PjfP; Sat, 16 Mar 2013 00:53:32 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 221834A155; Sat, 16 Mar 2013 00:53:31 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 18E6A4A155 for ; Sat, 16 Mar 2013 00:53:29 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id S9sFA3ZlWOhn for ; Sat, 16 Mar 2013 00:53:28 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-qe0-f74.google.com (mail-qe0-f74.google.com [209.85.128.74]) by theia.denx.de (Postfix) with ESMTPS id 1A5254A154 for ; Sat, 16 Mar 2013 00:53:26 +0100 (CET) Received: by mail-qe0-f74.google.com with SMTP id 9so395702qea.1 for ; Fri, 15 Mar 2013 16:53:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state; bh=Hvb5c6xXpsfotJ1sTePGF0c7vgextIPlYvsjb657FWY=; b=GPUVk6Sf2q10kKTm7gZzFd//ZR3XJB5+wnsgsegYZZkvnjqAbz4hUGA3kavlj1UWWk zL2sAPvJVRRDyN5k9qjfJqM0Nbroo2dOevmEegJ+0tv5+ldxihYKD26dO68IwOYdawiy IL4Bc4w9vYElCm7MfR6O3pxhA5VnVmwLixMLkETFSpgLAwY/lXTD7nmx9Qhp59wZehtG rYD1YQG+aUq+2FXWnIohY1X2Jj1aVewFWwsQx7fYNAR0vamTnSSeA7HqehmoHiScyx69 JxXJI3+/gWk/h9yKyHPakE2TkmE7xcf5/KeroPLOzftVUwbXKANW1wHFo2GCdqi6tgUF WURQ== X-Received: by 10.58.23.137 with SMTP id m9mr5198249vef.19.1363389857465; Fri, 15 Mar 2013 16:24:17 -0700 (PDT) Received: from corp2gmr1-1.hot.corp.google.com (corp2gmr1-1.hot.corp.google.com [172.24.189.92]) by gmr-mx.google.com with ESMTPS id i65si981701yhh.5.2013.03.15.16.24.17 (version=TLSv1.1 cipher=AES128-SHA bits=128/128); Fri, 15 Mar 2013 16:24:17 -0700 (PDT) Received: from tictac.mtv.corp.google.com (tictac.mtv.corp.google.com [172.22.73.80]) by corp2gmr1-1.hot.corp.google.com (Postfix) with ESMTP id 4E9CC31C123; Fri, 15 Mar 2013 16:24:17 -0700 (PDT) Received: by tictac.mtv.corp.google.com (Postfix, from userid 121310) id DF790805ED; Fri, 15 Mar 2013 16:24:16 -0700 (PDT) From: Doug Anderson To: Simon Glass Date: Fri, 15 Mar 2013 16:24:05 -0700 Message-Id: <1363389845-23367-1-git-send-email-dianders@chromium.org> X-Mailer: git-send-email 1.8.1.3 X-Gm-Message-State: ALoCoQlYWIem7t7Doefw6RMXiNseuPOATakcPvvzFBAawft0EV8RCg6YsBrFfZwdp4LKn3/aCU4O7bjsooO/uI9int5544U8BXBoOF986AXy+y+dTU+N++A55PywEtQDvxBx/yzJt/m9U11q/YFqGLO9Lm/TPkBFigiqqDhqr7+Kbqz7vmJYi6rkvFpud4h7hTmVgvHseA7B Cc: Tom Rini , u-boot@lists.denx.de Subject: [U-Boot] [PATCH] patman: Make "Reviewed-by" an important tag X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de Although "Reviewed-by:" is a tag that gerrit adds, it's also a tag used by upstream. Stripping it is undesirable. In fact, we should treat it as important. Signed-off-by: Doug Anderson Reviewed-by: Otavio Salvador Acked-by: Simon Glass --- tools/patman/README | 4 ++-- tools/patman/patchstream.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/patman/README b/tools/patman/README index 1832ebd..86d366f 100644 --- a/tools/patman/README +++ b/tools/patman/README @@ -198,8 +198,9 @@ END override the default signoff that patman automatically adds. Tested-by: Their Name + Reviewed-by: Their Name Acked-by: Their Name - These indicate that someone has acked or tested your patch. + These indicate that someone has tested/reviewed/acked your patch. When you get this reply on the mailing list, you can add this tag to the relevant commit and the script will include it when you send out the next version. If 'Tested-by:' is set to @@ -231,7 +232,6 @@ TEST=... Change-Id: Review URL: Reviewed-on: -Reviewed-by: Exercise for the reader: Try adding some tags to one of your current diff --git a/tools/patman/patchstream.py b/tools/patman/patchstream.py index f7ee75a..4ff6ce7 100644 --- a/tools/patman/patchstream.py +++ b/tools/patman/patchstream.py @@ -31,7 +31,7 @@ from series import Series # Tags that we detect and remove re_remove = re.compile('^BUG=|^TEST=|^BRANCH=|^Change-Id:|^Review URL:' - '|Reviewed-on:|Reviewed-by:|Commit-Ready:') + '|Reviewed-on:|Commit-Ready:') # Lines which are allowed after a TEST= line re_allowed_after_test = re.compile('^Signed-off-by:') @@ -46,7 +46,7 @@ re_cover = re.compile('^Cover-letter:') re_series = re.compile('^Series-(\w*): *(.*)') # Commit tags that we want to collect and keep -re_tag = re.compile('^(Tested-by|Acked-by|Cc): (.*)') +re_tag = re.compile('^(Tested-by|Acked-by|Reviewed-by|Cc): (.*)') # The start of a new commit in the git log re_commit = re.compile('^commit (.*)')