Patchwork [U-Boot] patman: Make "Reviewed-by" an important tag

login
register
mail settings
Submitter Doug Anderson
Date March 15, 2013, 11:24 p.m.
Message ID <1363389845-23367-1-git-send-email-dianders@chromium.org>
Download mbox | patch
Permalink /patch/228196/
State Accepted, archived
Delegated to: Simon Glass
Headers show

Comments

Doug Anderson - March 15, 2013, 11:24 p.m.
Although "Reviewed-by:" is a tag that gerrit adds, it's also a tag
used by upstream.  Stripping it is undesirable.  In fact, we should
treat it as important.

Signed-off-by: Doug Anderson <dianders@chromium.org>
---
 tools/patman/README         | 4 ++--
 tools/patman/patchstream.py | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
Otavio Salvador - March 16, 2013, 2:48 p.m.
On Fri, Mar 15, 2013 at 8:24 PM, Doug Anderson <dianders@chromium.org> wrote:
> Although "Reviewed-by:" is a tag that gerrit adds, it's also a tag
> used by upstream.  Stripping it is undesirable.  In fact, we should
> treat it as important.
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>

Reviewed-by: Otavio Salvador <otavio@ossystems.com.br>

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
Simon Glass - March 16, 2013, 10:22 p.m.
On Fri, Mar 15, 2013 at 4:24 PM, Doug Anderson <dianders@chromium.org> wrote:
> Although "Reviewed-by:" is a tag that gerrit adds, it's also a tag
> used by upstream.  Stripping it is undesirable.  In fact, we should
> treat it as important.
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>

Acked-by: Simon Glass <sjg@chromium.org>

Patch

diff --git a/tools/patman/README b/tools/patman/README
index 1832ebd..86d366f 100644
--- a/tools/patman/README
+++ b/tools/patman/README
@@ -198,8 +198,9 @@  END
 	override the default signoff that patman automatically adds.
 
  Tested-by: Their Name <email>
+ Reviewed-by: Their Name <email>
  Acked-by: Their Name <email>
-	These indicate that someone has acked or tested your patch.
+	These indicate that someone has tested/reviewed/acked your patch.
 	When you get this reply on the mailing list, you can add this
 	tag to the relevant commit and the script will include it when
 	you send out the next version. If 'Tested-by:' is set to
@@ -231,7 +232,6 @@  TEST=...
 Change-Id:
 Review URL:
 Reviewed-on:
-Reviewed-by:
 
 
 Exercise for the reader: Try adding some tags to one of your current
diff --git a/tools/patman/patchstream.py b/tools/patman/patchstream.py
index f7ee75a..4ff6ce7 100644
--- a/tools/patman/patchstream.py
+++ b/tools/patman/patchstream.py
@@ -31,7 +31,7 @@  from series import Series
 
 # Tags that we detect and remove
 re_remove = re.compile('^BUG=|^TEST=|^BRANCH=|^Change-Id:|^Review URL:'
-    '|Reviewed-on:|Reviewed-by:|Commit-Ready:')
+    '|Reviewed-on:|Commit-Ready:')
 
 # Lines which are allowed after a TEST= line
 re_allowed_after_test = re.compile('^Signed-off-by:')
@@ -46,7 +46,7 @@  re_cover = re.compile('^Cover-letter:')
 re_series = re.compile('^Series-(\w*): *(.*)')
 
 # Commit tags that we want to collect and keep
-re_tag = re.compile('^(Tested-by|Acked-by|Cc): (.*)')
+re_tag = re.compile('^(Tested-by|Acked-by|Reviewed-by|Cc): (.*)')
 
 # The start of a new commit in the git log
 re_commit = re.compile('^commit (.*)')