Patchwork [2/2] qga schema: document generic QERR_UNSUPPORTED

login
register
mail settings
Submitter Laszlo Ersek
Date March 15, 2013, 6:07 p.m.
Message ID <1363370871-10537-3-git-send-email-lersek@redhat.com>
Download mbox | patch
Permalink /patch/228130/
State New
Headers show

Comments

Laszlo Ersek - March 15, 2013, 6:07 p.m.
Part of the wording was shamelessly stolen from Michael Roth's email.

Suggested-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 qga/qapi-schema.json |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)
Michael Roth - March 15, 2013, 6:36 p.m.
On Fri, Mar 15, 2013 at 07:07:51PM +0100, Laszlo Ersek wrote:
> Part of the wording was shamelessly stolen from Michael Roth's email.

:)

series:

Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>

> 
> Suggested-by: Michael Roth <mdroth@linux.vnet.ibm.com>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  qga/qapi-schema.json |   11 +++++++++++
>  1 files changed, 11 insertions(+), 0 deletions(-)
> 
> diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
> index 2af3515..7155b7a 100644
> --- a/qga/qapi-schema.json
> +++ b/qga/qapi-schema.json
> @@ -2,6 +2,17 @@
> 
>  ##
>  #
> +# General note concerning the use of guest agent interfaces:
> +#
> +# "unsupported" is a higher-level error than the errors that individual
> +# commands might document. The caller should always be prepared to receive
> +# QERR_UNSUPPORTED, even if the given command doesn't specify it, or doesn't
> +# document any failure mode at all.
> +#
> +##
> +
> +##
> +#
>  # Echo back a unique integer value, and prepend to response a
>  # leading sentinel byte (0xFF) the client can check scan for.
>  #
> -- 
> 1.7.1
>

Patch

diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
index 2af3515..7155b7a 100644
--- a/qga/qapi-schema.json
+++ b/qga/qapi-schema.json
@@ -2,6 +2,17 @@ 
 
 ##
 #
+# General note concerning the use of guest agent interfaces:
+#
+# "unsupported" is a higher-level error than the errors that individual
+# commands might document. The caller should always be prepared to receive
+# QERR_UNSUPPORTED, even if the given command doesn't specify it, or doesn't
+# document any failure mode at all.
+#
+##
+
+##
+#
 # Echo back a unique integer value, and prepend to response a
 # leading sentinel byte (0xFF) the client can check scan for.
 #