Patchwork net core: optimize netdev_create_hash()

login
register
mail settings
Submitter Wei Yang
Date March 15, 2013, 4:32 p.m.
Message ID <1363365131-7906-1-git-send-email-weiyang@linux.vnet.ibm.com>
Download mbox | patch
Permalink /patch/228088/
State Rejected
Delegated to: David Miller
Headers show

Comments

Wei Yang - March 15, 2013, 4:32 p.m.
netdev_create_hash() is divded into two steps:
1. allocate space for hash_head
2. initialize hash_head->first to NULL for each hash_head

This patch merge the two steps into one step.

When allocating the space for hash_head, it will use kzalloc() instead of
kmalloc(). Then hash_head->first is set to NULL during the allocation step,
which means it is not necessary to call INIT_HLIST_HEAD() for each hash_head.

This will:
1. reduce the code size
2. reduce the run time of iteration on initializing hash_head array
---
 net/core/dev.c |   12 +++++++-----
 1 files changed, 7 insertions(+), 5 deletions(-)
David Miller - March 15, 2013, 9:39 p.m.
From: Wei Yang <weiyang@linux.vnet.ibm.com>
Date: Sat, 16 Mar 2013 00:32:11 +0800

> netdev_create_hash() is divded into two steps:
> 1. allocate space for hash_head
> 2. initialize hash_head->first to NULL for each hash_head
> 
> This patch merge the two steps into one step.
> 
> When allocating the space for hash_head, it will use kzalloc() instead of
> kmalloc(). Then hash_head->first is set to NULL during the allocation step,
> which means it is not necessary to call INIT_HLIST_HEAD() for each hash_head.
> 
> This will:
> 1. reduce the code size
> 2. reduce the run time of iteration on initializing hash_head array

Please do not ever post changes like this.

This makes assumtions about the list head implementation that
we should not make.  If someone adds a debugging facility that
causes lists to be initialized differently, it will be broken
for this hash table now.

The reason the abstractions exist is so that people do not
do things like you are trying to do.

If you want to add an interface in the generic list facilities which
performs this simplifcation, fine.  Implement it and post such a
suggestion to linux-kernel, and then once such a facility is present
in Linus's tree we can start using it in the networkng code.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Wei Yang - March 16, 2013, 1:19 a.m.
[resend for syntax error in Message-ID]

David, 

Thanks for pointing out the error, it really helps.

I guess last mail is still blocked by the mail server, so I resend it.
Hope it works now.

On Sat, Mar 16, 2013 at 08:00:51AM +0800, Wei Yang wrote:
On Fri, Mar 15, 2013 at 05:39:30PM -0400, David Miller wrote:
>From: Wei Yang <weiyang@linux.vnet.ibm.com>
>Date: Sat, 16 Mar 2013 00:32:11 +0800
>
>> netdev_create_hash() is divded into two steps:
>> 1. allocate space for hash_head
>> 2. initialize hash_head->first to NULL for each hash_head
>> 
>> This patch merge the two steps into one step.
>> 
>> When allocating the space for hash_head, it will use kzalloc() instead of
>> kmalloc(). Then hash_head->first is set to NULL during the allocation step,
>> which means it is not necessary to call INIT_HLIST_HEAD() for each hash_head.
>> 
>> This will:
>> 1. reduce the code size
>> 2. reduce the run time of iteration on initializing hash_head array
>
>Please do not ever post changes like this.
>
>This makes assumtions about the list head implementation that
>we should not make.  If someone adds a debugging facility that
>causes lists to be initialized differently, it will be broken
>for this hash table now.

Yes, this is based on the assumtion. 
And agree, this will break the behavior.

>
>The reason the abstractions exist is so that people do not
>do things like you are trying to do.
>
>If you want to add an interface in the generic list facilities which
>performs this simplifcation, fine.  Implement it and post such a
>suggestion to linux-kernel, and then once such a facility is present
>in Linus's tree we can start using it in the networkng code.

Thanks for your suggestion and kindness.

Patch

diff --git a/net/core/dev.c b/net/core/dev.c
index f64e439..79f0666 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -6564,13 +6564,15 @@  EXPORT_SYMBOL(netdev_increment_features);
 
 static struct hlist_head *netdev_create_hash(void)
 {
-	int i;
 	struct hlist_head *hash;
 
-	hash = kmalloc(sizeof(*hash) * NETDEV_HASHENTRIES, GFP_KERNEL);
-	if (hash != NULL)
-		for (i = 0; i < NETDEV_HASHENTRIES; i++)
-			INIT_HLIST_HEAD(&hash[i]);
+	hash = kzalloc(sizeof(*hash) * NETDEV_HASHENTRIES, GFP_KERNEL);
+
+	/*
+	 * hash[i]->first is set to NULL in kzalloc()
+	 *
+	 * INIT_HLIST_HEAD(&hash[i]) is not necessary now
+	 */
 
 	return hash;
 }