Patchwork [14/28] qcow2: drop unnecessary flush in qcow2_update_snapshot_refcount()

login
register
mail settings
Submitter Stefan Hajnoczi
Date March 15, 2013, 3:14 p.m.
Message ID <1363360465-5247-15-git-send-email-stefanha@redhat.com>
Download mbox | patch
Permalink /patch/228056/
State New
Headers show

Comments

Stefan Hajnoczi - March 15, 2013, 3:14 p.m.
We already flush when the function completes.  There is no need to flush
after every compressed cluster.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 block/qcow2-refcount.c | 4 ----
 1 file changed, 4 deletions(-)

Patch

diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
index 92519ea..9bfb390 100644
--- a/block/qcow2-refcount.c
+++ b/block/qcow2-refcount.c
@@ -790,10 +790,6 @@  int qcow2_update_snapshot_refcount(BlockDriverState *bs,
                             if (ret < 0) {
                                 goto fail;
                             }
-
-                            /* TODO Flushing once for the whole function should
-                             * be enough */
-                            bdrv_flush(bs->file);
                         }
                         /* compressed clusters are never modified */
                         refcount = 2;