Patchwork usb-redir: Fix crash on migration with no client connected

login
register
mail settings
Submitter Hans de Goede
Date March 15, 2013, 10:52 a.m.
Message ID <1363344757-11149-1-git-send-email-hdegoede@redhat.com>
Download mbox | patch
Permalink /patch/227954/
State New
Headers show

Comments

Hans de Goede - March 15, 2013, 10:52 a.m.
If no client is connected on the src side, then we won't receive a
parser during migrate, in this case usbredir_post_load() should be a nop,
rather then to try to derefefence the NULL dev->parser pointer.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 hw/usb/redirect.c | 4 ++++
 1 file changed, 4 insertions(+)

Patch

diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c
index 9ba714d..06d22da 100644
--- a/hw/usb/redirect.c
+++ b/hw/usb/redirect.c
@@ -2005,6 +2005,10 @@  static int usbredir_post_load(void *priv, int version_id)
 {
     USBRedirDevice *dev = priv;
 
+    if (dev->parser == NULL) {
+        return 0;
+    }
+
     switch (dev->device_info.speed) {
     case usb_redir_speed_low:
         dev->dev.speed = USB_SPEED_LOW;