Patchwork [U-Boot,1/4,V3] EXYNOS5: FDT: Add compatible strings for Serial

login
register
mail settings
Submitter Rajeshwari Birje
Date March 15, 2013, 10:38 a.m.
Message ID <1363343929-6190-2-git-send-email-rajeshwari.s@samsung.com>
Download mbox | patch
Permalink /patch/227952/
State Changes Requested
Delegated to: Minkyu Kang
Headers show

Comments

Rajeshwari Birje - March 15, 2013, 10:38 a.m.
Add required compatible information for s5p serial driver

Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
Acked-by: Simon Glass <sjg@chromium.org>
---
Changes in V2:
        - Changed the compatible string to "samsung,exynos4210-uart"
Chnages in V3:
	- Rebased on latest u-boot-samsung
 include/fdtdec.h |    1 +
 lib/fdtdec.c     |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)
Minkyu Kang - March 29, 2013, 6:14 a.m.
Dear Rajeshwari Shinde,

On 15/03/13 19:38, Rajeshwari Shinde wrote:
> Add required compatible information for s5p serial driver
> 
> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
> Acked-by: Simon Glass <sjg@chromium.org>
> ---
> Changes in V2:
>         - Changed the compatible string to "samsung,exynos4210-uart"
> Chnages in V3:
> 	- Rebased on latest u-boot-samsung
>  include/fdtdec.h |    1 +
>  lib/fdtdec.c     |    1 +
>  2 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/include/fdtdec.h b/include/fdtdec.h
> index 6552942..9f9cb4f 100644
> --- a/include/fdtdec.h
> +++ b/include/fdtdec.h
> @@ -83,6 +83,7 @@ enum fdt_compat_id {
>  	COMPAT_SAMSUNG_EXYNOS_TMU,	/* Exynos TMU */
>  	COMPAT_MAXIM_MAX77686_PMIC,	/* MAX77686 PMIC */
>  	COMPAT_MAXIM_98095_CODEC,	/* MAX98095 Codec */
> +	COMPAT_SAMSUNG_EXYNOS5_SERIAL,	/* Exynos5 UART */

Is it exynos5 only?
I think, we can use it to all of exynos series.

>  
>  	COMPAT_COUNT,
>  };
> diff --git a/lib/fdtdec.c b/lib/fdtdec.c
> index 88f6b68..ee98e0e 100644
> --- a/lib/fdtdec.c
> +++ b/lib/fdtdec.c
> @@ -58,6 +58,7 @@ static const char * const compat_names[COMPAT_COUNT] = {
>  	COMPAT(SAMSUNG_EXYNOS_TMU, "samsung,exynos-tmu"),
>  	COMPAT(MAXIM_MAX77686_PMIC, "maxim,max77686_pmic"),
>  	COMPAT(MAXIM_98095_CODEC, "maxim,max98095-codec"),
> +	COMPAT(SAMSUNG_EXYNOS5_SERIAL, "samsung,exynos4210-uart"),
>  };
>  
>  const char *fdtdec_get_compatible(enum fdt_compat_id id)
> 

Thanks,
Minkyu Kang.
Rajeshwari Birje - April 2, 2013, 5:19 a.m.
Hi Minkyu Kang,

Thank you for comment

On Fri, Mar 29, 2013 at 11:44 AM, Minkyu Kang <mk7.kang@samsung.com> wrote:
> Dear Rajeshwari Shinde,
>
> On 15/03/13 19:38, Rajeshwari Shinde wrote:
>> Add required compatible information for s5p serial driver
>>
>> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
>> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
>> Acked-by: Simon Glass <sjg@chromium.org>
>> ---
>> Changes in V2:
>>         - Changed the compatible string to "samsung,exynos4210-uart"
>> Chnages in V3:
>>       - Rebased on latest u-boot-samsung
>>  include/fdtdec.h |    1 +
>>  lib/fdtdec.c     |    1 +
>>  2 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/include/fdtdec.h b/include/fdtdec.h
>> index 6552942..9f9cb4f 100644
>> --- a/include/fdtdec.h
>> +++ b/include/fdtdec.h
>> @@ -83,6 +83,7 @@ enum fdt_compat_id {
>>       COMPAT_SAMSUNG_EXYNOS_TMU,      /* Exynos TMU */
>>       COMPAT_MAXIM_MAX77686_PMIC,     /* MAX77686 PMIC */
>>       COMPAT_MAXIM_98095_CODEC,       /* MAX98095 Codec */
>> +     COMPAT_SAMSUNG_EXYNOS5_SERIAL,  /* Exynos5 UART */
>
> Is it exynos5 only?
> I think, we can use it to all of exynos series.
Will correct the same to  COMPAT_SAMSUNG_EXYNOS_SERIAL and resend the patch.
>
>>
>>       COMPAT_COUNT,
>>  };
>> diff --git a/lib/fdtdec.c b/lib/fdtdec.c
>> index 88f6b68..ee98e0e 100644
>> --- a/lib/fdtdec.c
>> +++ b/lib/fdtdec.c
>> @@ -58,6 +58,7 @@ static const char * const compat_names[COMPAT_COUNT] = {
>>       COMPAT(SAMSUNG_EXYNOS_TMU, "samsung,exynos-tmu"),
>>       COMPAT(MAXIM_MAX77686_PMIC, "maxim,max77686_pmic"),
>>       COMPAT(MAXIM_98095_CODEC, "maxim,max98095-codec"),
>> +     COMPAT(SAMSUNG_EXYNOS5_SERIAL, "samsung,exynos4210-uart"),
>>  };
>>
>>  const char *fdtdec_get_compatible(enum fdt_compat_id id)
>>
>
> Thanks,
> Minkyu Kang.
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

Patch

diff --git a/include/fdtdec.h b/include/fdtdec.h
index 6552942..9f9cb4f 100644
--- a/include/fdtdec.h
+++ b/include/fdtdec.h
@@ -83,6 +83,7 @@  enum fdt_compat_id {
 	COMPAT_SAMSUNG_EXYNOS_TMU,	/* Exynos TMU */
 	COMPAT_MAXIM_MAX77686_PMIC,	/* MAX77686 PMIC */
 	COMPAT_MAXIM_98095_CODEC,	/* MAX98095 Codec */
+	COMPAT_SAMSUNG_EXYNOS5_SERIAL,	/* Exynos5 UART */
 
 	COMPAT_COUNT,
 };
diff --git a/lib/fdtdec.c b/lib/fdtdec.c
index 88f6b68..ee98e0e 100644
--- a/lib/fdtdec.c
+++ b/lib/fdtdec.c
@@ -58,6 +58,7 @@  static const char * const compat_names[COMPAT_COUNT] = {
 	COMPAT(SAMSUNG_EXYNOS_TMU, "samsung,exynos-tmu"),
 	COMPAT(MAXIM_MAX77686_PMIC, "maxim,max77686_pmic"),
 	COMPAT(MAXIM_98095_CODEC, "maxim,max98095-codec"),
+	COMPAT(SAMSUNG_EXYNOS5_SERIAL, "samsung,exynos4210-uart"),
 };
 
 const char *fdtdec_get_compatible(enum fdt_compat_id id)