Patchwork [net,2/6] openvswitch: Fix ovs_vport_cmd_new return value on success

login
register
mail settings
Submitter Jesse Gross
Date March 15, 2013, 12:15 a.m.
Message ID <1363306506-885-3-git-send-email-jesse@nicira.com>
Download mbox | patch
Permalink /patch/227832/
State Accepted
Delegated to: David Miller
Headers show

Comments

Jesse Gross - March 15, 2013, 12:15 a.m.
From: Rich Lane <rlane@bigswitch.com>

If the pointer does not represent an error then the PTR_ERR
macro may still return a nonzero value.

Signed-off-by: Rich Lane <rlane@bigswitch.com>
Signed-off-by: Jesse Gross <jesse@nicira.com>
---
 net/openvswitch/datapath.c |    1 +
 1 file changed, 1 insertion(+)

Patch

diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c
index 5e275b9..a2cd3e6 100644
--- a/net/openvswitch/datapath.c
+++ b/net/openvswitch/datapath.c
@@ -1691,6 +1691,7 @@  static int ovs_vport_cmd_new(struct sk_buff *skb, struct genl_info *info)
 	if (IS_ERR(vport))
 		goto exit_unlock;
 
+	err = 0;
 	reply = ovs_vport_cmd_build_info(vport, info->snd_portid, info->snd_seq,
 					 OVS_VPORT_CMD_NEW);
 	if (IS_ERR(reply)) {