Patchwork qemu-iotests: use -nographic in test case 007

login
register
mail settings
Submitter Stefan Hajnoczi
Date March 14, 2013, 4:06 p.m.
Message ID <1363277215-26776-1-git-send-email-stefanha@redhat.com>
Download mbox | patch
Permalink /patch/227732/
State New
Headers show

Comments

Stefan Hajnoczi - March 14, 2013, 4:06 p.m.
A comment explains that -nographic hangs test case 007.  This is no
longer the case so add -nographic.  This makes the test suite faster and
more pleasant to run since no windows pop up.

I am not sure exactly when -nographic starting working for this case but
there is no fundamental reason why graphics are needed here.  Make sure
the serial port is not on stdio, it would conflict with the monitor.

Also remove unnecessary trailing whitespace on these lines.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 tests/qemu-iotests/007 | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
Kevin Wolf - March 15, 2013, 8:31 a.m.
Am 14.03.2013 um 17:06 hat Stefan Hajnoczi geschrieben:
> A comment explains that -nographic hangs test case 007.  This is no
> longer the case so add -nographic.  This makes the test suite faster and
> more pleasant to run since no windows pop up.
> 
> I am not sure exactly when -nographic starting working for this case but
> there is no fundamental reason why graphics are needed here.  Make sure
> the serial port is not on stdio, it would conflict with the monitor.
> 
> Also remove unnecessary trailing whitespace on these lines.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>

This doesn't really make a difference for the speed on my laptop, but
it works and is definitely nicer. On my virtlab test box I noticed that
only this really enables the test. Before, it was complaining to
/dev/null that it couldn't open the display...

Tested-by: Kevin Wolf <kwolf@redhat.com>
Stefan Hajnoczi - March 15, 2013, 10:02 a.m.
On Thu, Mar 14, 2013 at 05:06:55PM +0100, Stefan Hajnoczi wrote:
> A comment explains that -nographic hangs test case 007.  This is no
> longer the case so add -nographic.  This makes the test suite faster and
> more pleasant to run since no windows pop up.
> 
> I am not sure exactly when -nographic starting working for this case but
> there is no fundamental reason why graphics are needed here.  Make sure
> the serial port is not on stdio, it would conflict with the monitor.
> 
> Also remove unnecessary trailing whitespace on these lines.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  tests/qemu-iotests/007 | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)

Applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan

Patch

diff --git a/tests/qemu-iotests/007 b/tests/qemu-iotests/007
index 0139264..c454f2c 100755
--- a/tests/qemu-iotests/007
+++ b/tests/qemu-iotests/007
@@ -50,10 +50,9 @@  _make_test_img 1M
 
 for i in `seq 1 10`; do
     echo "savevm $i"
-    # XXX(hch): adding -nographic would be good, but hangs the test
-    $QEMU -hda $TEST_IMG -monitor stdio >/dev/null 2>&1 <<EOF     
-savevm test-$i                                                              
-quit                                                                        
+    $QEMU -nographic -hda $TEST_IMG -serial none -monitor stdio >/dev/null 2>&1 <<EOF
+savevm test-$i
+quit
 EOF
 done