Patchwork libbacktrace support

login
register
mail settings
Submitter Dmitry Plotnikov
Date March 14, 2013, 2:32 p.m.
Message ID <5141DF80.6060208@ispras.ru>
Download mbox | patch
Permalink /patch/227672/
State Changes Requested
Headers show

Comments

Dmitry Plotnikov - March 14, 2013, 2:32 p.m.
Hi,

GCC trunk requires libbacktrace since 26 Sep 2012.  This small patch 
adds the same hack as for libdecnum.

--
Best regards,
Plotnikov Dmitry.
--
For unsubscribe information see http://sourceware.org/lists.html#faq
Yann E. MORIN - March 14, 2013, 11:37 p.m.
Dmitry, All,

On Thursday 14 March 2013 Plotnikov Dmitry wrote:
> GCC trunk requires libbacktrace since 26 Sep 2012.  This small patch 
> adds the same hack as for libdecnum.

Missing your Signed-off-by.

> diff -rupdN ct-ng-1.18-clean/lib/ct-ng.1.18.0/scripts/build/cc/gcc.sh ct-ng-1.18/lib/ct-ng.1.18.0/scripts/build/cc/gcc.sh
> --- ct-ng-1.18-clean/lib/ct-ng.1.18.0/scripts/build/cc/gcc.sh   2013-02-01 00:07:53.000000000 +0400
> +++ ct-ng-1.18/lib/ct-ng.1.18.0/scripts/build/cc/gcc.sh 2013-03-14 15:18:54.957801549 +0400
> @@ -404,6 +407,13 @@ do_cc_core_backend() {
>              CT_DoExecLog CFG make ${JOBSFLAGS} configure-gcc configure-libcpp configure-build-libiberty
>              CT_DoExecLog ALL make ${JOBSFLAGS} all-libcpp all-build-libiberty
>          fi
> +
> +        # HACK: gcc-4.8 uses libbacktrace, so build it here.
> +        if [ -d "${CT_SRC_DIR}/gcc-${CT_CC_VERSION}/libbacktrace" ]; then
> +            CT_DoExecLog CFG make ${JOBSFLAGS} configure-libbacktrace
> +            CT_DoExecLog ALL make ${JOBSFLAGS} -C libbacktrace all
> +        fi
> +
>          # HACK: gcc-4.2 uses libdecnumber to build libgcc.mk, so build it here.
>          if [ -d "${CT_SRC_DIR}/gcc-${CT_CC_VERSION}/libdecnumber" ]; then
>              CT_DoExecLog CFG make ${JOBSFLAGS} configure-libdecnumber

Not much to say, looks good to me.

I'll postpone testing this till the WE.

Thank you!

Regards,
Yann E. MORIN.
Dmitry Plotnikov - March 20, 2013, 9:42 a.m.
Yann, All,

Resending with signed-off-by.

Signed-off-by: "Plotnikov Dmitry" <leitz@ispras.ru>

diff -rupdN ct-ng-1.18-clean/lib/ct-ng.1.18.0/scripts/build/cc/gcc.sh
ct-ng-1.18/lib/ct-ng.1.18.0/scripts/build/cc/gcc.sh
--- ct-ng-1.18-clean/lib/ct-ng.1.18.0/scripts/build/cc/gcc.sh
2013-02-01 00:07:53.000000000 +0400
+++ ct-ng-1.18/lib/ct-ng.1.18.0/scripts/build/cc/gcc.sh 2013-03-14
15:18:54.957801549 +0400
@@ -404,6 +407,13 @@ do_cc_core_backend() {
             CT_DoExecLog CFG make ${JOBSFLAGS} configure-gcc
configure-libcpp configure-build-libiberty
             CT_DoExecLog ALL make ${JOBSFLAGS} all-libcpp all-build-libiberty
         fi
+
+        # HACK: gcc-4.8 uses libbacktrace, so build it here.
+        if [ -d "${CT_SRC_DIR}/gcc-${CT_CC_VERSION}/libbacktrace" ]; then
+            CT_DoExecLog CFG make ${JOBSFLAGS} configure-libbacktrace
+            CT_DoExecLog ALL make ${JOBSFLAGS} -C libbacktrace all
+        fi
+
         # HACK: gcc-4.2 uses libdecnumber to build libgcc.mk, so build it here.
         if [ -d "${CT_SRC_DIR}/gcc-${CT_CC_VERSION}/libdecnumber" ]; then
             CT_DoExecLog CFG make ${JOBSFLAGS} configure-libdecnumber

--
For unsubscribe information see http://sourceware.org/lists.html#faq
Yann E. MORIN - May 3, 2013, 3:07 p.m.
Dmitry, All,

On Wed, Mar 20, 2013 at 01:42:12PM +0400, Dmitry Plotnikov wrote:
> Resending with signed-off-by.
> 
> Signed-off-by: "Plotnikov Dmitry" <leitz@ispras.ru>

This patch did not apply cleanly because it was improperly prepared.
Someone else submitted the same earlier today, which applied fine, so I
applied it instead.

> diff -rupdN ct-ng-1.18-clean/lib/ct-ng.1.18.0/scripts/build/cc/gcc.sh
              ^^^^^^^^^^^^^^^^^^^^^
This caused issues applying the patch.

Next time, please prepare and send the patches with:
    hg email --outgoing

Regards,
Yann E. MORIN.

Patch

diff -rupdN ct-ng-1.18-clean/lib/ct-ng.1.18.0/scripts/build/cc/gcc.sh ct-ng-1.18/lib/ct-ng.1.18.0/scripts/build/cc/gcc.sh
--- ct-ng-1.18-clean/lib/ct-ng.1.18.0/scripts/build/cc/gcc.sh	2013-02-01 00:07:53.000000000 +0400
+++ ct-ng-1.18/lib/ct-ng.1.18.0/scripts/build/cc/gcc.sh	2013-03-14 15:18:54.957801549 +0400
@@ -404,6 +407,13 @@  do_cc_core_backend() {
             CT_DoExecLog CFG make ${JOBSFLAGS} configure-gcc configure-libcpp configure-build-libiberty
             CT_DoExecLog ALL make ${JOBSFLAGS} all-libcpp all-build-libiberty
         fi
+
+        # HACK: gcc-4.8 uses libbacktrace, so build it here.
+        if [ -d "${CT_SRC_DIR}/gcc-${CT_CC_VERSION}/libbacktrace" ]; then
+            CT_DoExecLog CFG make ${JOBSFLAGS} configure-libbacktrace
+            CT_DoExecLog ALL make ${JOBSFLAGS} -C libbacktrace all
+        fi
+
         # HACK: gcc-4.2 uses libdecnumber to build libgcc.mk, so build it here.
         if [ -d "${CT_SRC_DIR}/gcc-${CT_CC_VERSION}/libdecnumber" ]; then
             CT_DoExecLog CFG make ${JOBSFLAGS} configure-libdecnumber