From patchwork Thu Mar 14 08:23:33 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 227490 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-vb0-x23d.google.com (mail-vb0-x23d.google.com [IPv6:2607:f8b0:400c:c02::23d]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id EA5102C00A0 for ; Thu, 14 Mar 2013 19:23:37 +1100 (EST) Received: by mail-vb0-f61.google.com with SMTP id fs19sf772909vbb.16 for ; Thu, 14 Mar 2013 01:23:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:received-spf:x-auditid:from:to:cc :references:in-reply-to:subject:date:message-id:mime-version :x-mailer:thread-index:x-brightmail-tracker:x-brightmail-tracker :dlp-filter:x-mtr:x-cfilter-loop:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-google-group-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe:content-type:content-language; bh=fFB3VSHJwLT2nSHuum5BJoEQPA3OCAZYI6Xn6lNMtC8=; b=JNJpcAsyofSvlkMkE5Qsx6VjDQ5PruJPpX4X2EDie7yy0mOEvrmkFFk8Y1zahp0uAl QCI/8xtcfr+k60jbTKvD00OUnMPfuGKGGqqB3/tFUP8ibJoGI/8aCL/746fEnlsPLpes 6gf8npuTkxpQ57F5H5Tf/Cq+PTjzV15Mi/8EwwZwWdITH5bxNQL5r+HXbnxgTUD30CFD xCFFEWT7cYh271yktNIM+DapUTywPhAYy9Z/R6REOyz6iWJkFlsCz37j1rEY7AJEy/FM XNy6nbKMwlIfGifyfj+TL5qAasSjVUYLQ/Y7e7c9HtBx/CRPF5bo4VpVq4nUxbT4XQg+ bbiQ== X-Received: by 10.50.150.180 with SMTP id uj20mr3099194igb.7.1363249414719; Thu, 14 Mar 2013 01:23:34 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.158.231 with SMTP id wx7ls3235111igb.5.gmail; Thu, 14 Mar 2013 01:23:34 -0700 (PDT) X-Received: by 10.68.210.15 with SMTP id mq15mr928690pbc.2.1363249414364; Thu, 14 Mar 2013 01:23:34 -0700 (PDT) Received: from mailout1.samsung.com (mailout1.samsung.com. [203.254.224.24]) by gmr-mx.google.com with ESMTP id tj3si654549pbc.0.2013.03.14.01.23.34; Thu, 14 Mar 2013 01:23:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.24 as permitted sender) client-ip=203.254.224.24; Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MJN00DIR5YEN3S0@mailout1.samsung.com> for rtc-linux@googlegroups.com; Thu, 14 Mar 2013 17:23:33 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.47]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id DC.A6.20872.50981415; Thu, 14 Mar 2013 17:23:33 +0900 (KST) X-AuditID: cbfee68d-b7f786d000005188-34-51418905abab Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 45.EE.17838.50981415; Thu, 14 Mar 2013 17:23:33 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MJN004DA5Z94Z21@mmp1.samsung.com> for rtc-linux@googlegroups.com; Thu, 14 Mar 2013 17:23:33 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' References: <008401ce208b$5c9dc6f0$15d954d0$%han@samsung.com> In-reply-to: <008401ce208b$5c9dc6f0$15d954d0$%han@samsung.com> Subject: [rtc-linux] [PATCH 27/30] rtc: rtc-test: use devm_rtc_device_register() Date: Thu, 14 Mar 2013 17:23:33 +0900 Message-id: <009e01ce208d$376c11f0$a64435d0$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4gi1x0RMHvEnZmRRqxNJmQP3DTwgAAc9XQ X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrHIsWRmVeSWpSXmKPExsVy+t8zfV3WTsdAg/2rZS32d3YwOjB67Jl4 ki2AMYrLJiU1J7MstUjfLoEro2F9I1vBA86K3lvnmRsYOzi6GDk5JARMJDbtf8UIYYtJXLi3 nq2LkYtDSGAZo0RD3x1WmKKjBy6zQiQWMUq8P/GXGcKZySTxu3shE0gVm4CaxJcvh9m7GDk4 RAT0JdpaNEBqmAV6GSXO9O4GiwsJ2Epc/28HYnIK2ElsWC8G0iks4CJx8Nx5FpAwi4CqxILX miBhXqDiS5fPMkPYghI/Jt9jAbGZBbQk1u88zgRhy0tsXvOWGaRVQkBd4tFfXZCwiICRxIY1 fYwQJSIS+168YwQ5RkJgFbvE4hXzwN5iERCQ+Db5EAtEr6zEpgPMEN9KShxccYNlAqPELCSb ZyHZPAvJ5llIVixgZFnFKJpakFxQnJReZKhXnJhbXJqXrpecn7uJERJXvTsYbx+wPsSYDLR+ IrOUaHI+MC7zSuINjc2MLExNTI2NzC3NSBNWEudVa7EOFBJITyxJzU5NLUgtii8qzUktPsTI xMEp1cDIYFomxrvx9QSZuE+GZW9/r5zhdor5rvelVTOfWDVV/7aIXRh7TkDmUvQd31USdvz5 /nHiMjqndt39ctLx27Njh+6+nni7qynrX3OS6+UZ22JP1Lh7MHLuDD+s9PN02k+WDqMjDWLl rJPPqk6c075BaGrMHLNVWlt/3svouPpqgbLvpb2HxKuDlFiKMxINtZiLihMBFzy328ECAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupmleLIzCtJLcpLzFFi42I5/e+xgC5rp2Ogwf2jkhb7OzsYHRg99kw8 yRbAGNXAaJORmpiSWqSQmpecn5KZl26r5B0c7xxvamZgqGtoaWGupJCXmJtqq+TiE6DrlpkD NFZJoSwxpxQoFJBYXKykb4dpQmiIm64FTGOErm9IEFyPkQEaSFjHmNGwvpGt4AFnRe+t88wN jB0cXYycHBICJhJHD1xmhbDFJC7cW8/WxcjFISSwiFHi/Ym/zBDOTCaJ390LmUCq2ATUJL58 OczexcjBISKgL9HWogFSwyzQyyhxpnc3WFxIwFbi+n87EJNTwE5iw3oxkE5hAReJg+fOs4CE WQRUJRa81gQJ8wIVX7p8lhnCFpT4MfkeC4jNLKAlsX7ncSYIW15i85q3zCCtEgLqEo/+6oKE RQSMJDas6WOEKBGR2PfiHeMERqFZSCbNQjJpFpJJs5C0LGBkWcUomlqQXFCclJ5rqFecmFtc mpeul5yfu4kRHLXPpHYwrmywOMQowMGoxMN7oN8hUIg1say4MvcQowQHs5IIr6eXY6AQb0pi ZVVqUX58UWlOavEhxmSgPycyS4km5wMTSl5JvKGxiZmRpZGZhZGJuTlpwkrivAdarQOFBNIT S1KzU1MLUotgtjBxcEo1MHalTesWDi5aUrhu8q/jnbVRzA9vfVm9ZNkzxgXzTefx+bv9Xvgw 55SgAm89T3zmHBWv17NdGJZEOd76bVfoqHhGK26106/oWboxi1fvmJO9gFnqLKvvb4c501gl bmYzHVh62MK16s3ax+sfll+QCpYNPPJ2Z4N8WL33jiu5b7SmPLV4w6vZoKjEUpyRaKjFXFSc CADFrMcjHgMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.24 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by: Jingoo Han --- drivers/rtc/rtc-test.c | 10 ++++------ 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-test.c b/drivers/rtc/rtc-test.c index b92e0f6..7746e65 100644 --- a/drivers/rtc/rtc-test.c +++ b/drivers/rtc/rtc-test.c @@ -99,8 +99,10 @@ static DEVICE_ATTR(irq, S_IRUGO | S_IWUSR, test_irq_show, test_irq_store); static int test_probe(struct platform_device *plat_dev) { int err; - struct rtc_device *rtc = rtc_device_register("test", &plat_dev->dev, - &test_rtc_ops, THIS_MODULE); + struct rtc_device *rtc; + + rtc = devm_rtc_device_register(&plat_dev->dev, "test", + &test_rtc_ops, THIS_MODULE); if (IS_ERR(rtc)) { err = PTR_ERR(rtc); return err; @@ -115,15 +117,11 @@ static int test_probe(struct platform_device *plat_dev) return 0; err: - rtc_device_unregister(rtc); return err; } static int test_remove(struct platform_device *plat_dev) { - struct rtc_device *rtc = platform_get_drvdata(plat_dev); - - rtc_device_unregister(rtc); device_remove_file(&plat_dev->dev, &dev_attr_irq); return 0;