| Submitter | Jingoo Han |
|---|---|
| Date | March 14, 2013, 8:22 a.m. |
| Message ID | <009b01ce208d$13fc1c10$3bf45430$%han@samsung.com> |
| Download | mbox | patch |
| Permalink | /patch/227487/ |
| State | New |
| Headers | show
Return-Path: <rtc-linux+bncBDTJ5LFEQQCBBS4RQ2FAKGQELVG4ZWA@googlegroups.com> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-ve0-f190.google.com (mail-ve0-f190.google.com [209.85.128.190]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id CC0082C00A0 for <incoming@patchwork.ozlabs.org>; Thu, 14 Mar 2013 19:22:37 +1100 (EST) Received: by mail-ve0-f190.google.com with SMTP id b10sf777777vea.27 for <incoming@patchwork.ozlabs.org>; Thu, 14 Mar 2013 01:22:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:received-spf:x-auditid:from:to:cc :references:in-reply-to:subject:date:message-id:mime-version :x-mailer:thread-index:x-brightmail-tracker:x-brightmail-tracker :dlp-filter:x-mtr:x-cfilter-loop:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-google-group-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe:content-type:content-language; bh=nZ+S76M+KC8KW6Fc1H5qHXVcharMFB7FxDtf7xBl660=; b=HAhwRYSrrHvCIi2zDio+M88o3YnGlCn84zc/OGbT9PMljrMXLwu6ipodI/RBpW5Q3r Fl4QTUSJtZNxHbGSDm4hN+CKvMNhtnZaovwUUO94PEnC+aHPbfcyJmzndgc74atYS13c btXLpUR/oC9UYzYEW2fuoAr4+dguZmnHdFyKXTAhM/lWWVwdaCkLj9tzu8gX+77M9AC5 aAa5QhnNZdgzpRBcRV0TpB+VJjXWR7VoI+7bIewfmT8q6n+US4RlNaqojGQeFJNAf4uM JsERKIKLylnSfek3FIMxuplI/ZDkZUJzBFLZu880SchYUDylW/ApuCp4YBx8SQCkF4su JPBQ== X-Received: by 10.50.6.135 with SMTP id b7mr194293iga.9.1363249355231; Thu, 14 Mar 2013 01:22:35 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.170.72 with SMTP id ak8ls3280883igc.3.gmail; Thu, 14 Mar 2013 01:22:34 -0700 (PDT) X-Received: by 10.68.161.163 with SMTP id xt3mr917211pbb.7.1363249354940; Thu, 14 Mar 2013 01:22:34 -0700 (PDT) Received: from mailout4.samsung.com (mailout4.samsung.com. [203.254.224.34]) by gmr-mx.google.com with ESMTP id ir9si651372pbc.1.2013.03.14.01.22.34; Thu, 14 Mar 2013 01:22:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) client-ip=203.254.224.34; Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MJN00KWN5XMVFV0@mailout4.samsung.com> for rtc-linux@googlegroups.com; Thu, 14 Mar 2013 17:22:34 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.50]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id 1D.0F.02019.AC881415; Thu, 14 Mar 2013 17:22:34 +0900 (KST) X-AuditID: cbfee690-b7f656d0000007e3-a8-514188c97cd5 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 1E.F8.13494.9C881415; Thu, 14 Mar 2013 17:22:33 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MJN0062E5XLV6I0@mmp1.samsung.com> for rtc-linux@googlegroups.com; Thu, 14 Mar 2013 17:22:33 +0900 (KST) From: Jingoo Han <jg1.han@samsung.com> To: 'Andrew Morton' <akpm@linux-foundation.org> Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' <a.zummo@towertech.it>, rtc-linux@googlegroups.com, 'Jingoo Han' <jg1.han@samsung.com> References: <008401ce208b$5c9dc6f0$15d954d0$%han@samsung.com> In-reply-to: <008401ce208b$5c9dc6f0$15d954d0$%han@samsung.com> Subject: [rtc-linux] [PATCH 24/30] rtc: rtc-rx8581: use devm_rtc_device_register() Date: Thu, 14 Mar 2013 17:22:33 +0900 Message-id: <009b01ce208d$13fc1c10$3bf45430$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4gi1x0RMHvEnZmRRqxNJmQP3DTwgAAayBw X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrHIsWRmVeSWpSXmKPExsVy+t8zI91THY6BBlsnMlns7+xgdGD02DPx JFsAYxSXTUpqTmZZapG+XQJXxq6ZU9kLtnNU7GrczdrA2MzexcjJISFgInH1xQlGCFtM4sK9 9WxdjFwcQgLLGCVmn9zE0sXIAVbUPs8EIr6IUWLNnj9MEM5MJol5vzcwg3SzCahJfPlymB2k QURAX6KtRQOkhlmgl1HiTO9usLiQgK3E9f92ICangJ3EhvViIJ3CAm4SXZuWgU1hEVCVaDtx lBXE5gWqvrxgHzuELSjxY/I9FhCbWUBLYv3O40wQtrzE5jVvmSHOVJd49FcXJCwiYCSx4f1E RogSEYl9L94xglwjIbCIXWLyy3YWiF0CEt8mH4J6UVZi0wFmSDBIShxccYNlAqPELCSbZyHZ PAvJ5llIVixgZFnFKJpakFxQnJReZKJXnJhbXJqXrpecn7uJERJXE3Yw3jtgfYgxGWj9RGYp 0eR8YFzmlcQbGpsZWZiamBobmVuakSasJM6r3mIdKCSQnliSmp2aWpBaFF9UmpNafIiRiYNT qoFx2d/GV3K7il5e55vAbqanwJv4VjGxbdfCx8+vpXwS3tSazeS5N9XsQuNF8RnMD2/dSwp1 tK2Mvj7Zb72gqL2YZ5jZVxGhIsu+yysWpHSUhC4PNOeS+ym2zfdVacnjtWfs58jn3nS5eurZ LvuCtTOf7JFrPnj65qng0oNsm0+Y8R8JfRphUP5aiaU4I9FQi7moOBEAshnF08ECAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupmleLIzCtJLcpLzFFi42I5/e+xgO7JDsdAg56L1hb7OzsYHRg99kw8 yRbAGNXAaJORmpiSWqSQmpecn5KZl26r5B0c7xxvamZgqGtoaWGupJCXmJtqq+TiE6DrlpkD NFZJoSwxpxQoFJBYXKykb4dpQmiIm64FTGOErm9IEFyPkQEaSFjHmLFr5lT2gu0cFbsad7M2 MDazdzFycEgImEi0zzPpYuQEMsUkLtxbz9bFyMUhJLCIUWLNnj9MEM5MJol5vzcwg1SxCahJ fPlyGKxZREBfoq1FA6SGWaCXUeJM726wuJCArcT1/3YgJqeAncSG9WIgncICbhJdm5aBTWER UJVoO3GUFcTmBaq+vGAfO4QtKPFj8j0WEJtZQEti/c7jTBC2vMTmNW+ZIU5Wl3j0VxckLCJg JLHh/URGiBIRiX0v3jFOYBSahWTSLCSTZiGZNAtJywJGllWMoqkFyQXFSem5RnrFibnFpXnp esn5uZsYwVH7THoH46oGi0OMAhyMSjy8EaKOgUKsiWXFlbmHGCU4mJVEeD29gEK8KYmVValF +fFFpTmpxYcYk4EencgsJZqcD0woeSXxhsYmZkaWRmYWRibm5qQJK4nzHmy1DhQSSE8sSc1O TS1ILYLZwsTBKdXAOPXI5MNp9+7qvVsu6PXr++TsKE7BOxL8EzJlp2p9ikrfmF49yUfXITnz Xq3Dsy93JPU782WOsIacm6DUkG7m8DfsyFz9albtvHzeS9N3qMY4BCxwns517JzELGtNx1t7 t5201CzesExUktPkyy3lBYvkWAr8o1X81y+bsPlZ9tNPuXO9Dxl9UGIpzkg01GIuKk4EACvk TFweAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: <rtc-linux.googlegroups.com> X-Google-Group-Id: 712029733259 List-Post: <http://groups.google.com/group/rtc-linux/post?hl=en_US>, <mailto:rtc-linux@googlegroups.com> List-Help: <http://groups.google.com/support/?hl=en_US>, <mailto:rtc-linux+help@googlegroups.com> List-Archive: <http://groups.google.com/group/rtc-linux?hl=en_US> Sender: rtc-linux@googlegroups.com List-Subscribe: <http://groups.google.com/group/rtc-linux/subscribe?hl=en_US>, <mailto:rtc-linux+subscribe@googlegroups.com> List-Unsubscribe: <http://groups.google.com/group/rtc-linux/subscribe?hl=en_US>, <mailto:googlegroups-manage+712029733259+unsubscribe@googlegroups.com> Content-type: text/plain; charset=ISO-8859-1 Content-language: ko |
Comments
Patch
diff --git a/drivers/rtc/rtc-rx8581.c b/drivers/rtc/rtc-rx8581.c index b0c2726..07f3037 100644 --- a/drivers/rtc/rtc-rx8581.c +++ b/drivers/rtc/rtc-rx8581.c @@ -240,8 +240,8 @@ static int rx8581_probe(struct i2c_client *client, dev_info(&client->dev, "chip found, driver version " DRV_VERSION "\n"); - rtc = rtc_device_register(rx8581_driver.driver.name, - &client->dev, &rx8581_rtc_ops, THIS_MODULE); + rtc = devm_rtc_device_register(&client->dev, rx8581_driver.driver.name, + &rx8581_rtc_ops, THIS_MODULE); if (IS_ERR(rtc)) return PTR_ERR(rtc); @@ -253,10 +253,6 @@ static int rx8581_probe(struct i2c_client *client, static int rx8581_remove(struct i2c_client *client) { - struct rtc_device *rtc = i2c_get_clientdata(client); - - rtc_device_unregister(rtc); - return 0; }
devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by: Jingoo Han <jg1.han@samsung.com> --- drivers/rtc/rtc-rx8581.c | 8 ++------ 1 files changed, 2 insertions(+), 6 deletions(-)