From patchwork Thu Mar 14 08:19:11 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 227478 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-vc0-f185.google.com (mail-vc0-f185.google.com [209.85.220.185]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id AA5622C00A0 for ; Thu, 14 Mar 2013 19:19:16 +1100 (EST) Received: by mail-vc0-f185.google.com with SMTP id gf12sf120136vcb.22 for ; Thu, 14 Mar 2013 01:19:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:received-spf:x-auditid:from:to:cc :references:in-reply-to:subject:date:message-id:mime-version :x-mailer:thread-index:x-brightmail-tracker:x-brightmail-tracker :dlp-filter:x-mtr:x-cfilter-loop:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-google-group-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe:content-type:content-language; bh=PhxJhgCBWX5FE2qbxtffY+jDsYREOzZ5agBsXDgHWy8=; b=A3xW+f2kFMpDeDakYvLMukCfemptIQaNaskd4JjOdpLo6b8cn+eFTP1jIlE9W+XBzh 8PTzRVcFknxFdm5+B53pl5bQnepPuk3CVWVXSmVLrJ0GQJX8THu7GqTO1+BpgADihC8n XHdDzAz1gR2J/5YVyGOgN5YEGQFuhzTSAY1hC90i59y+wX7eXPgMbTVqNDXbdA0g16Os HQn/bQAVVUhzbySw8DyAvstXJrA5JxqxgItw8Pk9yi8F1tzJLjQKNchaE6So3vjG60Gz 80Dw8neStgajKjwcCROya7xJQvdPvoD56lSTMOwHipZunZJeXum8Svs7IKegohopdkP4 MHdg== X-Received: by 10.50.185.200 with SMTP id fe8mr193628igc.0.1363249153515; Thu, 14 Mar 2013 01:19:13 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.56.238 with SMTP id d14ls3208685igq.30.gmail; Thu, 14 Mar 2013 01:19:13 -0700 (PDT) X-Received: by 10.68.222.101 with SMTP id ql5mr924119pbc.0.1363249153013; Thu, 14 Mar 2013 01:19:13 -0700 (PDT) Received: from mailout3.samsung.com (mailout3.samsung.com. [203.254.224.33]) by gmr-mx.google.com with ESMTP id ir9si647985pbc.1.2013.03.14.01.19.12; Thu, 14 Mar 2013 01:19:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.33 as permitted sender) client-ip=203.254.224.33; Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MJN0088V5RUM310@mailout3.samsung.com> for rtc-linux@googlegroups.com; Thu, 14 Mar 2013 17:19:12 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.49]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id A9.54.20872.FF781415; Thu, 14 Mar 2013 17:19:11 +0900 (KST) X-AuditID: cbfee68d-b7f786d000005188-03-514187ff56a0 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id CA.9D.17838.FF781415; Thu, 14 Mar 2013 17:19:11 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MJN00I5G5RZTIA0@mmp2.samsung.com>; Thu, 14 Mar 2013 17:19:11 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' References: <008401ce208b$5c9dc6f0$15d954d0$%han@samsung.com> In-reply-to: <008401ce208b$5c9dc6f0$15d954d0$%han@samsung.com> Subject: [rtc-linux] [PATCH 15/30] rtc: rtc-m48t86: use devm_rtc_device_register() Date: Thu, 14 Mar 2013 17:19:11 +0900 Message-id: <009201ce208c$9b5b8660$d2129320$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4gi1x0RMHvEnZmRRqxNJmQP3DTwgAANIkg X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrGIsWRmVeSWpSXmKPExsVy+t8zQ93/7Y6BBm3rbCyWXLzKbjFn/Ro2 i8sLL7FaXN41h81if2cHowOrx56JJ9k8Tsz4zeLRt2UVo8f0eT+ZPD5vkgtgjeKySUnNySxL LdK3S+DKWPjhH1vBf46K3h1XmRoY97B3MXJySAiYSEz+8xTKFpO4cG89WxcjF4eQwDJGicfT VzDCFL3818gCkZjOKHGs9wo7hPOLUWL/th4WkCo2ATWJL18OAyU4OEQE9CXaWjRAapgFehkl zvTuBosLCdhKXP9vB2JyCthJbFgvBtIpLOAm0XSxC2wKi4CqxO4pm9lAbF6g6t0vHrNC2IIS PybfA6thFtCSWL/zOBOELS+xec1bZpCREgLqEo/+6oKERQSMJF6sngZVIiKx78U7RpBrJATu sUtMW7WFEWKXgMS3yYdYIHplJTYdYIZ4V1Li4IobLBMYJWYh2TwLyeZZSDbPQrJiASPLKkbR 1ILkguKk9CJDveLE3OLSvHS95PzcTYyQOO3dwXj7gPUhxmSg9ROZpUST84FxnlcSb2hsZmRh amJqbGRuaUaasJI4r1qLdaCQQHpiSWp2ampBalF8UWlOavEhRiYOTqkGRvbJynwCt5+vzlpe c5mN0b+sabOE0eei3MxVMjl2xjecGv1nOCwR0tvw5u6PP+dbm/Yps7BmyDI9leqdI8r7QD/3 39mfGrUJ06f/FlGbsOf35E/OXeYL2YQEuEp6C4wq8rZlm/1fk6I4/XrSy1lPL0yWmXRI5kWT zXUpxhV79Y93WFo8O9zWqcRSnJFoqMVcVJwIANsrD0bpAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrMKsWRmVeSWpSXmKPExsVy+t9jQd3/7Y6BBgf+mFssuXiV3WLO+jVs FpcXXmK1uLxrDpvF/s4ORgdWjz0TT7J5nJjxm8Wjb8sqRo/p834yeXzeJBfAGtXAaJORmpiS WqSQmpecn5KZl26r5B0c7xxvamZgqGtoaWGupJCXmJtqq+TiE6DrlpkDtF1JoSwxpxQoFJBY XKykb4dpQmiIm64FTGOErm9IEFyPkQEaSFjHmLHwwz+2gv8cFb07rjI1MO5h72Lk5JAQMJF4 +a+RBcIWk7hwbz1bFyMXh5DAdEaJY71X2CGcX4wS+7f1gFWxCahJfPlyGCjBwSEioC/R1qIB UsMs0MsocaZ3N1hcSMBW4vp/OxCTU8BOYsN6MZBOYQE3iaaLXWBTWARUJXZP2cwGYvMCVe9+ 8ZgVwhaU+DH5HlgNs4CWxPqdx5kgbHmJzWveMoOMlBBQl3j0VxckLCJgJPFi9TSoEhGJfS/e MU5gFJqFZNIsJJNmIZk0C0nLAkaWVYyiqQXJBcVJ6bmGesWJucWleel6yfm5mxjBSeCZ1A7G lQ0WhxgFOBiVeHgP9DsECrEmlhVX5h5ilOBgVhLh9fRyDBTiTUmsrEotyo8vKs1JLT7EmAz0 6ERmKdHkfGCCyiuJNzQ2MTOyNDKzMDIxNydNWEmc90CrdaCQQHpiSWp2ampBahHMFiYOTqkG xmNbN5kJJV5cy13AHjT7Uu/DiFCJqxNPzz75sWzT3FcKNxIdVyYITq/3rgzh4fl6VDf626eZ jBL5szvYou8t1VwwLb84KlFAhJFPt1g4Zf95tZAJ52SbDwg9rr3nsbr34OotfxX0i9/OO7J4 4s5/+Vu63vxgaHb/0sduHRe68eehu369266JBSqxFGckGmoxFxUnAgDy36G/RgMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.33 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by: Jingoo Han --- drivers/rtc/rtc-m48t86.c | 11 ++++------- 1 files changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-m48t86.c b/drivers/rtc/rtc-m48t86.c index 2ffbcac..33a91c4 100644 --- a/drivers/rtc/rtc-m48t86.c +++ b/drivers/rtc/rtc-m48t86.c @@ -148,8 +148,10 @@ static int m48t86_rtc_probe(struct platform_device *dev) { unsigned char reg; struct m48t86_ops *ops = dev->dev.platform_data; - struct rtc_device *rtc = rtc_device_register("m48t86", - &dev->dev, &m48t86_rtc_ops, THIS_MODULE); + struct rtc_device *rtc; + + rtc = devm_rtc_device_register(&dev->dev, "m48t86", + &m48t86_rtc_ops, THIS_MODULE); if (IS_ERR(rtc)) return PTR_ERR(rtc); @@ -166,11 +168,6 @@ static int m48t86_rtc_probe(struct platform_device *dev) static int m48t86_rtc_remove(struct platform_device *dev) { - struct rtc_device *rtc = platform_get_drvdata(dev); - - if (rtc) - rtc_device_unregister(rtc); - platform_set_drvdata(dev, NULL); return 0;