From patchwork Thu Mar 14 08:16:07 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 227473 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-pb0-f61.google.com (mail-pb0-f61.google.com [209.85.160.61]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id B2A0E2C00A0 for ; Thu, 14 Mar 2013 19:16:11 +1100 (EST) Received: by mail-pb0-f61.google.com with SMTP id ro8sf734403pbb.26 for ; Thu, 14 Mar 2013 01:16:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:received-spf:x-auditid:from:to:cc :references:in-reply-to:subject:date:message-id:mime-version :x-mailer:thread-index:x-brightmail-tracker:x-brightmail-tracker :dlp-filter:x-mtr:x-cfilter-loop:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-google-group-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe:content-type:content-language; bh=y+Df/lxdDxQJldUOSfwfkmo/XoK6qfAnLd4n/cRqLzo=; b=OmHs3kqZTca4BzT5ObgXpFMi07lb9z5hygKcKRcKL3VZcouWAW9wDYXHH5gv4XXmai ggampPdDiX4n3SHNtv0i/3YLeMynMD/Z3X/shCaPJ3XHdQmOYxLBngrd56BBmDloMMtM TnLa9RXRlOmi0lydfB60eyEAwkJ9GQ/Ove6w28V2M0ip7kbafu+yfziWJwT4d6nrNYGw p09D9TCGCvsgZ34teeRm+zKp8q/cu6JCymjpajrjIRMFjhU2dPmRuaHSs8rZuavUIfjq UCPWof2fEgA2+cCuiIH33ONkDBwPBhdAlWIJkKLOu265G5Cttb62mQ7CPLdhtMsFbMbh cyZw== X-Received: by 10.50.41.67 with SMTP id d3mr198342igl.4.1363248969435; Thu, 14 Mar 2013 01:16:09 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.214.68 with SMTP id ny4ls3337361igc.36.gmail; Thu, 14 Mar 2013 01:16:09 -0700 (PDT) X-Received: by 10.68.210.15 with SMTP id mq15mr916065pbc.2.1363248969188; Thu, 14 Mar 2013 01:16:09 -0700 (PDT) Received: from mailout4.samsung.com (mailout4.samsung.com. [203.254.224.34]) by gmr-mx.google.com with ESMTP id ir9si644207pbc.1.2013.03.14.01.16.09; Thu, 14 Mar 2013 01:16:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) client-ip=203.254.224.34; Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MJN00KGO5MWVFV0@mailout4.samsung.com> for rtc-linux@googlegroups.com; Thu, 14 Mar 2013 17:16:08 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.48]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id A5.62.20872.84781415; Thu, 14 Mar 2013 17:16:08 +0900 (KST) X-AuditID: cbfee68d-b7f786d000005188-cf-514187487a5a Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id FB.47.13494.84781415; Thu, 14 Mar 2013 17:16:08 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MJN00IMW5MVW670@mmp2.samsung.com>; Thu, 14 Mar 2013 17:16:08 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' References: <008401ce208b$5c9dc6f0$15d954d0$%han@samsung.com> In-reply-to: <008401ce208b$5c9dc6f0$15d954d0$%han@samsung.com> Subject: [rtc-linux] [PATCH 14/30] rtc: rtc-m41t94: use devm_rtc_device_register() Date: Thu, 14 Mar 2013 17:16:07 +0900 Message-id: <009101ce208c$2e132540$8a396fc0$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4gi1x0RMHvEnZmRRqxNJmQP3DTwgAAMRCw X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrMIsWRmVeSWpSXmKPExsVy+t8zA12PdsdAg7e7BC2WXLzKbjFn/Ro2 i8sLL7FaXN41h81if2cHowOrx56JJ9k8Tsz4zeLRt2UVo8f0eT+ZPD5vkgtgjeKySUnNySxL LdK3S+DKOH5VpOAre8W0D3PYGhgPsXUxcnJICJhIvF+3kgXCFpO4cG89UJyLQ0hgGaPEitXd 7DBF0x68ZASxhQSmM0qs3CwIUfSLUeLdsQlgRWwCahJfvhwGsjk4RAT0JdpaNEBqmAV6GSXO 9O4GiwsJ2Epc/28HYnIK2ElsWC8G0iks4CZx7vxTsBtYBFQlJm1bxApi8wJVL/66D8oWlPgx +R5YDbOAlsT6nceZIGx5ic1r3jKDjJQQUJd49FcX4gAjiQ23oapFJPa9eMcIcoyEwCV2ieW7 5jJCrBKQ+Db5EAtEq6zEpgPMEM9KShxccYNlAqPELCSLZyFZPAvJ4llIVixgZFnFKJpakFxQ nJReZKhXnJhbXJqXrpecn7uJERKhvTsYbx+wPsSYDLR+IrOUaHI+MMLzSuINjc2MLExNTI2N zC3NSBNWEudVa7EOFBJITyxJzU5NLUgtii8qzUktPsTIxMEp1cC4qHJSTtTUyksn7trl3ri3 2Gb5s4oTq66HpexQ+az+4vMvtVVtzvOcQ2pvepvn+KS11U4tCb8TLHNvb53Zs3JDa987fDEz jXQMGM8967/s9vyFnOhL4Xm3Fv9ZcCtD7dPXyu7PjyLWH9GL4TyxLMC13qlEp15j2m+vmbW/ 1j6uOc66SrrQd6OUEktxRqKhFnNRcSIAhd7Y6eYCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrAKsWRmVeSWpSXmKPExsVy+t9jQV2PdsdAg71zeS2WXLzKbjFn/Ro2 i8sLL7FaXN41h81if2cHowOrx56JJ9k8Tsz4zeLRt2UVo8f0eT+ZPD5vkgtgjWpgtMlITUxJ LVJIzUvOT8nMS7dV8g6Od443NTMw1DW0tDBXUshLzE21VXLxCdB1y8wB2q6kUJaYUwoUCkgs LlbSt8M0ITTETdcCpjFC1zckCK7HyAANJKxjzDh+VaTgK3vFtA9z2BoYD7F1MXJySAiYSEx7 8JIRwhaTuHBvPVhcSGA6o8TKzYJdjFxA9i9GiXfHJrCDJNgE1CS+fDkMZHNwiAjoS7S1aIDU MAv0Mkqc6d0NFhcSsJW4/t8OxOQUsJPYsF4MpFNYwE3i3PmnLCA2i4CqxKRti1hBbF6g6sVf 90HZghI/Jt8Dq2EW0JJYv/M4E4QtL7F5zVtmkJESAuoSj/7qQhxgJLHhNlS1iMS+F+8YJzAK zUIyaBaSQbOQDJqFpGUBI8sqRtHUguSC4qT0XCO94sTc4tK8dL3k/NxNjOD4fya9g3FVg8Uh RgEORiUe3ghRx0Ah1sSy4srcQ4wSHMxKIryeXkAh3pTEyqrUovz4otKc1OJDjMlAf05klhJN zgemprySeENjEzMjSyMzCyMTc3PShJXEeQ+2WgcKCaQnlqRmp6YWpBbBbGHi4JRqYIxRaTZQ FXi425ivyWH1lJr/3I0hRyPaGhMZORbzuZXyZm712nBW+3TFpbN3tHnbmI99YMv+emdKK7fU aWtJ1U/fHxx9t+tnz9ZnpoHtO+a7hVYyTcrS7Jpp57koqoBlagzPJqnsM3vKw8O6Cq2uXIq4 +uZeTeGlt7lW0/+JXzk3YfaFJ9v7LJVYijMSDbWYi4oTAeIfrxFDAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by: Jingoo Han --- drivers/rtc/rtc-m41t94.c | 9 ++------- 1 files changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-m41t94.c b/drivers/rtc/rtc-m41t94.c index 89266c6..cf655a9 100644 --- a/drivers/rtc/rtc-m41t94.c +++ b/drivers/rtc/rtc-m41t94.c @@ -124,8 +124,8 @@ static int m41t94_probe(struct spi_device *spi) return res; } - rtc = rtc_device_register(m41t94_driver.driver.name, - &spi->dev, &m41t94_rtc_ops, THIS_MODULE); + rtc = devm_rtc_device_register(&spi->dev, m41t94_driver.driver.name, + &m41t94_rtc_ops, THIS_MODULE); if (IS_ERR(rtc)) return PTR_ERR(rtc); @@ -136,11 +136,6 @@ static int m41t94_probe(struct spi_device *spi) static int m41t94_remove(struct spi_device *spi) { - struct rtc_device *rtc = spi_get_drvdata(spi); - - if (rtc) - rtc_device_unregister(rtc); - return 0; }