| Submitter | Jingoo Han |
|---|---|
| Date | March 14, 2013, 8:13 a.m. |
| Message ID | <008a01ce208b$ce90eb70$6bb2c250$%han@samsung.com> |
| Download | mbox | patch |
| Permalink | /patch/227466/ |
| State | New |
| Headers | show
Return-Path: <rtc-linux+bncBDTJ5LFEQQCBBKMNQ2FAKGQEYZCI3YQ@googlegroups.com> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-oa0-f55.google.com (mail-oa0-f55.google.com [209.85.219.55]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id C5BCB2C00A8 for <incoming@patchwork.ozlabs.org>; Thu, 14 Mar 2013 19:13:31 +1100 (EST) Received: by mail-oa0-f55.google.com with SMTP id i10sf772776oag.10 for <incoming@patchwork.ozlabs.org>; Thu, 14 Mar 2013 01:13:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:received-spf:x-auditid:from:to:cc :references:in-reply-to:subject:date:message-id:mime-version :x-mailer:thread-index:x-brightmail-tracker:x-brightmail-tracker :dlp-filter:x-mtr:x-cfilter-loop:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-google-group-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe:content-type:content-language; bh=KB7ByUmSE/psO/dPzPVSP8q1seWu+wbYFxFyVnqaVJc=; b=pwm/N1aG2wspW3T5Hi8SZUksgn09AuwphpDBS5xptnT0+uhEDRNtGRG6r+uhVyTQhC 2Hqz0uX1X17z8kWzLxEcj6bpYLyu1gmKOhfSD+XKAx2TVNCuy6+S4CeQx3s69Z3T3Km/ D1glpaXii+8aPObqNvTIN7COyLHRfKwXzLlpxAErZ5enof8BJaakQK5tdOVLyUoCIctJ RLs3RuF5rlWZ8j6BNXiKNshiBhxRX/ujxTltQLOcGRZB+emeOn2t4AzIY3BmYFbpOJpp Cvb6ZE7YwY2rU5Mup5NasUf8xVvthcMIyJ17R+uvG4f/cAWJ8MMk1lZXN+NF8jsyfw9F hzWw== X-Received: by 10.50.188.231 with SMTP id gd7mr3100676igc.9.1363248809176; Thu, 14 Mar 2013 01:13:29 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.33.207 with SMTP id t15ls3397826igi.41.gmail; Thu, 14 Mar 2013 01:13:28 -0700 (PDT) X-Received: by 10.68.132.73 with SMTP id os9mr907537pbb.4.1363248808900; Thu, 14 Mar 2013 01:13:28 -0700 (PDT) Received: from mailout4.samsung.com (mailout4.samsung.com. [203.254.224.34]) by gmr-mx.google.com with ESMTP id ka10si639005pbb.2.2013.03.14.01.13.28; Thu, 14 Mar 2013 01:13:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) client-ip=203.254.224.34; Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MJN00KAR5HRVFV0@mailout4.samsung.com> for rtc-linux@googlegroups.com; Thu, 14 Mar 2013 17:13:28 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.51]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id A8.5B.02019.7A681415; Thu, 14 Mar 2013 17:13:27 +0900 (KST) X-AuditID: cbfee690-b7f656d0000007e3-76-514186a736c6 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 96.2C.17838.7A681415; Thu, 14 Mar 2013 17:13:27 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MJN0048D5IFD4Y0@mmp1.samsung.com> for rtc-linux@googlegroups.com; Thu, 14 Mar 2013 17:13:27 +0900 (KST) From: Jingoo Han <jg1.han@samsung.com> To: 'Andrew Morton' <akpm@linux-foundation.org> Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' <a.zummo@towertech.it>, rtc-linux@googlegroups.com, 'Jingoo Han' <jg1.han@samsung.com> References: <008401ce208b$5c9dc6f0$15d954d0$%han@samsung.com> In-reply-to: <008401ce208b$5c9dc6f0$15d954d0$%han@samsung.com> Subject: [rtc-linux] [PATCH 07/30] rtc: rtc-ds3234: use devm_rtc_device_register() Date: Thu, 14 Mar 2013 17:13:27 +0900 Message-id: <008a01ce208b$ce90eb70$6bb2c250$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4gi1x0RMHvEnZmRRqxNJmQP3DTwgAAGUYg X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrLIsWRmVeSWpSXmKPExsVy+t8zY93lbY6BBh9f2ljs7+xgdGD02DPx JFsAYxSXTUpqTmZZapG+XQJXxt4NL5gL5nFUHN6k3cD4lq2LkZNDQsBE4sXsDiYIW0ziwr31 QHEuDiGBZYwSB7fvZ4UpOjHrDjNEYhGjRHPXO0aQhJDATCaJ3n8iIDabgJrEly+H2bsYOThE BPQl2lo0QOqZBXoZJc707gaLCwnYSlz/bwdicgrYSWxYLwbSKSzgJnHqyT52EJtFQFWi6cF6 FhCbF6j66pqrrBC2oMSPyffA4swCWhLrdx5ngrDlJTavecsMMlJCQF3i0V9dkLCIgJHEtGk/ oEpEJPa9ADmYC6hkGbtEd+NaqF0CEt8mH2KB6JWV2HSAGeJbSYmDK26wTGCUmIVk8ywkm2ch 2TwLyYoFjCyrGEVTC5ILipPSi0z0ihNzi0vz0vWS83M3MUKiasIOxnsHrA8xJgOtn8gsJZqc D4zKvJJ4Q2MzIwtTE1NjI3NLM9KElcR51VusA4UE0hNLUrNTUwtSi+KLSnNSiw8xMnFwSjUw rq0Jv5kVmbL5yW5NBZmm4v/n+p3F34hdPHiY9TBzg17jyd9sx085iywolzl6aNM9diWL1Kxz 82pvTBH8eWbKyx39H1eUPtVzkXWpymjKU6v4oeT0ZMF9v4t/17hVnXi5vcNt5uoZa9exlczV niXwhkdRaPOlKbsOXt/PeDfhaTHPfZYJzqtmbVJiKc5INNRiLipOBAAQqGqwwAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupileLIzCtJLcpLzFFi42I5/e+xgO7yNsdAg4WTLC32d3YwOjB67Jl4 ki2AMaqB0SYjNTEltUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMH aKySQlliTilQKCCxuFhJ3w7ThNAQN10LmMYIXd+QILgeIwM0kLCOMWPvhhfMBfM4Kg5v0m5g fMvWxcjJISFgInFi1h1mCFtM4sK99UBxLg4hgUWMEs1d7xhBEkICM5kkev+JgNhsAmoSX74c Zu9i5OAQEdCXaGvRAKlnFuhllDjTuxssLiRgK3H9vx2IySlgJ7FhvRhIp7CAm8SpJ/vYQWwW AVWJpgfrWUBsXqDqq2uuskLYghI/Jt8DizMLaEms33mcCcKWl9i85i0zyEgJAXWJR391QcIi AkYS06b9gCoRkdj34h3jBEahWUgmzUIyaRaSSbOQtCxgZFnFKJpakFxQnJSea6hXnJhbXJqX rpecn7uJERyzz6R2MK5ssDjEKMDBqMTDe6DfIVCINbGsuDL3EKMEB7OSCK+nl2OgEG9KYmVV alF+fFFpTmrxIcZkoEcnMkuJJucD00leSbyhsYmZkaWRmYWRibk5acJK4rwHWq0DhQTSE0tS s1NTC1KLYLYwcXBKNTCeuSXtJczXaHu4at6psoflZz3n1Mm/+P1wUdsXCX8X3W9hutfN2nPE VrX+Y3gc29e2VLzA0+RXYvtHlQLLW2sPC947Fm4nOoH18P6Slk/Zx3en2plsOSLb9rpp14Il U5JOB/BM18654/HF0vyU6QdVMdYrTSfOHNyvIRt5frXg7Ab+iR+Xnj6ixFKckWioxVxUnAgA eRDaph0DAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: <rtc-linux.googlegroups.com> X-Google-Group-Id: 712029733259 List-Post: <http://groups.google.com/group/rtc-linux/post?hl=en_US>, <mailto:rtc-linux@googlegroups.com> List-Help: <http://groups.google.com/support/?hl=en_US>, <mailto:rtc-linux+help@googlegroups.com> List-Archive: <http://groups.google.com/group/rtc-linux?hl=en_US> Sender: rtc-linux@googlegroups.com List-Subscribe: <http://groups.google.com/group/rtc-linux/subscribe?hl=en_US>, <mailto:rtc-linux+subscribe@googlegroups.com> List-Unsubscribe: <http://groups.google.com/group/rtc-linux/subscribe?hl=en_US>, <mailto:googlegroups-manage+712029733259+unsubscribe@googlegroups.com> Content-type: text/plain; charset=ISO-8859-1 Content-language: ko |
Comments
Patch
diff --git a/drivers/rtc/rtc-ds3234.c b/drivers/rtc/rtc-ds3234.c index 7a4495e..a66efd4 100644 --- a/drivers/rtc/rtc-ds3234.c +++ b/drivers/rtc/rtc-ds3234.c @@ -146,8 +146,8 @@ static int ds3234_probe(struct spi_device *spi) ds3234_get_reg(&spi->dev, DS3234_REG_CONT_STAT, &tmp); dev_info(&spi->dev, "Ctrl/Stat Reg: 0x%02x\n", tmp); - rtc = rtc_device_register("ds3234", - &spi->dev, &ds3234_rtc_ops, THIS_MODULE); + rtc = devm_rtc_device_register(&spi->dev, "ds3234", + &ds3234_rtc_ops, THIS_MODULE); if (IS_ERR(rtc)) return PTR_ERR(rtc); @@ -158,9 +158,6 @@ static int ds3234_probe(struct spi_device *spi) static int ds3234_remove(struct spi_device *spi) { - struct rtc_device *rtc = spi_get_drvdata(spi); - - rtc_device_unregister(rtc); return 0; }
devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by: Jingoo Han <jg1.han@samsung.com> --- drivers/rtc/rtc-ds3234.c | 7 ++----- 1 files changed, 2 insertions(+), 5 deletions(-)