From patchwork Thu Mar 14 08:13:04 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 227465 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-qe0-f64.google.com (mail-qe0-f64.google.com [209.85.128.64]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 1A5E12C0091 for ; Thu, 14 Mar 2013 19:13:08 +1100 (EST) Received: by mail-qe0-f64.google.com with SMTP id s14sf741439qeb.29 for ; Thu, 14 Mar 2013 01:13:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:received-spf:x-auditid:from:to:cc :references:in-reply-to:subject:date:message-id:mime-version :x-mailer:thread-index:x-brightmail-tracker:x-brightmail-tracker :dlp-filter:x-mtr:x-cfilter-loop:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-google-group-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe:content-type:content-language; bh=23ruaE0wd34e5mWA8gJGlBGS+WeP7HFqXlg3URfpPNQ=; b=GI2rC4+slISvrwMlLL6ezGXvzBEp/XuVQIDbZmStcg6LgYc2f1eewz9WeOHio6zPEF qRkAzqu0h5xr0JX0nxponJWTG0mMo3Bl2SGvBmE9UpwXfPr90B9Rer3LuFOS54A2lCe3 KakYDToBNUKy+X3ZOOVFM2jdzvb2j6e2sSoICjvRwj3zCOYjTR5g/9wJWHH6bdEuNuJ1 HJH0hoQeILha93uMS6Mn20InkNSdKHlMEDZuY8qtWatq+2uY0cRhCTqVuG5BoKd2Rz/X E0KI0fQG56SdkfAjCntPcDTlIZukpcyMUvYSQ6H27b0ezPM0cnUVzD1S0MpGEGVryP8z ej6w== X-Received: by 10.50.33.175 with SMTP id s15mr3118724igi.8.1363248786316; Thu, 14 Mar 2013 01:13:06 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.159.133 with SMTP id xc5ls3255784igb.3.canary; Thu, 14 Mar 2013 01:13:06 -0700 (PDT) X-Received: by 10.68.161.163 with SMTP id xt3mr901547pbb.7.1363248786044; Thu, 14 Mar 2013 01:13:06 -0700 (PDT) Received: from mailout4.samsung.com (mailout4.samsung.com. [203.254.224.34]) by gmr-mx.google.com with ESMTP id ir9si640892pbc.1.2013.03.14.01.13.05; Thu, 14 Mar 2013 01:13:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) client-ip=203.254.224.34; Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MJN00A8U5HT9O80@mailout4.samsung.com> for rtc-linux@googlegroups.com; Thu, 14 Mar 2013 17:13:05 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.47]) by epcpsbgr3.samsung.com (EPCPMTA) with SMTP id 4F.B5.05174.19681415; Thu, 14 Mar 2013 17:13:05 +0900 (KST) X-AuditID: cbfee68f-b7f4a6d000001436-be-5141869117df Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 7A.0C.17838.09681415; Thu, 14 Mar 2013 17:13:05 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MJN0071Q5HSDIB0@mmp1.samsung.com> for rtc-linux@googlegroups.com; Thu, 14 Mar 2013 17:13:04 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' References: <008401ce208b$5c9dc6f0$15d954d0$%han@samsung.com> In-reply-to: <008401ce208b$5c9dc6f0$15d954d0$%han@samsung.com> Subject: [rtc-linux] [PATCH 06/30] rtc: rtc-ds1672: use devm_rtc_device_register() Date: Thu, 14 Mar 2013 17:13:04 +0900 Message-id: <008901ce208b$c0e8fa80$42baef80$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4gi1x0RMHvEnZmRRqxNJmQP3DTwgAAFOdw X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrHIsWRmVeSWpSXmKPExsVy+t8zfd2JbY6BBqfvslrs7+xgdGD02DPx JFsAYxSXTUpqTmZZapG+XQJXxtbD65kLlnFW3D5+l62B8RJ7FyMnh4SAicSqq+ugbDGJC/fW s3UxcnEICSxjlDh/YA4LTNHutxsYQWwhgUWMEpdbxSGKZjJJXLz5jwkkwSagJvHly2GgSRwc IgL6Em0tGiA1zAK9jBJneneDxYUEbCWu/7cDMTkF7CQ2rBcD6RQWcJPY/2kuK4jNIqAqsXfG BLBVvEDVqxfuYoewBSV+TL4Hdg6zgJbE+p3HmSBseYnNa94yg4yUEFCXePRXFyQsImAkMXfR NGaIEhGJfS/eMYJcIyGwil2iobubGWKXgMS3yYdYIHplJTYdYIb4VlLi4IobLBMYJWYh2TwL yeZZSDbPQrJiASPLKkbR1ILkguKk9CJjveLE3OLSvHS95PzcTYyQuOrfwXj3gPUhxmSg9ROZ pUST84FxmVcSb2hsZmRhamJqbGRuaUaasJI4r1qLdaCQQHpiSWp2ampBalF8UWlOavEhRiYO TqkGxhPrts7lnvfr95LySVFbZk5Mb9gT7sJu80ztTJbodn7eXyuEvc7PZnAJaJL3q3xtv674 c8/UetZtuyesTRIqWp6Sa+umNsW9dP5V3Y1xYVVx/9+e2vjaJCB90X3fqlzxv42n9eczGkma rj45q6HE+nSxzqljCUF6Lce/Gtg38E5dsrXqMatlnBJLcUaioRZzUXEiANYWGkTBAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupmleLIzCtJLcpLzFFi42I5/e+xgO7ENsdAg0kzmCz2d3YwOjB67Jl4 ki2AMaqB0SYjNTEltUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMH aKySQlliTilQKCCxuFhJ3w7ThNAQN10LmMYIXd+QILgeIwM0kLCOMWPr4fXMBcs4K24fv8vW wHiJvYuRk0NCwERi99sNjBC2mMSFe+vZQGwhgUWMEpdbxbsYuYDsmUwSF2/+YwJJsAmoSXz5 chiomYNDREBfoq1FA6SGWaCXUeJM726wuJCArcT1/3YgJqeAncSG9WIgncICbhL7P81lBbFZ BFQl9s6YALaWF6h69cJd7BC2oMSPyfdYQGxmAS2J9TuPM0HY8hKb17xlBhkpIaAu8eivLkhY RMBIYu6iacwQJSIS+168Y5zAKDQLyaRZSCbNQjJpFpKWBYwsqxhFUwuSC4qT0nMN9YoTc4tL 89L1kvNzNzGCo/aZ1A7GlQ0WhxgFOBiVeHgP9DsECrEmlhVX5h5ilOBgVhLh9fRyDBTiTUms rEotyo8vKs1JLT7EmAz06ERmKdHkfGBCySuJNzQ2MTOyNDKzMDIxNydNWEmc90CrdaCQQHpi SWp2ampBahHMFiYOTqkGxumLHor6KTpZCIR82sd06SZnrstqFu73Mj8TUj+etXtbIboi8GNT sIl2+RUJzU/dU4+r1k4NenjnylJ/7qs7pDvvqVYu1f0kvMhr99ONIVxZQk+EM7uW9ld8MWvV OibK8+m0R7rotLzK8HV1+6bp9h+a/7/x/I9vz37Pm34ud9XnZ365oTvuHlZiKc5INNRiLipO BABdU1jsHgMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko devm_rtc_device_register() is device managed and makes cleanup paths simpler. Signed-off-by: Jingoo Han --- drivers/rtc/rtc-ds1672.c | 8 +------- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-ds1672.c b/drivers/rtc/rtc-ds1672.c index 45d65c0..3fc2a47 100644 --- a/drivers/rtc/rtc-ds1672.c +++ b/drivers/rtc/rtc-ds1672.c @@ -155,11 +155,6 @@ static const struct rtc_class_ops ds1672_rtc_ops = { static int ds1672_remove(struct i2c_client *client) { - struct rtc_device *rtc = i2c_get_clientdata(client); - - if (rtc) - rtc_device_unregister(rtc); - return 0; } @@ -177,7 +172,7 @@ static int ds1672_probe(struct i2c_client *client, dev_info(&client->dev, "chip found, driver version " DRV_VERSION "\n"); - rtc = rtc_device_register(ds1672_driver.driver.name, &client->dev, + rtc = devm_rtc_device_register(&client->dev, ds1672_driver.driver.name, &ds1672_rtc_ops, THIS_MODULE); if (IS_ERR(rtc)) @@ -202,7 +197,6 @@ static int ds1672_probe(struct i2c_client *client, return 0; exit_devreg: - rtc_device_unregister(rtc); return err; }