Patchwork mtd: nand: use more reasonable integer types

login
register
mail settings
Submitter Artem Bityutskiy
Date March 13, 2013, 12:05 p.m.
Message ID <1363176300-9016-1-git-send-email-dedekind1@gmail.com>
Download mbox | patch
Permalink /patch/227258/
State New
Headers show

Comments

Artem Bityutskiy - March 13, 2013, 12:05 p.m.
From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

Use 'unsigned int' instead of 'unsigned long' in the NAND chip description data
structure, because 32-bits is more than enough for our purposes. We do not need
64-bits, which is what we end up on 64-bit architectures. We declare many
instances of this data structure, so this should help saving some amount of
memory.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
---
 include/linux/mtd/nand.h |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
Artem Bityutskiy - March 14, 2013, 7:52 a.m.
On Wed, 2013-03-13 at 14:05 +0200, Artem Bityutskiy wrote:
> From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> 
> Use 'unsigned int' instead of 'unsigned long' in the NAND chip description data
> structure, because 32-bits is more than enough for our purposes. We do not need
> 64-bits, which is what we end up on 64-bit architectures. We declare many
> instances of this data structure, so this should help saving some amount of
> memory.
> 
> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

Pushed to l2-mtd.git.

Patch

diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h
index 0c40beb..e2c7173 100644
--- a/include/linux/mtd/nand.h
+++ b/include/linux/mtd/nand.h
@@ -578,8 +578,8 @@  struct nand_chip {
  * @pagesize: size of the NAND page in bytes; if 0, then the real page size (as
  *            well as the eraseblock size) is determined from the extended NAND
  *            chip ID array)
- * @erasesize: eraseblock size in bytes (determined from the extended ID if 0)
  * @chipsize: total chip size in MiB
+ * @erasesize: eraseblock size in bytes (determined from the extended ID if 0)
  * @options: stores various chip bit options
  */
 struct nand_flash_dev {
@@ -591,10 +591,10 @@  struct nand_flash_dev {
 		};
 		uint8_t id[8];
 	};
-	unsigned long pagesize;
-	unsigned long chipsize;
-	unsigned long erasesize;
-	unsigned long options;
+	unsigned int pagesize;
+	unsigned int chipsize;
+	unsigned int erasesize;
+	unsigned int options;
 };
 
 /**