Patchwork [03/26,FWTS-TEST] acpitables-0002: update test to keep in sync with fwts framework changes

login
register
mail settings
Submitter Colin King
Date March 13, 2013, 10:28 a.m.
Message ID <1363170533-10188-4-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/227244/
State Accepted
Headers show

Comments

Colin King - March 13, 2013, 10:28 a.m.
From: Colin Ian King <colin.king@canonical.com>

fwts commit 530a24cfd5773ffb3de540c5e53e004c7bef2351 added a test
name into the output of fwts, so add this into the test output.

Also, fix the 2nd test case that was identical to the first,  this is wrong,
it should be exercising the 2nd acpidump file and not the first.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 acpitables-0002/acpitables-0001.log |  2 +-
 acpitables-0002/acpitables-0002.log | 29 ++++++++++++++++++++++++++---
 2 files changed, 27 insertions(+), 4 deletions(-)
Ivan Hu - March 14, 2013, 3:05 a.m.
On 03/13/2013 06:28 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> fwts commit 530a24cfd5773ffb3de540c5e53e004c7bef2351 added a test
> name into the output of fwts, so add this into the test output.
>
> Also, fix the 2nd test case that was identical to the first,  this is wrong,
> it should be exercising the 2nd acpidump file and not the first.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   acpitables-0002/acpitables-0001.log |  2 +-
>   acpitables-0002/acpitables-0002.log | 29 ++++++++++++++++++++++++++---
>   2 files changed, 27 insertions(+), 4 deletions(-)
>
> diff --git a/acpitables-0002/acpitables-0001.log b/acpitables-0002/acpitables-0001.log
> index 592e9eb..298ae3c 100644
> --- a/acpitables-0002/acpitables-0001.log
> +++ b/acpitables-0002/acpitables-0001.log
> @@ -1,4 +1,4 @@
> -acpitables      ACPI table settings sanity checks.
> +acpitables      acpitables: ACPI table settings sanity checks.
>   acpitables      ----------------------------------------------------------
>   acpitables      Test 1 of 1: Check ACPI tables.
>   acpitables      PASSED: Test 1, Table APIC passed.
> diff --git a/acpitables-0002/acpitables-0002.log b/acpitables-0002/acpitables-0002.log
> index 592e9eb..9c43097 100644
> --- a/acpitables-0002/acpitables-0002.log
> +++ b/acpitables-0002/acpitables-0002.log
> @@ -1,7 +1,30 @@
> -acpitables      ACPI table settings sanity checks.
> +acpitables      acpitables: ACPI table settings sanity checks.
>   acpitables      ----------------------------------------------------------
>   acpitables      Test 1 of 1: Check ACPI tables.
> -acpitables      PASSED: Test 1, Table APIC passed.
> +acpitables      FAILED [MEDIUM] MADTAPICFlagsNonZero: Test 1, MADT Local
> +acpitables      APIC flags field, bits 1..31 are reserved and should be
> +acpitables      zero, but are set as: f.
> +acpitables      FAILED [MEDIUM] MADTAPICFlagsNonZero: Test 1, MADT Local
> +acpitables      APIC flags field, bits 1..31 are reserved and should be
> +acpitables      zero, but are set as: d.
> +acpitables      FAILED [MEDIUM] MADTIOAPICAddrZero: Test 1, MADT IO APIC
> +acpitables      address is zero, appears not to be defined.
> +acpitables      FAILED [MEDIUM] MADTIRQSrcISA: Test 1, MADT Interrupt
> +acpitables      Source Override Bus should be 0 for ISA bus.
> +acpitables      FAILED [MEDIUM] MADTIRQSrcFlags: Test 1, MADT Interrupt
> +acpitables      Source Override flags, bits 4..31 are reserved and should
> +acpitables      be zero, but are set as: ee.
> +acpitables      FAILED [MEDIUM] MADTIRQSrcISA: Test 1, MADT Interrupt
> +acpitables      Source Override Bus should be 0 for ISA bus.
> +acpitables      FAILED [MEDIUM] MADTIRQSrcFlags: Test 1, MADT Interrupt
> +acpitables      Source Override flags, bits 4..31 are reserved and should
> +acpitables      be zero, but are set as: fd.
> +acpitables      FAILED [MEDIUM] MADTLAPICNMIFlags: Test 1, MADT Local APIC
> +acpitables      NMI flags, bits 4..31 are reserved and should be zero, but
> +acpitables      are set as: ff.
> +acpitables      FAILED [MEDIUM] MADTLAPICNMIFlags: Test 1, MADT Local APIC
> +acpitables      NMI flags, bits 4..31 are reserved and should be zero, but
> +acpitables      are set as: 10.
>   acpitables      Table ECDT not present to check.
>   acpitables      Table FACP not present to check.
>   acpitables      Table HPET not present to check.
> @@ -12,6 +35,6 @@ acpitables      Table SBST not present to check.
>   acpitables      PASSED: Test 1, Table XSDT passed.
>   acpitables
>   acpitables      ==========================================================
> -acpitables      4 passed, 0 failed, 0 warnings, 0 aborted, 0 skipped, 0
> +acpitables      3 passed, 9 failed, 0 warnings, 0 aborted, 0 skipped, 0
>   acpitables      info only.
>   acpitables      ==========================================================
>

Acked-by: Ivan Hu <ivan.hu@canonical.com>
Keng-Yu Lin - March 14, 2013, 6:12 a.m.
On Wed, Mar 13, 2013 at 6:28 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> fwts commit 530a24cfd5773ffb3de540c5e53e004c7bef2351 added a test
> name into the output of fwts, so add this into the test output.
>
> Also, fix the 2nd test case that was identical to the first,  this is wrong,
> it should be exercising the 2nd acpidump file and not the first.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  acpitables-0002/acpitables-0001.log |  2 +-
>  acpitables-0002/acpitables-0002.log | 29 ++++++++++++++++++++++++++---
>  2 files changed, 27 insertions(+), 4 deletions(-)
>
> diff --git a/acpitables-0002/acpitables-0001.log b/acpitables-0002/acpitables-0001.log
> index 592e9eb..298ae3c 100644
> --- a/acpitables-0002/acpitables-0001.log
> +++ b/acpitables-0002/acpitables-0001.log
> @@ -1,4 +1,4 @@
> -acpitables      ACPI table settings sanity checks.
> +acpitables      acpitables: ACPI table settings sanity checks.
>  acpitables      ----------------------------------------------------------
>  acpitables      Test 1 of 1: Check ACPI tables.
>  acpitables      PASSED: Test 1, Table APIC passed.
> diff --git a/acpitables-0002/acpitables-0002.log b/acpitables-0002/acpitables-0002.log
> index 592e9eb..9c43097 100644
> --- a/acpitables-0002/acpitables-0002.log
> +++ b/acpitables-0002/acpitables-0002.log
> @@ -1,7 +1,30 @@
> -acpitables      ACPI table settings sanity checks.
> +acpitables      acpitables: ACPI table settings sanity checks.
>  acpitables      ----------------------------------------------------------
>  acpitables      Test 1 of 1: Check ACPI tables.
> -acpitables      PASSED: Test 1, Table APIC passed.
> +acpitables      FAILED [MEDIUM] MADTAPICFlagsNonZero: Test 1, MADT Local
> +acpitables      APIC flags field, bits 1..31 are reserved and should be
> +acpitables      zero, but are set as: f.
> +acpitables      FAILED [MEDIUM] MADTAPICFlagsNonZero: Test 1, MADT Local
> +acpitables      APIC flags field, bits 1..31 are reserved and should be
> +acpitables      zero, but are set as: d.
> +acpitables      FAILED [MEDIUM] MADTIOAPICAddrZero: Test 1, MADT IO APIC
> +acpitables      address is zero, appears not to be defined.
> +acpitables      FAILED [MEDIUM] MADTIRQSrcISA: Test 1, MADT Interrupt
> +acpitables      Source Override Bus should be 0 for ISA bus.
> +acpitables      FAILED [MEDIUM] MADTIRQSrcFlags: Test 1, MADT Interrupt
> +acpitables      Source Override flags, bits 4..31 are reserved and should
> +acpitables      be zero, but are set as: ee.
> +acpitables      FAILED [MEDIUM] MADTIRQSrcISA: Test 1, MADT Interrupt
> +acpitables      Source Override Bus should be 0 for ISA bus.
> +acpitables      FAILED [MEDIUM] MADTIRQSrcFlags: Test 1, MADT Interrupt
> +acpitables      Source Override flags, bits 4..31 are reserved and should
> +acpitables      be zero, but are set as: fd.
> +acpitables      FAILED [MEDIUM] MADTLAPICNMIFlags: Test 1, MADT Local APIC
> +acpitables      NMI flags, bits 4..31 are reserved and should be zero, but
> +acpitables      are set as: ff.
> +acpitables      FAILED [MEDIUM] MADTLAPICNMIFlags: Test 1, MADT Local APIC
> +acpitables      NMI flags, bits 4..31 are reserved and should be zero, but
> +acpitables      are set as: 10.
>  acpitables      Table ECDT not present to check.
>  acpitables      Table FACP not present to check.
>  acpitables      Table HPET not present to check.
> @@ -12,6 +35,6 @@ acpitables      Table SBST not present to check.
>  acpitables      PASSED: Test 1, Table XSDT passed.
>  acpitables
>  acpitables      ==========================================================
> -acpitables      4 passed, 0 failed, 0 warnings, 0 aborted, 0 skipped, 0
> +acpitables      3 passed, 9 failed, 0 warnings, 0 aborted, 0 skipped, 0
>  acpitables      info only.
>  acpitables      ==========================================================
> --
> 1.8.1.2
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>

Patch

diff --git a/acpitables-0002/acpitables-0001.log b/acpitables-0002/acpitables-0001.log
index 592e9eb..298ae3c 100644
--- a/acpitables-0002/acpitables-0001.log
+++ b/acpitables-0002/acpitables-0001.log
@@ -1,4 +1,4 @@ 
-acpitables      ACPI table settings sanity checks.
+acpitables      acpitables: ACPI table settings sanity checks.
 acpitables      ----------------------------------------------------------
 acpitables      Test 1 of 1: Check ACPI tables.
 acpitables      PASSED: Test 1, Table APIC passed.
diff --git a/acpitables-0002/acpitables-0002.log b/acpitables-0002/acpitables-0002.log
index 592e9eb..9c43097 100644
--- a/acpitables-0002/acpitables-0002.log
+++ b/acpitables-0002/acpitables-0002.log
@@ -1,7 +1,30 @@ 
-acpitables      ACPI table settings sanity checks.
+acpitables      acpitables: ACPI table settings sanity checks.
 acpitables      ----------------------------------------------------------
 acpitables      Test 1 of 1: Check ACPI tables.
-acpitables      PASSED: Test 1, Table APIC passed.
+acpitables      FAILED [MEDIUM] MADTAPICFlagsNonZero: Test 1, MADT Local
+acpitables      APIC flags field, bits 1..31 are reserved and should be
+acpitables      zero, but are set as: f.
+acpitables      FAILED [MEDIUM] MADTAPICFlagsNonZero: Test 1, MADT Local
+acpitables      APIC flags field, bits 1..31 are reserved and should be
+acpitables      zero, but are set as: d.
+acpitables      FAILED [MEDIUM] MADTIOAPICAddrZero: Test 1, MADT IO APIC
+acpitables      address is zero, appears not to be defined.
+acpitables      FAILED [MEDIUM] MADTIRQSrcISA: Test 1, MADT Interrupt
+acpitables      Source Override Bus should be 0 for ISA bus.
+acpitables      FAILED [MEDIUM] MADTIRQSrcFlags: Test 1, MADT Interrupt
+acpitables      Source Override flags, bits 4..31 are reserved and should
+acpitables      be zero, but are set as: ee.
+acpitables      FAILED [MEDIUM] MADTIRQSrcISA: Test 1, MADT Interrupt
+acpitables      Source Override Bus should be 0 for ISA bus.
+acpitables      FAILED [MEDIUM] MADTIRQSrcFlags: Test 1, MADT Interrupt
+acpitables      Source Override flags, bits 4..31 are reserved and should
+acpitables      be zero, but are set as: fd.
+acpitables      FAILED [MEDIUM] MADTLAPICNMIFlags: Test 1, MADT Local APIC
+acpitables      NMI flags, bits 4..31 are reserved and should be zero, but
+acpitables      are set as: ff.
+acpitables      FAILED [MEDIUM] MADTLAPICNMIFlags: Test 1, MADT Local APIC
+acpitables      NMI flags, bits 4..31 are reserved and should be zero, but
+acpitables      are set as: 10.
 acpitables      Table ECDT not present to check.
 acpitables      Table FACP not present to check.
 acpitables      Table HPET not present to check.
@@ -12,6 +35,6 @@  acpitables      Table SBST not present to check.
 acpitables      PASSED: Test 1, Table XSDT passed.
 acpitables      
 acpitables      ==========================================================
-acpitables      4 passed, 0 failed, 0 warnings, 0 aborted, 0 skipped, 0
+acpitables      3 passed, 9 failed, 0 warnings, 0 aborted, 0 skipped, 0
 acpitables      info only.
 acpitables      ==========================================================