Patchwork [U-Boot] spl:falcon:trats: Fix SPL image size computing.

login
register
mail settings
Submitter Przemyslaw Marczak
Date March 12, 2013, 1:41 p.m.
Message ID <1363095709-11085-1-git-send-email-p.marczak@samsung.com>
Download mbox | patch
Permalink /patch/227162/
State Accepted
Delegated to: Minkyu Kang
Headers show

Comments

Przemyslaw Marczak - March 12, 2013, 1:41 p.m.
"spl_imgsize" was set as decimal variable by "setexpr"
and this causes wrong image size written by "ext4write".
Preset this val with "0x" prefix allow to fix this issue.

Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Minkyu Kang <mk7.kang@samsung.com>
---
 include/configs/trats.h |    1 +
 1 file changed, 1 insertion(+)
Minkyu Kang - March 29, 2013, 2:43 a.m.
On 12/03/13 22:41, Przemyslaw Marczak wrote:
> "spl_imgsize" was set as decimal variable by "setexpr"
> and this causes wrong image size written by "ext4write".
> Preset this val with "0x" prefix allow to fix this issue.
> 
> Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Minkyu Kang <mk7.kang@samsung.com>
> ---
>  include/configs/trats.h |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/configs/trats.h b/include/configs/trats.h
> index 63745ac..1fd7943 100644
> --- a/include/configs/trats.h
> +++ b/include/configs/trats.h
> @@ -199,6 +199,7 @@
>  	"splfile=falcon.bin\0" \
>  	"spl_export=" \
>  		   "setexpr spl_imgsize ${splsize} + 8 ;" \
> +		   "setenv spl_imgsize 0x${spl_imgsize};" \
>  		   "setexpr spl_imgaddr ${spladdr} - 8 ;" \
>  		   "setexpr spl_addr_tmp ${spladdr} - 4 ;" \
>  		   "mw.b ${spl_imgaddr} 0x00 ${spl_imgsize};run loaduimage;" \
> 

applied to u-boot-samsung.

Thanks,
Minkyu Kang.

Patch

diff --git a/include/configs/trats.h b/include/configs/trats.h
index 63745ac..1fd7943 100644
--- a/include/configs/trats.h
+++ b/include/configs/trats.h
@@ -199,6 +199,7 @@ 
 	"splfile=falcon.bin\0" \
 	"spl_export=" \
 		   "setexpr spl_imgsize ${splsize} + 8 ;" \
+		   "setenv spl_imgsize 0x${spl_imgsize};" \
 		   "setexpr spl_imgaddr ${spladdr} - 8 ;" \
 		   "setexpr spl_addr_tmp ${spladdr} - 4 ;" \
 		   "mw.b ${spl_imgaddr} 0x00 ${spl_imgsize};run loaduimage;" \