From patchwork Tue Mar 12 17:24:32 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jing Yu X-Patchwork-Id: 227085 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 2EB462C0293 for ; Wed, 13 Mar 2013 04:25:01 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1363713902; h=Comment: DomainKey-Signature:Received:Received:Received:Received: MIME-Version:Received:In-Reply-To:References:Date:Message-ID: Subject:From:To:Content-Type:Content-Transfer-Encoding: Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:Sender:Delivered-To; bh=9bnpAju5J/lzW8Ii0hJY HQKrK4c=; b=nnDeN6b8LWSQbgqyiLslOI747DCzZwHjxiRW8zq+F1Fruv5yQXma Zwha46Z5EP1uKROyiyZPJjptEvNRWEFUviAQ3C8m8MTpOmIsaOjqBR/Pz1ImUKQ3 dt+dctpUtSMjP3GOVseV1vZEvquqi94hRXYyXAI7PLUZ1qwmmsWJhmg= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:X-Google-DKIM-Signature:MIME-Version:X-Received:Received:In-Reply-To:References:Date:Message-ID:Subject:From:To:Content-Type:Content-Transfer-Encoding:X-Gm-Message-State:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=viAhoHtUvICO1YdkjJrRJfaf5EwEmWs7YvgHzgdjZbccpYT0CbF5c9ZJ3f1eHO MUwt7Ji/RSgilLGcEED+z4y3Lu4aJN4jFvT8wUsA9bmGX9dR/BXcPLFC9+nGqU3K GZkqwftHc26wN4a2RGaVCf5rozsNBet4Fmk/7qqCQDgKU=; Received: (qmail 28379 invoked by alias); 12 Mar 2013 17:24:48 -0000 Received: (qmail 28299 invoked by uid 22791); 12 Mar 2013 17:24:46 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, KHOP_RCVD_TRUST, KHOP_THREADED, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE, RP_MATCHES_RCVD, TW_BF, TW_GR X-Spam-Check-By: sourceware.org Received: from mail-lb0-f174.google.com (HELO mail-lb0-f174.google.com) (209.85.217.174) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 12 Mar 2013 17:24:35 +0000 Received: by mail-lb0-f174.google.com with SMTP id l12so182257lbo.5 for ; Tue, 12 Mar 2013 10:24:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:content-type:content-transfer-encoding :x-gm-message-state; bh=2oyFdVUsuNwPlHRMZS5ugupM7+uHrBaBHzShyVmutNs=; b=ly5Vy8egvKq1Z2c33D5XlW3wVGbjphVMR92Xh8l9BDgPTm/FDRkLVAPvYfNQhOmHDa 5kGh6RdINl7woGpihaS1CoiwBcEzWbyHq6hdlZtpkoWKqOT4x7kKN7v20FJvBfK0Rhwz gxawLx3yeWCMWLrmodOTOry2++x1Mi2Hq/WmFXTf4Yp8urBBroRH3gTpbSqXTaWP/BE2 /eMAWSDz8OwZeYcm+K5IZ0UD+ZBnifhPnM86fYh4KYF2ag/9sPocAJ3B/tClTEFB06J5 m5qxmlJuJ1GFRq+zvb4/v0Y6/cgI+dEwYQ56bUwPZFF2RWDd6i3stY9pAePJo2DrGDIA 5Y3w== MIME-Version: 1.0 X-Received: by 10.112.39.106 with SMTP id o10mr6579056lbk.23.1363109073047; Tue, 12 Mar 2013 10:24:33 -0700 (PDT) Received: by 10.112.135.10 with HTTP; Tue, 12 Mar 2013 10:24:32 -0700 (PDT) In-Reply-To: References: <20130312000627.DC9C660488@jingyu.mtv.corp.google.com> Date: Tue, 12 Mar 2013 10:24:32 -0700 Message-ID: Subject: Re: [trunk][google/gcc47]Add dependence of configure-target-libmudflap on configure-target-libstdc++-v3 (issue7740043) From: Jing Yu To: gcc-patches , reply@codereview.appspotmail.com X-Gm-Message-State: ALoCoQkIRn9Z0HGPqFE9KHLWo7BQnnfWCn6JNFt7rOT52PwL3ObMvR/Ic6nDOp86pJt3jkRGlsfAKdkF7QnRoIEs1inETRZrYglouC4wwoP+PRrw0LoFKQORKA20EhOGk2gr1miU419SjbuzCOw4CXszb109p/LnJ5CUng3ehzqsMY8ZOdG5TtXhf6u6A88J1e4OddMkBmVV X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org I made a mistake in my previous patch. I did not notice that Makefile.in was a generated file. Update the patch. 2013-03-12 Jing Yu * Makefile.def (Target modules dependencies): Add new dependency. * Makefile.in: Re-generate. on=configure-target-libgomp; }; // parallel_list.o and parallel_settings.o depend on omp.h, which is // generated by the libgomp configure. Unfortunately, due to the use of On Mon, Mar 11, 2013 at 5:21 PM, Jing Yu wrote: > Don't know why the email body became attachment. Sent it again. > The review link is https://codereview.appspot.com/7740043 > > Hi Diego, > > The nightly build of gcc-4.7 based ppc64 and ppc32 crosstools have failed since > the build server upgraded to gPrecise one week ago. Log shows a configuration fa > ilure on libmudflap. > > checking for suffix of object files... /lib/cpp > configure: error: in > `/g/nightly/build/work/gcc-4.7.x-grtev3-powerpc32-8540/rpmbuild/BUILD/.../powerpc-grtev3-linux-gnu/libmudflap': > configure: error: C++ preprocessor "/lib/cpp" fails sanity check > See `config.log' for more details. > > There is no /lib/cpp on gprecise server, though it should not be used here. > > What happened was that libmudflap configure looks for a preprocessor > by trying $CXX -E and then backing off to /lib/cpp. $CXX -E is > failing with "unrecognized command line option > ‘-funconfigured-libstdc++’", and the /lib/cpp backstop then fails > also. The -funconfigured-libstdc++ is because configure can't find > libstdc++/scripts/testsuite_flags. This is a so-far undiagnosed race > in gcc make, masked where /lib/cpp is available. And that's absent > because in this build, for whatever reason, libstdc++ loses a race > with libmudflap. > > The theory is confirmed by: > 1) if we force --job=1, build can succeed > 2) If we apply the following patch to build-gcc/Makefile, build can > succeed. After removing this dependency, build fails with the same > error again. > > Is this patch ok for google/gcc-4_7? > > If the same issue exists on upstream trunk, how does the patch sound to trunk? > > Thanks, > Jing > > 2013-03-11 Jing Yu > > * Makefile.in: (maybe-configure-target-libmudflap): > Add dependence on configure-target-libstdc++-v3. > > Index: Makefile.in > =================================================================== > --- Makefile.in (revision 196604) > +++ Makefile.in (working copy) > @@ -31879,6 +31879,9 @@ maybe-configure-target-libmudflap: > @if gcc-bootstrap > configure-target-libmudflap: stage_current > @endif gcc-bootstrap > +@if target-libstdc++-v3 > +configure-target-libmudflap: configure-target-libstdc++-v3 > +@endif target-libstdc++-v3 > @if target-libmudflap > maybe-configure-target-libmudflap: configure-target-libmudflap > configure-target-libmudflap: Index: Makefile.in =================================================================== --- Makefile.in (revision 196604) +++ Makefile.in (working copy) @@ -44446,6 +44446,7 @@ all-target-libjava: maybe-all-target-boehm-gc all-target-libjava: maybe-all-target-libffi configure-target-libobjc: maybe-configure-target-boehm-gc all-target-libobjc: maybe-all-target-boehm-gc +configure-target-libmudflap: maybe-configure-target-libstdc++-v3 configure-target-libstdc++-v3: maybe-configure-target-libgomp configure-stage1-target-libstdc++-v3: maybe-configure-stage1-target-libgomp Index: Makefile.def =================================================================== --- Makefile.def (revision 196604) +++ Makefile.def (working copy) @@ -504,6 +504,7 @@ dependencies = { module=all-target-libjava; on=all dependencies = { module=all-target-libjava; on=all-target-libffi; }; dependencies = { module=configure-target-libobjc; on=configure-target-boehm-gc; }; dependencies = { module=all-target-libobjc; on=all-target-boehm-gc; }; +dependencies = { module=configure-target-libmudflap; on=configure-target-libstdc++-v3; }; dependencies = { module=configure-target-libstdc++-v3;